Commit Graph

60448 Commits

Author SHA1 Message Date
Joshua Duong
5866463e16 [a11y] Fix TalkBack readback on adb qrcode fragment.
TalkBack was picking up the text in the action bar, so if we hide it,
it will read the first body of text it encounters which would be "Scan
QR code. Pair device over Wi-Fi by scanning a QR code."

Bug: 152461605

Test: Manual. Enable TalkBack in Settings > Accessibility > TalkBack.
Navigate to Developer options > Wireless debugging > Pair by QR code.
When QR code scanner fragment opens, it should say "Scan QR code. Pair
device over Wi-Fi by scanning a QR code."

Change-Id: Ia91bf4ea215e6a377335f2b9dcf2acf10afd268e
(cherry picked from commit bfd73c0d78)
Exempt-From-Owner-Approval: cherry-pick
2020-04-07 18:06:37 +00:00
Joshua Duong
2a85924977 [a11y] Set focus on "Pairing device" text once QR code is scanned.
Bug: 152462657

Test: Manual. Enable TalkBack in Settings > Accessibility. Navigate to
Developer options > Wireless debugging > Pairing device with QR code.
Scan a valid QR code, which should change to "Pairing device..." and
screen reader should say "Pairing device".

Change-Id: If467b56f787bda765fce1e5d46f8ab3c6210dc76
(cherry picked from commit 07ad841e2d)
Exempt-From-Owner-Approval: cherry-pick
2020-04-07 18:06:25 +00:00
menghanli
be11a370e6 Fix gesture navigation popup is displaying inconsistently on the System navigation page.
- Need to use new api to get the accessibility service list.

Bug: 149665916
Test: local test
Change-Id: Ib712769436bf7be5fbea34ba2251bdbe6bcefb95
2020-04-07 22:42:20 +08:00
TreeHugger Robot
ceac4f44b9 Merge "Adjust tap targets in history" into rvc-dev am: 7c4557bec8
Change-Id: I650b9faf069cb50999d1a3d99665ff5d4411b956
2020-04-07 14:24:34 +00:00
TreeHugger Robot
7c4557bec8 Merge "Adjust tap targets in history" into rvc-dev 2020-04-07 14:12:35 +00:00
Automerger Merge Worker
7ab0499a38 Merge "Catch crash in mobile network ProgressDialog" am: aaee4539c7 am: 840506e88a am: 2d84cdbc3a am: e6c57426cd am: 7300bab2b6
Bug: 146057372

Change-Id: If80a964d28950288f042d4a1ccfc183b9c4f0067
(cherry picked from commit 0577514d0d)
2020-04-07 11:49:41 +00:00
TreeHugger Robot
6882062638 Merge "The text on toast should be changed when remains 1 time for SIM lock input" into rvc-dev am: 9a84a2d544
Change-Id: I275316f28e7cd9027a5e121b76f6af52283c8ad9
2020-04-07 11:39:41 +00:00
Bonian Chen
1df6c9cdd4 [Settings] Code refactor
Remove unused import

Bug: 10956255
Test: build pass
Change-Id: I256870483d85bf7000556357071834cad24884d1
2020-04-07 19:29:49 +08:00
TreeHugger Robot
9a84a2d544 Merge "The text on toast should be changed when remains 1 time for SIM lock input" into rvc-dev 2020-04-07 11:23:32 +00:00
TreeHugger Robot
a08e2e4976 Merge "Add keywords for system naviagtion setting" into rvc-dev am: e55fe59844
Change-Id: Ic357e80726731fad84ee277dfcc33afd8e8373a7
2020-04-07 10:37:43 +00:00
TreeHugger Robot
e55fe59844 Merge "Add keywords for system naviagtion setting" into rvc-dev 2020-04-07 10:22:07 +00:00
Tsung-Mao Fang
9c69ded434 The text on toast should be changed when remains 1 time for SIM lock input
This cl was cherry-picked from aosp/585306

The behavior of getQuantityString() is different according to language, it gets
both "other" and "one" string if English is system language. But it always gets
"other" string if non-English, then the "other" string of wrong_pin_code is
shown even if remains 1 time of SIM lock input.

In order to change the string in any language, we add new string for
remains 1 time.

Test: Rebuild rom
Fix: 71783850
Change-Id: If4b53bbbc6b51582bc0837abf4497d9a75ebbaad
2020-04-07 16:54:06 +08:00
Jason Chiu
b12e3b96c9 Support click metrics logs in several pages
- Assign metrics category to perferences at an earlier stage in
  DashboardFragment for better usability.

Bug: 137559984
Test: robotest
Change-Id: Icd4185efa0e655be20c4b673a1380fa42140923f
2020-04-07 16:44:53 +08:00
Tsung-Mao Fang
73c2a8b76f Add keywords for system naviagtion setting
Fix: 152979084
Test: Open setting search, see system navigation when I typed "swipe"
Change-Id: I2937276f9eb7e9534aa61e2c4b256ce218b99140
2020-04-07 16:39:29 +08:00
Tim Peng
6fb4059944 Transferring to a cast device should not close the output switcher
-Close panel only when on pause and stop
-Transfer device would set the play state to "STATE_NONE"
-Add test case

Bug: 152632226
Test: make -j42 RunSettingsRoboTests
Change-Id: Ibf6ce1454b1d5bf3facc07abec15b8735029f2cf
2020-04-07 08:02:30 +00:00
Tim Peng
2f87c336da Settings crashed by a null worker
-Add worker checker
-Add test case

Bug: 153356562
Test: make -j42 RunSettingsRoboTests
Change-Id: I129ff63a48b3785aacc846fe1dd67a926a8e5e1f
2020-04-07 07:48:38 +00:00
Arc Wang
c5c5d38005 Merge "[Wi-Fi] Index Wi-Fi preferences." into rvc-dev am: c707a93d00
Change-Id: If1dc968d1fd0ebca7fbe4dc45c7ab47c3a2f6215
2020-04-07 07:26:45 +00:00
Arc Wang
c707a93d00 Merge "[Wi-Fi] Index Wi-Fi preferences." into rvc-dev 2020-04-07 07:16:26 +00:00
Jason Chiu
664adc4691 Merge "Refine metrics log in infrastructure" into rvc-dev am: 4edb83b260
Change-Id: I70315838180df4c1af666d5ec0d1825dfa71ecd3
2020-04-07 06:46:40 +00:00
Jason Hsu
5aa7cde292 Merge "Add accessibility color inversion help resources to link to existing help page." into rvc-dev am: dfa6cf0d05
Change-Id: Ib64457cdeac0205a0551ca5834db15a083830f8d
2020-04-07 06:46:28 +00:00
Jason Chiu
4edb83b260 Merge "Refine metrics log in infrastructure" into rvc-dev 2020-04-07 06:33:30 +00:00
Jason Hsu
dfa6cf0d05 Merge "Add accessibility color inversion help resources to link to existing help page." into rvc-dev 2020-04-07 06:28:10 +00:00
Jason Chiu
819abf7f87 Refine metrics log in infrastructure
- Add interfaces to set/get metrics category in BasePreferenceController
  for descendants having a chance to get it.
- Set metrics category in DashboardFragment
- Automatically log metrics in onPreferenceChange of
  TogglePreferenceController
- Add support for TwoStateButtonPreference in TogglePreferenceController
  to make the preference generic

Bug: 137559984
Test: robotest
Change-Id: Ia7e0d24a3db1991b18e0286d9894570fa71247a3
2020-04-07 14:08:39 +08:00
Bonian Chen
14e8c6dba1 Merge "[Settings] Core refactor" into rvc-dev am: 1e5cf6525a
Change-Id: I81b538c5829d1c05e8ef54343d70fb8e17cbcc01
2020-04-07 06:02:23 +00:00
Menghan Li
54609663de Merge "Revise Q behavior migration of accessibility edit dialog" into rvc-dev am: 6c59995503
Change-Id: Ieb416e79e10a9f5a885c061f46f9b2c55f2a1356
2020-04-07 06:02:15 +00:00
Bonian Chen
1e5cf6525a Merge "[Settings] Core refactor" into rvc-dev 2020-04-07 05:57:28 +00:00
Menghan Li
6c59995503 Merge "Revise Q behavior migration of accessibility edit dialog" into rvc-dev 2020-04-07 05:54:56 +00:00
Menghan Li
57f7168c9e Merge "Support caption second UI structure (5/n)" into rvc-dev am: c0c522d999
Change-Id: Ic76b90acb28cf63bcee7ac953a8f14a5f346c20d
2020-04-07 04:39:10 +00:00
Menghan Li
0f576c7727 Merge "Support autoclick secondary action (8/n)" into rvc-dev am: 47b01403ee
Change-Id: If142e6cf0b0e979a8cca590523071217cffe4532
2020-04-07 04:38:54 +00:00
Menghan Li
c0c522d999 Merge "Support caption second UI structure (5/n)" into rvc-dev 2020-04-07 04:24:20 +00:00
Menghan Li
47b01403ee Merge "Support autoclick secondary action (8/n)" into rvc-dev 2020-04-07 04:23:56 +00:00
Bonian Chen
b1c7e21066 [Settings] Core refactor
Remove empty lines, and maintain the comments.

Bug: 150352656
Test: build pass
Change-Id: If0552d7ce20de5941667aa64e682202aaf32c597
2020-04-07 12:09:51 +08:00
jasonwshsu
7c073c4c40 Add accessibility color inversion help resources to link to existing help page.
Bug: 151604096
Bug: 150873532
Test: manual test
Change-Id: Ie042d822de3ff5017548b8d92c74b208ee1f3a02
2020-04-07 12:06:03 +08:00
Varun Shah
2aeedcde21 Update display logic for no shared data.
When there is no shared data, instead of showing an empty list view,
the developer option's summary is updated.

Additionally, for the two shared data screens, added the back button to
the action bar so that it matches the other screens in the Settings app.

Also, implemented PreferenceControllerMixin for the
SharedDataPreferenceController so that the dev option shows up in
settings search.

Bug: 153079829
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I6ec5c35fc262dc27a383af8e2593be5b349ee85f
2020-04-06 20:58:11 -07:00
TreeHugger Robot
7008d7a192 Merge "Add a developer setting for conversation enforcement" into rvc-dev am: 76b55e0b0a
Change-Id: I09354573eae552a56444be82e49b4037765e50e7
2020-04-07 03:57:57 +00:00
Zhen Zhang
0ea7803c18 Fix advanced preferences behavior in AllInOneTetherSettings am: b1d19a8b35
Change-Id: Ic3d6cc903c5b616af73888b5552794f45fbfab00
2020-04-07 03:56:53 +00:00
TreeHugger Robot
76b55e0b0a Merge "Add a developer setting for conversation enforcement" into rvc-dev 2020-04-07 03:47:02 +00:00
Julia Reynolds
94ad6a1959 Adjust tap targets in history
- Fix a crash if an app couldn't be launched
- Fix the height of tap targets and overlap of text

Fixes: 152977855
Fixes: 153199215
Change-Id: Id623f942c7663c977c61df3d1188fe498cab8acc
2020-04-06 19:44:40 +00:00
Zhen Zhang
b1d19a8b35 Fix advanced preferences behavior in AllInOneTetherSettings
In AllInOneTetherSettings, advanced preferences should not be hidden
again after user have expanded them.

Bug: 151954343
Test: CodeInspectionTest; AllInOneTetherSettingsTest; manually test oberved advanced preferences won't be hidden.
Change-Id: If2c7d99b7dcac4149f065eca73022a582924c90b
2020-04-06 19:14:41 +00:00
Fabian Kozynski
83df54b007 Added settings screens for Power Menu
This CL adds a new Preference in Gestures (Power Menu), moves Global
Actions to it (now renamed Cards & passes) and adds a new Preference for
Device controls.

Missing:
* Explanation video for Device controls
* Privacy settings

Test: robotests
Test: manual change settings
Bug: 152212779
Bug: 152329723
Change-Id: Ia8f69565307a5961c8435bc1f441abeb389acf8b
2020-04-06 13:06:52 -04:00
TreeHugger Robot
9eb9a9bb7c [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: df338dd652 -s ours
am skip reason: subject contains skip directive

Change-Id: I8d8146268f020bc46c7f78976dd14b2d1e08d5cd
2020-04-06 16:57:29 +00:00
TreeHugger Robot
5eb855a7f6 [automerger skipped] Merge "Import translations. DO NOT MERGE" into rvc-dev am: 293f7ce88c -s ours
am skip reason: subject contains skip directive

Change-Id: I6ace54b06bc3b9c47546e97d61b289bc3e833def
2020-04-06 16:52:44 +00:00
TreeHugger Robot
df338dd652 Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-04-06 16:38:44 +00:00
TreeHugger Robot
293f7ce88c Merge "Import translations. DO NOT MERGE" into rvc-dev 2020-04-06 16:33:27 +00:00
Julia Reynolds
dffd1ba351 Merge "Update history flow" into rvc-dev am: cb7fbe0faa
Change-Id: I19e879f61ff9259a0a4d021d35d9c96648bc8705
2020-04-06 13:55:17 +00:00
Julia Reynolds
ae9060246b Add a developer setting for conversation enforcement
Test: Robo tests
Fixes: 152907434
Change-Id: I4e16faf817349993a98955601829d1ad22fa3921
2020-04-06 09:53:31 -04:00
Julia Reynolds
cb7fbe0faa Merge "Update history flow" into rvc-dev 2020-04-06 13:37:33 +00:00
Bill Yi
a03995505f Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I0ee248806b1d77ca266c5ee47cc1420adfa465e6
2020-04-06 05:48:37 -07:00
Bill Yi
3aacc4e59a Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: If158e0aa6e1832b4d72901bb3fead8e1db4272c4
2020-04-06 05:16:34 -07:00
TreeHugger Robot
1bff922997 Merge "[Wi-Fi] Fix EntityHeader signal strength icon invisible problem" into rvc-dev am: 8efea18ca2
Change-Id: If3729a013ffcead7ab339cce0a99edb30b6177d4
2020-04-06 11:41:07 +00:00