Commit Graph

980 Commits

Author SHA1 Message Date
Amin Shaikh
04cae3b66a Populate summary for top level wifi picker options
Screenshot: https://drive.google.com/file/d/0B8qSkjrtrXEPLTh0ZTRnMWFWX2M/view

Bug: 36532777
Test: make RunSettingsRoboTests
Change-Id: I9b364ecc4d71de484216f848c853db91a2a08fa7
2017-03-24 17:49:06 +00:00
Doris Ling
47ec3857a5 Update preference text for Network & internet screen.
- Add footer info to Hotspot & tethering
- Add summary text for Data usage -> Network restrictions
- Update summary for Hotspot & tethering -> Portable Wi-Fi hotspot
- Remove quotes from Wi-Fi summary

Bug: 36296257
Test: make RunSettingsRoboTests

Change-Id: Ibab61b089521a3339e660e9df0db0cd1b316712b
2017-03-21 18:00:59 -07:00
Sundeep Ghuman
2df0bf9d5c Create a way to inject a WifiTracker into WifiSettings.
Bug: b/36403696
Test: Preliminary step to enable creation of Espresso tests b/36403696
Change-Id: I63c49cca0905a9d05964c11b3307ccf1859db7ec
2017-03-20 19:00:37 -07:00
Sundeep Ghuman
f35a55dee4 Add progress bar and delay to WifiSettings refresh.
This change shows the progress bar for 0.3 seconds before AccessPoints are
about to be refreshed and 1.7 afterwards for a total duration of roughly
2 seconds. This indirectly fixes issues with no longer having a refresh button,
indicates ongoing scanning to the user, and should help avoid user errors where
the user clicks on the wrong access point while the list is being updated.

In order to avoid excess UI movement, the progress bar off state is now set
to invisible rather than gone.

Bug: b/34774783
Test: Currently blocked on refactor, tracked in b/36403635 and will
start next week.
Change-Id: I2bb6b5b3d4611cdbfd7138c758785601896d05b9
2017-03-20 18:59:34 -07:00
TreeHugger Robot
c9be7e6ba7 Merge "Remove Index.java from old Search and its dependents" 2017-03-17 23:23:50 +00:00
Matthew Fritze
5c83cfa278 Remove Index.java from old Search and its dependents
Test: make RunSettingsRoboTests
Bug: 35763944, 36192909
Change-Id:  If216e1eeb4c29e7372720c6228fa4e99ea2a9904
2017-03-17 14:26:05 -07:00
Sundeep Ghuman
830e47a2d5 Revert picker icon sizes to 24dp.
Bug: b/36295036
Test: See screenshot in bug
Change-Id: I68af38163d6770e60195b245c38942c3844ead46
2017-03-17 12:44:55 -07:00
Amin Shaikh
1cf25748d6 Add "Use open Wi-Fi automatically" setting.
- Add toggle to ConfigureWifiSettings for "Use open Wi-Fi automatically"
- Start ACTION_CUSTOM_ENABLE activity and handle result to set the
USE_OPEN_WIFI_PACKAGE setting.

Bug: 34773276
Test: make
Change-Id: I602e271d5113e415d290468548e35059bd45d8b8
2017-03-16 16:54:20 -07:00
Sundeep Ghuman
4c1b174f5f Create robolectric tests for WifiNetworkDetailsFragment.
More tests to follow in separate CLs. Submitting test class in order to
unblock parallel development.

Bug: 35963536
Test: make RunSettingsRoboTests
Change-Id: I50752ba0d6c53d016bf5809f7bd5d5f6e0350b90
2017-03-15 15:34:42 -07:00
Stephen Chen
b77cbe5bb2 Fix Wi-Fi Settings Guest mode UI.
Progress bar should not show in guest mode when onViewCreated.

When Wi-Fi is off, Wi-Fi OFF tip should be shown even in guest
mode to be consistent with Wi-Fi status.

Bug: 35627922
Test: tracked in b/35324506
Change-Id: If89728e293721cea45dcd717316d87f6df17ea7c
2017-03-14 19:33:36 -07:00
Sundeep Ghuman
8f060d7148 Fix calculation of Access Point Level.
Bug: b/35854026
Test: make RunSettingsRoboTests
Change-Id: I5287e8c7b46a463cfa25659c756f6ca9175cb68c
2017-03-14 17:11:57 -07:00
Sundeep Ghuman
07db40434b Create the Wifi Network Details Page.
This page should not be searchable, as it corresponds to a specific
access point, thus click on a search result would not have an access
point in which to open.

Fix WifiPicker bugs b/35883232 and b/35951638 that deal with UI jank.

Bug: 34713316
Test: Tracked in b/35963536 and to be implemented in an immediate follow
up CL.
Change-Id: Iad7f26c7f04c3fc7d07a8e9188843eeb4d44cd36
2017-03-14 15:31:20 -07:00
Stephen Chen
53d0de2171 Merge "Show Search button in menu of Wifi Preferences page." 2017-03-08 22:24:52 +00:00
Stephen Chen
5bd534e3fc Merge "Remove refresh button from WifiSettings." 2017-03-08 21:46:59 +00:00
Stephen Chen
f580ccec19 Show Search button in menu of Wifi Preferences page.
Bug: 36066060
Change-Id: Ia40ca8750cfc5233926b6156bb9262b071bb3b85
Test: verify on device.
2017-03-08 12:40:18 -08:00
Stephen Chen
9f5aaa4e5f Remove refresh button from WifiSettings.
Bug: 34891524
Test: b/34673204 for instrumentation tests. Verified button is removed.
Change-Id: I0b30d36bd6b3f0b1361ef4f7dc775ed3545a7bdc
2017-03-08 11:58:13 -08:00
Stephen Chen
2d73008bae Create NetworkScorerPicker preference controller to set preference summary.
Bug: 35854552
Test: make ROBOTEST_FILTER=NetworkScorerPickerPreferenceControllerTest
RunSettingsRoboTests -j40

Change-Id: I6dbd18abd67613ed0f85a52f1a3e13fdab0dca6c
2017-03-07 18:52:01 -08:00
Matthew Fritze
b759516cbf Create whitelist for the most popular settings
As a temporary solution to getting the most popular
settings to be the top rank, we have created a white list.
If a prioritized setting shows up somewhere in the results
then it will be given an elevated rank to be at the top.

Bug: 35048659
Test: make RunSettingsRoboTests
Change-Id: I92b563a17b42d8f91d980dd1d8e5f8f29ca5aa9c
2017-03-06 12:31:41 -08:00
Peter Qiu
738695e5e8 Merge "wifi: use Passpoint API when forgetting a Passpoint network" am: ff960ed859 am: c5848718ee
am: d49c2ff80f

Change-Id: I2ffbf8cccd698cc8bd5145a7896243ea35107518
2017-03-02 17:01:27 +00:00
Peter Qiu
c5848718ee Merge "wifi: use Passpoint API when forgetting a Passpoint network"
am: ff960ed859

Change-Id: I0e085c5c31656c943d7674770ea9f28d963f2726
2017-03-02 16:57:25 +00:00
Peter Qiu
4ec020a424 wifi: use Passpoint API when forgetting a Passpoint network
Use WifiManager#removePasspointConfiguration when forgetting a
Passpoint network to remove the configuration.

This maintains the legacy behavior, where forgetting a Passpoint
network/AP will remove its provider's profile.

Bug: 34207710
Test: manual test
Change-Id: I8b7f6d9fb20fa9f0f0d90566f76c2a39308ce420
2017-03-01 10:13:07 -08:00
TreeHugger Robot
2228aecfbb Merge "Properly forget networks and refresh page in SavedAcessPointsWifiSettings." 2017-02-24 23:22:16 +00:00
Stephen Chen
2c10f078df Properly forget networks and refresh page in SavedAcessPointsWifiSettings.
The dialog access point rebuilt after fragment is destroyed (i.e.
orientation change) did not properly save selected Preference, and
caused NPE. Changed onForget to refresh preference list.

Bug: 35207121
Test: b/35322875 tracking bug for saved networks tests.
Change-Id: I81935c5a6e3efab4d4e3b6e7c2b150bacf06d7c1
2017-02-23 19:39:09 -08:00
Sundeep Ghuman
0b61e3028c Draw currently connected network in Picker.
Make sure to call refresh when adding the Access Point Preference to the
WifiPicker's Connected Access Point Category. This will case the icon
and the title to be drawn.

Bug: 35388267
Test: None. Too difficult without robolectric testing which requires
refactor.

Change-Id: I7949733f8ca7f904327872df54f6963c723bc704
2017-02-22 19:25:38 -08:00
TreeHugger Robot
33c51a7b5b Merge "Fix NPE in WriteWifiConfigToNfcDialog." 2017-02-16 20:26:39 +00:00
Amin Shaikh
5bac36a15a Fix NPE in WriteWifiConfigToNfcDialog.
Bug: 34691792
Test: m RunSettingsRoboTests
Change-Id: I0e396f4f590c8de6636c7494e20d74c562b7c9cd
2017-02-16 10:34:36 -08:00
Fan Zhang
c6ca314c0b Log source with visibility change
- Add a method in VisibilityLoggerMixin to log visible event using
  LogMaker, which allows logging additional FIELD_CONTEXT field.
- In Utils.startFragment, add current page's metricsCategory as an extra
  to next page.
- In next page's onResume(), extract the previous page's metricsCategory
  and send it to VisibilityLoggerMixin.visible()
- Update all caller with additional paramters

Change-Id: I8e1f2597fa465b7d3aa16fa1d21c052a3219694a
Fix: 35359289
Test: RunSettingsRoboTests
2017-02-15 17:17:19 -08:00
Stephen Chen
8fc61244ef Correctly restrict UI for WifiSettings in Guest profile.
Makes sure the restricted user does not see Wifi Preferences
or Saved Networks activity. Also fixes a bug where the progress
bar is displayed starting the activity in Guest mode, and does not go
away. LinkablePreference is changed to make sure titles can be
multi-lined.

Bug: 35317523
Bug: 35318292
Test: to be done in b/35324506
Change-Id: I4a07a2ab3a83c3adaf87226969fd6f16e41c9419
2017-02-15 11:50:38 -08:00
Stephen Chen
2e966c642f Create 'See All Networks' Preference to hide additional networks.
Bug: 34719725
Test: manual inspection, tests to be added in b/35322551
Change-Id: I1a5a08ca4c53db71b4c0c3d4c2942da65faa67d2
2017-02-14 10:25:53 -08:00
Stephen Chen
91acf78173 Hide "Use network recommendations" in Settings.
Bug: 35141347
Test: make -j40 RunSettingsRoboTests, manual inspection
Change-Id: I7661ef141aeb95d5ec707b8a066818892c3fa870
2017-02-08 13:42:19 -08:00
TreeHugger Robot
14c2050330 Merge "Misc fix on network & internet screen for developer preview" 2017-02-07 21:34:17 +00:00
Stephen Chen
aa0baffe32 Merge "Change number of showing tiles in ConfigureWifiSettings." 2017-02-07 20:23:01 +00:00
Stephen Chen
9f13c02e2d Change number of showing tiles in ConfigureWifiSettings.
Test: manual inspection.
Change-Id: Ieecbff4416c69e902b9f0c5b4e4fc91907420b17
2017-02-07 12:21:01 -08:00
Fan Zhang
56199e9487 Misc fix on network & internet screen for developer preview
- Move wifi calling into wifi preference screen
- Update tethering setting title
- Ripple for master swtich preference only apply on the left half.
- Move network reset to action bar overflow menu

Fix: 34974598
Fix: 34976385
Test: RunSettingsRoboTests
Change-Id: I0e11843efc52a0042784a4da46b7ac81fcf16138
2017-02-06 18:14:14 -08:00
Sundeep Ghuman
f200005086 Create a new PreferenceCategory for the current AP.
This highlights the currently connected ap in it's own category.

Bug: 34714183
Test: Manual inspection with connected AP, APs available but not
connected, and Wifi off.

Change-Id: I100bcf5b0bdc7b4f725f2ff630aa885dbca90332
2017-02-06 14:38:06 -08:00
TreeHugger Robot
c2ff3b972c Merge "Make picker icons scale larger." 2017-02-06 21:18:09 +00:00
Stephen Chen
30c3878194 Change number of preferences showing in ConfigureWifiSettings.
Test: manual inspection.
Change-Id: If6a9f8ada05ef56f2db4d394903ccf839a184e98
2017-02-03 16:24:48 -08:00
Stephen Chen
ac9f4af5e2 Make picker icons scale larger.
Bug: 34775322
Test: manual inspection.
Change-Id: Iaaa859874ec25a50677cb00bd963fc869c5b9649
2017-02-03 15:40:56 -08:00
Stephen Chen
a7b27b22b9 Hide ConfigureWifiPreference tiles behind Advanced
Also reordered the preferences.

Bug: 34889722
Test: manual inspection.
Change-Id: Ica2fda91e6fe98edae49bca687ebb2da83251770
2017-02-01 17:57:22 -08:00
Stephen Chen
9d2712cd78 Move AdvancedWifiSettings into ConfigureWifiSettings.
Bug:34719854
Test: make -j40 RunSettingsRoboTests
clicked on preferences and made sure functionality did not change.

Change-Id: Ia5f0c7f5ea0f88d1322008ab58ca79028cc1a2bb
2017-01-30 12:43:08 -08:00
Doris Ling
c4c9f4d50e Update Network & internet->Wi-Fi to use MasterSwitchPreference.
- Add a preference controller for Network & internet->Wi-Fi to control
  the preference toggling and summary update.
- Refactor WifiSettings and WifiEnabler to share code between the new
  wifi preference controller and the wifi setting.
- Refactor BluetoothSummaryHelper to have a common base class with the
  WifiSummaryHelper.
- Rename the summary helper to summary updater.

Bug: 34280769
Test: make RunSettingsRoboTests
Change-Id: I00ebfc161bcef89331bb41ba405ed8cb8232d248
2017-01-25 10:43:01 -08:00
TreeHugger Robot
889db88043 Merge "Add additional preference items to WifiSettings for configuring Wi-Fi." 2017-01-25 02:28:07 +00:00
Stephen Chen
4145678548 Add additional preference items to WifiSettings for configuring Wi-Fi.
Removed the gear icon that links to ConfigureWifiSettings activity,
and added links to ConfigureWifiSettings and SavedAccessPointSettings.
Included these links in the wifi disabled screen.

Also refactored code to have dividers between wifi list and other settings, and
changed refresh menu item to a button.

Bug: 34518148
Bug: 33110624
Test: Manual inspection
Change-Id: Ie40935f553faea59b7a76fc050d970d431cef5ad
2017-01-24 16:45:58 -08:00
Fan Zhang
7e6df837ee Remove getCategoryKey() from DashboardFragment children.
Use the centralized registry to look up category key instead.

Bug: 32936784
Test: make RunSettingsRoboTests -j40
Change-Id: I0b8c72d70f93e4b5c58871ac90de41f69ad15653
2017-01-24 14:51:15 -08:00
Tamas Berghammer
6031fba9f2 DO NOT MERGE: Revert "Update package names to work with the proto3 compiler"
am: 5a638a6ad1

Change-Id: If23c0926eecf6a08ed0c0ab174cdddb43e31cc00
2017-01-18 20:24:36 +00:00
Tamas Berghammer
5a638a6ad1 DO NOT MERGE: Revert "Update package names to work with the proto3 compiler"
This reverts commit fbd5f5fdce.

Change-Id: I769f7a0f509996ccc39fd1c628cad7e5ec1202bf
2017-01-18 19:28:11 +00:00
Tamas Berghammer
6cd7e52b9e Update package names to work with the proto3 compiler
am: fbd5f5fdce

Change-Id: I20b3bc10cf66bb94369631cef229787b5e6353b6
2017-01-18 17:45:33 +00:00
TreeHugger Robot
08853706c5 Merge "Add activity action for Configure Wi-Fi settings." 2017-01-12 23:25:51 +00:00
Amin Shaikh
5e096a3969 Add Settings toggle for Wi-Fi Wakeup.
- Added switch toggle to Configure Wi-Fi Settings for Wi-Fi Wakeup
- Disable Wi-Fi Open Networks Notifications and Wi-Fi Wakeup toggles
  if NETWORK_RECOMMENDATIONS_ENABLED is disabled

Test: make -j40 RunSettingsRoboTests
Bug: 33224845
Change-Id: I2a52c5d1e60f618aefa125c7806fa95ca19a0ca9
2017-01-11 15:11:55 -08:00
Amin Shaikh
3aa547b50d Add activity action for Configure Wi-Fi settings.
Bug: 34135303
Test: make -j40 RunSettingsRoboTests
Change-Id: Ieec7a1aa913553c74c6ebf9fb3d868e03e0c3bf6
2017-01-11 18:40:32 +00:00