Commit Graph

7906 Commits

Author SHA1 Message Date
Salvador Martinez
b94251ad07 Remove airplane mode restriction on hotspot
This isn't needed anymore since we support this now.

Test: robotests
Bug: 111681176
Change-Id: I0292f0a38347e4fa3414170e0351a53f5997a192
2019-03-08 16:34:57 -08:00
Quang Luong
0df143834a Use getTitle() for AccessPoint display name
Instead of getSsidStr(), AccessPoint display names should use
getTitle() to accomodate Passpoint networks which use a provider
name instead of a single ssid. This change allows the provider
name to be displayed in the network details page, the long
press wifi dialog, and the config editing dialog.

Bug: 118705403
Test: atest WifiSettingsTest
Change-Id: I930d6218c7e464ad20c0c61130e0cb9ce315d9a2
2019-03-08 14:42:29 -08:00
Hai Zhang
93cfd2e28e Use a boolean Consumer instead of RoleManagerCallback.
And use RemoteCallback for it under the hood. This removes one AIDL
interface and allows using lambda, while aligning with what
PermissionControllerService does.

Bug: 127691087
Test: manual
Change-Id: I7af28be2df5f84ffcd040a80884efe7c08e2d067
2019-03-08 14:33:30 -08:00
TreeHugger Robot
a51b5f8756 Merge "Use RoleControllerService for role related APIs." 2019-03-08 21:51:25 +00:00
TreeHugger Robot
3bcfd763ef Merge "Disable Moblie Data Slice in AP mode" 2019-03-08 19:24:43 +00:00
TreeHugger Robot
28ad28d4be Merge "Revert "Revert "Change battery tip text""" 2019-03-08 19:15:24 +00:00
TreeHugger Robot
173a86275a Merge "Add Wifi Panel" 2019-03-08 19:13:08 +00:00
Salvador Martinez
790d4a3bd7 Merge "Create preference to allow user to toggle sticky battery saver" 2019-03-08 17:17:25 +00:00
Raff Tsai
deda67b7bf Revert "Revert "Change battery tip text""
This reverts commit 39beb2533f.

Reason for revert: <start to implement>

Fixes: 121042353
Test: adb shell settings put global battery_tip_constants test_low_battery_tip=true
      Then go to Settings -> battery to see the text

Change-Id: I83cc187d5bfda5312410e91ee636373f305ef449
2019-03-09 00:14:29 +08:00
TreeHugger Robot
e6e073f6aa Merge "Do not allow draw on top for App notification settings" 2019-03-08 13:52:18 +00:00
Raff Tsai
476b9050e8 Merge "Revert "Change battery tip text"" 2019-03-08 08:54:34 +00:00
Raff Tsai
39beb2533f Revert "Change battery tip text"
This reverts commit 2441b94c6d.

Reason for revert: <wrong commit>

Change-Id: I373fc065eafc81c26a8eba133255f9377d1d5d7f
2019-03-08 08:51:05 +00:00
TreeHugger Robot
760e6b66d8 Merge "Change battery tip text" 2019-03-08 08:50:02 +00:00
Raff Tsai
fe86a2a51f Do not allow draw on top for App notification settings
Fixes: 119115683
Test: manual
Change-Id: Ib7b878a23b4a99171c58b5de992fb87feca8a28a
2019-03-08 16:19:30 +08:00
Yanting Yang
cd5298934b Merge "Fix BluetoothDevicesSlice doesn't appear issue." 2019-03-08 06:50:08 +00:00
TreeHugger Robot
9b628203e7 Merge "Adjust timeout limit of contextual card loading" 2019-03-08 06:26:30 +00:00
Hai Zhang
729f1bb48b Use RoleControllerService for role related APIs.
Move isApplicationQualifiedForRole() and isRoleVisible() from
PermissionControllerService to RoleControllerService.

Bug: 127691087
Test: manual
Change-Id: I87edb1bc457fbbec3d9a87054eaad5024ed91310
2019-03-07 21:33:56 -08:00
Mehdi Alizadeh
f514f1eecf Merge "Adds Edge to Edge option in gesture settings page" 2019-03-08 04:49:41 +00:00
Mill Chen
3c50f4467a Adjust timeout limit of contextual card loading
Add a way to get the timeout limit of contextual card loading from
Settings.Global. If Settings.Global doesn't have the timeout limit, will
use the default timeout limit.

Bug: 124460999
Test: robotests
Change-Id: I2a25570f51013b566914e485d61405f14290d338
2019-03-08 11:49:20 +08:00
Arc Wang
b249fb7d13 Support to share Wi-Fi hotspot via QR code
1. QR code scanner (Wi-Fi Easy Connect) does not support sharing Wi-Fi hotspot
   at current stage
2. Wi-Fi hotspot QR code button only shows when Wi-Fi hotspot is enabled
3. The QR code has the security string "WPA" for hotspot's WPA2_PSK

Bug: 123151660
Test: atest WifiTetherSSIDPreferenceControllerTest
            WifiQrCodeTest WifiDppConfiguratorActivityTest
            WifiDppEnrolleeActivityTest
            WifiDppQrCodeGeneratorFragmentTest
            WifiDppQrCodeScannerFragmentTest
            WifiNetworkListFragmentTest
            WifiDppChooseSavedWifiNetworkFragmentTest

Change-Id: I2e89450180b82cc841ee3b15be52bfc6f9f6164d
2019-03-08 11:48:12 +08:00
Clown SHEN
457f9a6ee8 Merge "[Passpointv2] Provide two views for saved networks" 2019-03-08 02:42:30 +00:00
TreeHugger Robot
470caabd50 Merge "Added new toggle for Content Capture on Settings -> Privacy" 2019-03-08 01:14:36 +00:00
Raff Tsai
39832ae341 Merge "Remove "Add users from lock screen" from secondary users" 2019-03-08 01:05:31 +00:00
Felipe Leme
0d3444a300 Added new toggle for Content Capture on Settings -> Privacy
Test: manual verification
Test: atest EnableContentCapturePreferenceControllerTest

Bug: 119264902

Change-Id: I2e29d7892892e6a0f90a97e35c48df231d67b0b6
2019-03-07 15:00:00 -08:00
Mehdi Alizadeh
43502549a3 Adds Edge to Edge option in gesture settings page
Bug: 125489141
Test: Manual test on device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationLegacyPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationSwipeUpPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationEdgeToEdgePreferenceControllerTest
Change-Id: I1b274cc053de8235d0c664150cabe5dadc618419
2019-03-07 14:50:27 -08:00
Fan Zhang
cec74ac982 Merge "Fix Hotspot condition string truncated" 2019-03-07 21:53:05 +00:00
Salvador Martinez
6db5eb6cd0 Create preference to allow user to toggle sticky battery saver
This adds the toggle that makes it so that battery saver turns
off automatically at high battery percentages or not.

Test: robotests
Bug: 112232746
Change-Id: I0df879a43e5390bc671c47e780bbbb466a3e9353
2019-03-07 11:18:40 -08:00
Ruchi Kandoi
ef37175102 Merge "Update Secure NFC API definitions" 2019-03-07 18:44:46 +00:00
Raff Tsai
fbdd87281a Merge "Fix Robo test fail at NotificationAssistantPickerTest" 2019-03-07 14:30:54 +00:00
Edgar Wang
5cbdce4b3f Fix Robo test fail at NotificationAssistantPickerTest
Fixes: 127764177
Test: make RunSettingsRoboTests ROBOTEST_FILTER=NotificationAssistantPickerTest
Change-Id: I923a8c948c432fbb0b581a84f058a6d6bd0f7946
2019-03-07 18:59:55 +08:00
Yanting Yang
cbbc008a97 Fix BluetoothDevicesSlice doesn't appear issue.
In Settings cold launch, it took a little bit time to do Bluetooth
profile service connection. If we get the Bluetooth device connected
state before service connected, the return value will always false.
This behavior caused BluetoothDevicesSlice can't collect media devices
immediately in cold launch, therefore, no data to build this card.

According latest discussion, this card is used for all Bluetooth
devices, so we don't need to wait profile to get specific devices.
Hence, update design to show all connected Bluetooth devices and
keep the operations are the same with Settings > Connected devices.

Fixes: 124462139
Test: visual, robotests
Change-Id: I1418e09f2cdc7ea8beaa73d7a59440ee2baae63b
2019-03-07 18:41:16 +08:00
Edgar Wang
af13b393e2 Fix Robo test fail at VolumePanelTest
Fixes: 127765311
Test: make RunSettingsRoboTests ROBOTEST_FILTER=VolumePanelTest
Change-Id: I9608c0aed2b7282b3626107c5f6d2e98d1c3caab
2019-03-07 17:51:24 +08:00
clownshen
0a7e2c0383 [Passpointv2] Provide two views for saved networks
List all passpoint network under "Subscriptions" view and others under
"Wi-Fi networks".

Bug: 116362877
Test: hard code verify subscribed network
Change-Id: I9750e9964e8b5affc2e91ea86a058c3ba65b3588
2019-03-07 07:59:58 +00:00
Yanting Yang
24ff4a2110 Fix Hotspot condition string truncated
Update hotspot condition title and summary and remove unused string.

Fixes: 125914006
Test: visual, robotests
Change-Id: I2a41c0d1840c9a21f86bd62495b404b02d8a865e
2019-03-07 13:57:49 +08:00
Raff Tsai
b508184d60 Remove "Add users from lock screen" from secondary users
Fixes: 124885010
Test: Robolectric, manual
Change-Id: I1c940fda2fa5f3da39c19bd119ac483024f5a83b
2019-03-07 13:20:02 +08:00
Lei Yu
6ebd2ed731 Merge changes from topic "add_cast_volume"
* changes:
  Add SliceWorker for remote volume controller
  Add remote volume slider to sound settings
2019-03-06 23:59:44 +00:00
Brad Ebinger
505e32cf64 Merge "WFC roaming mode setting can not be used with a fixed value" 2019-03-06 23:36:34 +00:00
Raff Tsai
2441b94c6d Change battery tip text
Fixes: 121042353
Test: adb shell settings put global battery_tip_constants test_low_battery_tip=true
      Then go to Settings -> battery to see the text
Change-Id: Ie3c4a89ccb7c2724840dc886a502ef919e13a856
2019-03-07 04:50:43 +08:00
jackqdyulei
dd00274967 Add SliceWorker for remote volume controller
Also update some methods to fix issues in panel.

Bug: 126199571
Test: RunSettingsRoboTests
Change-Id: I9b93ae594d41cb71b984b06267161455373bf121
2019-03-06 11:31:40 -08:00
Kitta Koutarou
994d27a2a5 WFC roaming mode setting can not be used with a fixed value
WFC roaming mode setting can not be used with a fixed value because it
is changed as WFC home mode changes if
KEY_EDITABLE_WFC_ROAMING_MODE_BOOL is false.

To solve this issue, separate the WFC mode setting of home and roaming.
These can switch behavior by new carrier config
KEY_USE_WFC_HOME_NETWORK_MODE_IN_ROAMING_NETWORK_BOOL.

Test: manual - Checked that WFC roaming mode is hidden if new config is
true.
Test: manual - Checked that WFC roaming mode is also changed when
change the WFC home mode if new config is true.
Test: auto - Passed WifiCallingSettingsForSubTest.
Bug: 79666081

Change-Id: Ib2363c5d50f5231cc89f287d760ca8728b02b249
2019-03-06 09:49:25 -08:00
Ruchi Kandoi
d5ba12a94d Update Secure NFC API definitions
Bug: 124767797
Test: None
Change-Id: I90f109f08771f429966cd108eaacdf8b81d0a72e
2019-03-06 08:29:38 -08:00
Yanting Yang
be15baa155 Merge "Remove dismissal behavior from deferred setup card" 2019-03-06 08:45:32 +00:00
Matthew Fritze
6b065caf7e Disable Moblie Data Slice in AP mode
When airplane mode is enabled, users should not be able to
change the value of mobile data. Thus, when airplane mode is enabled,
replace the Slice with a no-op slice explaining why it cannot be
changed.

Fixes:
Fixes: 126726036
Test: robotests
Change-Id: I1c6d95dbb9d0c51247709b9867506c800f5872cd
2019-03-05 14:46:32 -08:00
Fan Zhang
68c7aad725 Merge "Wake up/unlock device before running tests" 2019-03-05 21:32:44 +00:00
Fan Zhang
eb493d5d69 Wake up/unlock device before running tests
Fixes: 127452134
Test: atest
Change-Id: I627f848a080b4569b658678094d45576eab9247c
2019-03-05 13:27:47 -08:00
TreeHugger Robot
3355bc06d0 Merge "Prevent extra reloads in mobile networking page/controllers" 2019-03-05 19:18:27 +00:00
Matthew Fritze
63cce45efe Add Wifi Panel
WIFI panel currently only shows the Wifi Slice. It's possible
more slices would be added in the future.

Testing is done here and in CTS.

Test: manual app
Test: robotests
Test: atest SettingsPanelTest
Fixes: 126894142
Change-Id: If691467e7c4bb9edd1b8a1b710c65e93284dc568
2019-03-05 10:55:42 -08:00
Lei Yu
05461f7096 Merge "Add null check for forbiddenPlmns" 2019-03-05 18:05:34 +00:00
Yanting Yang
52367e8c65 Remove dismissal behavior from deferred setup card
Deferred setup is not skippable as user will need to review all SUW
screens at least one time.

Fixes: 126225957
Test: visual, robotests
Change-Id: I7b32c2382f459690d3b136cf9faa543d04aa8d3d
2019-03-05 17:08:51 +08:00
Antony Sargent
ce9a126add Prevent extra reloads in mobile networking page/controllers
On the mobile network details page, as well as in several preference
controllers used in various page, we had listeners for the
ACTION_RADIO_TECHNOLOGY_CHANGED broadcast that when fired would cause a
reload. It turns out that this gets broadcast as a sticky intent, so our
callbaks would fire just after registering to listen, resulting in lots
of unnecessary extra reloading. This was particularly noticable on the
mobile network details page because the entire page gets reloaded.

The fix is to make our listeners ignore the broadcast if it's the
initial sticky one.

Bug: 126419558
Test: make RunSettingsRoboTests
Change-Id: I6ab7b43d74b07a839e45ce5368e45809be658b9d
2019-03-04 16:37:33 -08:00