Commit Graph

3188 Commits

Author SHA1 Message Date
Yanting Yang
a0982b39bc Fix talkback issue which focus on entire grid
When there is only one condition card, sometimes talkback will focus on
entire grid. In fact, the entire grid is a recycler view which is the
container to put all contextual cards. Mark the recycler view with no
important for accessibility to fix it.

Fixes: 128896302
Test: visual
Change-Id: I177fa014ec3208001b3a490dbdf9b6b6195985ea
2019-04-01 18:38:42 +08:00
Fan Zhang
d7c071bd11 Merge "Fix talkback issue on collapsed condition card" 2019-03-29 17:04:22 +00:00
Yanting Yang
352ca99541 Fix talkback issue on collapsed condition card
When condition card is collapsed, there are only showing icons.
Accessibility can't speak meaningful information after tap it. Use
existed condition expend string to assign content description.

Fixes:128897141
Test: manual
Change-Id: I49bc1ee8af424e90aac6555829c545914355862b
2019-03-29 19:42:37 +08:00
Arc Wang
3f2298c4fd Merge "Fix Wi-Fi Easy Connect QR code scanner problems" 2019-03-29 01:57:35 +00:00
Maurice Lam
db24af6325 Merge "Fix fingerprint icon on pattern screen" 2019-03-27 18:00:27 +00:00
Maurice Lam
9c2fae83a3 Fix fingerprint icon on pattern screen
Test: atest [...]/ChooseLockPatternTest.java
Bug: 129342100
Change-Id: I4e670b6265fe4a77ecbd8ede9a703fa0762f7504
2019-03-26 18:50:21 -07:00
Arc Wang
8ae9717226 Fix Wi-Fi Easy Connect QR code scanner problems
1. When camera area overlaps display cutout, it's onLayout size is 0/0.
   To fix it, use ConstraintLayout to specify width and height in layout file.

2. When scanned a QR code and there is an error, set camera area frame line
   back to unfocused color.

Bug: 124399763
Test: manual test
Change-Id: I7575efd0ccfb58d114acc3dcca6978d68b801f91
2019-03-26 16:07:02 +08:00
pastychang
fefc66853b Set attribute sucUsePartnerResource
Add the attribute for all pages apply gliflayout of setupdesign library.
In addition, set the value false to remove stencil theme customization for outside setupwizard flow.

Test: atest
Bug: 128961334
Bug: 128364683
Change-Id: If55e9bf97970a5cd08d8d426747c483d80565559
2019-03-26 09:00:49 +08:00
Andrew Sapperstein
63ab34827f Merge "Update eSIM deletion strings." 2019-03-23 02:51:06 +00:00
Andrew Sapperstein
88930e373e Update eSIM deletion strings.
Adds some conditional behavior for the confirmation screens.
When the erase eSIM option is visible and checked, shows alternate string.

Fixes: 126262481
Fixes: 118751918
Test: visual inspection & make -j RunSettingsRoboTests
Change-Id: I40f983b03ad470d785bf104e645dbc92e7897d2d
2019-03-22 13:03:25 -07:00
TreeHugger Robot
c74577eacf Merge "Revert "Add divider line in Preference for scan QR code button and share hotspot button"" 2019-03-22 08:18:16 +00:00
Arc Wang
8040f4c59f Revert "Add divider line in Preference for scan QR code button and share hotspot button"
This reverts commit 890f3a4340.

Reason for revert: I find a UI defect in this fix.

Change-Id: Icdbb1d2b5319636b8c4c54bcdc0fc3562585a15a
2019-03-22 05:36:59 +00:00
TreeHugger Robot
9caf09e1bf Merge "Clean up manage_applications_apps.xml" 2019-03-22 03:09:14 +00:00
Arc Wang
d2405c7328 Merge "Improve Wi-Fi Easy Connect lock screen UI information" 2019-03-22 02:19:48 +00:00
TreeHugger Robot
8a26152a50 Merge "Make conditional work properly when toggle it in QS" 2019-03-22 00:16:45 +00:00
Mill Chen
bd10886288 Make conditional work properly when toggle it in QS
Some conditionals do not work properly when users toggle its state in
QS, the cause is that these conditionals don't have a way to monitor the
status changed. Make RecyclerView handle onWindowFocusChanged event and
make sure that conditionals can update the status when going back to
Settings from QS.

Bug: 118387886
Bug: 123171638
Bug: 123167705
Test: visual, robotests
Change-Id: Ib3bb9bf43afaa58726502eea1e98bcf602bc3677
2019-03-21 13:28:25 -07:00
TreeHugger Robot
fc38c5c04e Merge "Revert layout transition from slice view" 2019-03-21 12:00:28 +00:00
tmfang
4b8eccb519 Clean up manage_applications_apps.xml
Since LinearLayout have only one view(FrameLayout),
LinearLayout is redundant.

It can improve a bit render time.

Test: Open App info screen
Fixes: 124702325
Change-Id: I368b20c5f9916b876586dab71eac43512664d15b
2019-03-21 19:29:49 +08:00
Yanting Yang
1cdb780526 Revert layout transition from slice view
Fixes:129002765
Test: visual
Change-Id: Ice56eb0ee5cd6018927271ab33ad9dd3321953b1
2019-03-21 16:59:47 +08:00
TreeHugger Robot
b9e6f894c3 Merge "Add divider line in Preference for scan QR code button and share hotspot button" 2019-03-21 06:26:27 +00:00
Arc Wang
abfd8ab726 Improve Wi-Fi Easy Connect lock screen UI information
1. Change lock screen title and remove description
2. In QR code generator screen, change summary and show password under QR code picture

Bug: 128920152
Bug: 128576809
Test: manual test
Change-Id: Id096d7f417308df14ffe50c618644750aa991df8
2019-03-21 14:09:22 +08:00
TreeHugger Robot
ff02854e9a Merge "Remove hardcoded height for SliceView" 2019-03-21 04:02:48 +00:00
Arc Wang
890f3a4340 Add divider line in Preference for scan QR code button and share hotspot button
Bug: 128940862
Test: manual test
Change-Id: If576f0840cc8924b63348f04fe12c3a0d4edcb89
2019-03-21 10:48:55 +08:00
jackqdyulei
02f64c0634 Remove hardcoded height for SliceView
Fixes: 128953120
Test: Build
Change-Id: I052d2b539421132002a3217fe2ef82d0ab6aba19
2019-03-20 17:10:26 -07:00
TreeHugger Robot
1029b976f4 Merge "Update enrollment intro" 2019-03-20 06:28:33 +00:00
Cosmo Hsieh
64df6a3073 Merge "[Network Connection] Implement new UI changing" 2019-03-20 04:34:25 +00:00
TreeHugger Robot
85c5d73145 Merge "Improve UX of WifiDppChooseSavedWifiNetworkFragment" 2019-03-20 04:07:02 +00:00
Kevin Chyn
f25830b9cc Update enrollment intro
1) Toggles resources between normal and accessibility enrollment
2) Add footer for more detail text

Fixes: 127514618
Bug: 111548033

Test: Builds

Change-Id: Ib0c47f04abc5ce9abbd8b27ef5782d1874379f16
2019-03-19 19:19:23 -07:00
Arc Wang
d0ceb83c95 Improve UX of WifiDppChooseSavedWifiNetworkFragment
In WifiDppChooseSavedWifiNetworkFragment, it does not show the saved Wi-Fi
network which is not reachable, users may be confused about why their saved
Wi-Fi network not on the list. This change shows saved networks regardless
of signal reachable or not.

Fix WifiDppChooseSavedWifiNetworkFragment UI overlap problem, remove redundant
ScrollView and adjust ConstraintLayout parameters.

Bug: 124129645
Test: manual test
Change-Id: I86637e8722bb8f40a3b995a617dc1e22b2ae324a
2019-03-20 10:06:40 +08:00
Arc Wang
e4359a9eee Merge "Fix Wi-Fi Easy Connect buttons UI defects" 2019-03-20 01:53:24 +00:00
Lei Yu
e87fe284b6 Merge "Add circle background outline to unthethered icon" 2019-03-19 17:46:17 +00:00
Fan Zhang
83f85b0a1f Merge "Stop using framework internal layout for timezone header." 2019-03-19 17:18:42 +00:00
Fan Zhang
5d2e0fc10f Stop using framework internal layout for timezone header.
The framework version header has deviated from supportlib version long
ago, and we shouldn't hack our theme to make this layout work. Instead
we now have a custom layout compatible to settings theme.

Fixes: 128833223
Test: visual
Change-Id: I83087352240de183b0639daf844bd7f90e02056a
2019-03-19 10:17:46 -07:00
Arc Wang
baf002d61a Fix Wi-Fi Easy Connect buttons UI defects
1. Apply attr/colorAccent to button icons for theme UI control
2. Apply attr/selectableItemBackground for button tapping ripple effect
3. Use ConstraintLayout to separate ssid EditText and scan button
4. Remove ButtonPreference and add AddNetworkPreference.
   ButtonPreference's naming and design look like a general purpose UI
   component but it's not. This change refactors the code.
5. In AddNetworkPreference, use settingslib layout file
   'preference_access_point' to fix UI alignment problems.

Bug: 126964552
Bug: 125434239
Bug: 126762937

Test: manual test
      atest com.android.settings.wifi.WifiSettingsTest
Change-Id: Ib899a1e10f96bb8427ff00d6b5dfca37a0642c44
2019-03-19 16:27:04 +08:00
cosmohsieh
b795dcbcd1 [Network Connection] Implement new UI changing
1. Change title to multi-lines display
2. Add "SingleSpecifiedSSID" mode, will have connect button
3. Don't pop error dialog, if there is connection failure. Let user
retry.
4. Hide progress icon if list item exists

Bug: 128586511
Test: atest NetworkRequestDialogFragmentTest
Change-Id: Icc560e4882fbcd941574e44690a27d5082a7c4c7
2019-03-19 10:15:33 +08:00
TreeHugger Robot
d55718eeca Merge "Fix voice access issue on home page" 2019-03-18 19:59:27 +00:00
Hunter Knepshield
711b78d5ed Merge "[Strings + layout] Minor changes for eSIM erase." 2019-03-18 18:17:20 +00:00
Yanting Yang
0f3049d4b7 Fix voice access issue on home page
Bug: 128825246
Test: manual
Change-Id: Icd9b31c195f44b11b97a30292de586483ea2e651
2019-03-18 22:12:49 +08:00
Sunny Shao
3ef480e895 Update the expand more icon in the condition
- Rollback the color from accent to gray.
- Use the "ic_expand_more_inverse.xml" to replace the "expand more" icon.

Fixes: 126926489
Test: manual
Change-Id: I438a03f42987001de7dce5040dd01347c2c6a9b0
2019-03-18 06:08:16 +00:00
Hall Liu
c776acee06 Merge "Base implementation of WFC disclaimer UI" 2019-03-15 22:57:06 +00:00
jackqdyulei
8308274058 Add circle background outline to unthethered icon
Fixes: 124247230
Test: manual
Change-Id: I70f8158685134e2115f2a7baded983ebac6c8f1b
2019-03-15 12:40:58 -07:00
Julia Reynolds
4253be9191 Update design of channel pages.
Test: atest
Bug: 127796543
Change-Id: I4fabeafe2602c341554959303e67bc69c8817a8f
2019-03-15 10:21:24 -04:00
Hunter Knepshield
e8e86e631a [Strings + layout] Minor changes for eSIM erase.
1. String changes (uniform on both screens now)
2. Minor non-functional layout changes (margin is uniform now)

Reset everything: https://screenshot.googleplex.com/OZsvOt36CZf
Reset networks: https://screenshot.googleplex.com/in0vdOAeF7u

Change-Id: I92d068c3731f6915c8d393d94ac8c25a3c8ed773
Fix: 119120504
Test: on device
2019-03-14 15:14:35 -07:00
manabu, shimoda
9fae73915c Base implementation of WFC disclaimer UI
Test: manual - Check that no error occurred when changing the wifi
calling settings to turn on.
Test: auto - Passed WifiCallingSettingsForSubTest,
WifiCallingDisclaimerFragmentTest and DisclaimerItemListAdapterTest.
Bug: 67872298

Change-Id: I789f530d3e16baa6e56feaa4269f6696976f747e
2019-03-14 14:58:20 -07:00
TreeHugger Robot
d392beed55 Merge "Align layouts between single and two target preferences." 2019-03-13 19:45:25 +00:00
TreeHugger Robot
4bb33ae9f2 Merge "Update the color of the expand icon as accent color" 2019-03-12 01:05:10 +00:00
TreeHugger Robot
08a2a8183e Merge changes I54a3f033,I2e894501
* changes:
  Fix [a11y] Wi-Fi Easy Connect Talkback issues
  Support to share Wi-Fi hotspot via QR code
2019-03-12 00:42:40 +00:00
Chris.CC Lee
411ca28940 Align layouts between single and two target preferences.
Change the layout to align view components with TwoTargetPreference.

Fixes: 124084391

Test: Visual
Change-Id: I417a8e442bd80c51be04e3f33514a6605c9b45f8
2019-03-12 06:23:56 +08:00
Chalard Jean
230a9949b4 Merge "Support VPN Proxy(2/2)" am: 2a695c4b7b am: e2f74af063
am: aa5d185d7b

Change-Id: Ifa4ac76f78e24296a29f99f5733075651bed9072
2019-03-09 04:20:32 -08:00
Yanting Yang
d6609a872b Merge "Animate the expansion/collapse of a slice" 2019-03-08 09:08:02 +00:00