Commit Graph

4709 Commits

Author SHA1 Message Date
Fan Zhang
155d6829e9 Move restriction check for dev settings into controller
Change-Id: I99dae6e82aca40b92e1965ba7db2c54f3c59d33f
Fixes: 72815875
Test: robotests
2018-02-07 22:33:10 -08:00
TreeHugger Robot
c9f1d89dd3 Merge "Remove dead code for DataPlanUsageSummary" 2018-02-08 06:21:11 +00:00
TreeHugger Robot
a0ee8ad070 Merge "Remove some dead code from search" 2018-02-08 06:13:36 +00:00
TreeHugger Robot
682bb3e8e5 Merge "Add feature flag for new DataUsageSummary fragment." 2018-02-08 04:55:56 +00:00
Fan Zhang
3ed55b1450 Remove dead code for DataPlanUsageSummary
This is an unfinished feature, no longer needed.

Change-Id: I358dcc8865184117d49e35b3e8dfcd84403261d0
Fixes: 73073608
Test: rebuild
2018-02-07 20:35:56 -08:00
Matthew Fritze
700c113218 Add Toggle Controllers to XML
Autobrightness preference controller was accidentally removed from
display_settings.xml. Given that no tests were broken and this would
be a disaster for phone buddy & inline actions, I have added another
test which keeps a list of valid controllers that should exist in xml.

When more inline controllers types are added, they will be included
in this test.

Fixes: 72564979
Test: robotests
Change-Id: I40fe18f9118af9cec1c201632742d2949ff64be5
2018-02-07 17:09:05 -08:00
Fan Zhang
d75baf7e85 Remove some dead code from search
Test: rebuild
Change-Id: If736f58c546fa9eafc405525c11640ca2576d446
2018-02-07 16:56:28 -08:00
TreeHugger Robot
96fc83d821 Merge "Delete WPS settings." 2018-02-08 00:16:35 +00:00
Julia Reynolds
cd7e9bcb33 Apply checkbox enable state on viewholder bind
Change-Id: I5b263f02fb6a1779fd567eade3776044fddb6b11
Fixes: 72809700
Test: SettingsRoboTests
2018-02-07 23:58:44 +00:00
TreeHugger Robot
1ea9eeb9c6 Merge "Notification lock screen setting updates" 2018-02-07 22:38:32 +00:00
Eric Schwarzenbach
98998a2fcc Add feature flag for new DataUsageSummary fragment.
Creates a new fragment DataUsageSummaryLegacy, which is used
instead of DataUsageSummary when the feature flag is off (default
behavior).

Copies the current DataUsageSummary.java, data_usage.xml, and
DataUsageSummaryActivity to create the legacy versions. This
change allows for uninterupted development of new features in the
DataUsageSummary fragment.

Test: manual
Test: make RunSettingsRoboTests
Bug: 70950124
Change-Id: I9d79e108bbfc1c8ec620f86c0183f4ed3f41c9d7
2018-02-07 14:29:41 -08:00
tiansiming [田思明]
3d38ab00cb Merge "Fix NPE in AutoSyncWorkDataPreferenceController" am: cdd628e6e4 am: 0bc6b461be
am: eb0ebc6b98

Change-Id: I12a16dd3ef5cfcda92efd166d3f2fccdd20527d1
2018-02-07 22:19:31 +00:00
tiansiming [田思明]
eb0ebc6b98 Merge "Fix NPE in AutoSyncWorkDataPreferenceController" am: cdd628e6e4
am: 0bc6b461be

Change-Id: I78899aef7b43c067f7c4094d7de63b95c4ee3f11
2018-02-07 22:16:46 +00:00
TreeHugger Robot
87ed226f37 Merge "Update copy for battery estimate related features" 2018-02-07 22:15:29 +00:00
tiansiming [田思明]
0bc6b461be Merge "Fix NPE in AutoSyncWorkDataPreferenceController"
am: cdd628e6e4

Change-Id: Ic10709693acbf3f04704ed76a7474291af509cf5
2018-02-07 22:13:14 +00:00
TreeHugger Robot
a33144b841 Merge "Pre-fixup for nav up button" 2018-02-07 22:05:39 +00:00
Andrew Sapperstein
26e35dac79 Delete WPS settings.
Removes the WPS PIN and Push button settings, all of
the strings, and related code.

Change-Id: I1c7a35ffc8491c57e07accba9b1b5f5407b01831
Fixes: 72421239
Test: deletes code, robotests
2018-02-07 13:57:57 -08:00
Salvador Martinez
408dc41228 Update copy for battery estimate related features
Many features are using the enhanced estimates but the copy for them
has gotten out of sync. This CL moves shared strings between Settings
and SysUI to SettingsLib and also updates features that use the
strings to have consistent behavior/text.

Test: Robotests
Bug: 65656091
Bug: 66909350
Bug: 67469159
Change-Id: Ie5ef1ed65429ca9805cff374f1439e5d61eb6591
2018-02-07 10:55:15 -08:00
Fan Zhang
f11c885766 Pre-fixup for nav up button
- Remove SettingsDrawerActivity.EXTRA_SHOW_MENU and force up nav button
  to always show. The button doesn't do anything yet. It just finishes
  current activity.
- Remove dead code about suggestions

Change-Id: I61fa9fefbaa9bced841a05969544b1c824c564ce
Bug: 72337421
Test: rebuild
2018-02-07 10:27:18 -08:00
Julia Reynolds
826e6c4b9a Notification lock screen setting updates
- String update
- Don't show 'hide notifications' option at app/channel level
if 'don't show' is selected globally

Test: SettingsRoboTests
Change-Id: I180b91019183865aa0f4f6adce917ebe7211dbb5
Fixes: 72833828
Fixes: 72651566
2018-02-07 16:34:49 +00:00
TreeHugger Robot
d895f9374c Merge "Remove the second target for ConnectedApPreference" 2018-02-07 05:06:23 +00:00
Lei Yu
f8caf69d46 Merge changes from topic "battery_saver_step_1"
* changes:
  Add preference controller for battery seekbar
  Revamp the battery saver page
2018-02-07 02:07:54 +00:00
TreeHugger Robot
948191bcd3 Merge "Fix trust agent summary not being updated." 2018-02-07 01:44:24 +00:00
tiansiming [田思明]
6cdb07862a Fix NPE in AutoSyncWorkDataPreferenceController
AutoSyncWorkDataPreferenceController gets mUserHandle from
Utils.getManagedProfileWithDisabled which may return null,
crash will happend when updateState called.
So a judgement here seems helpful to make the program more robust.

Bug: https://partnerissuetracker.corp.google.com/u/1/issues/72908879
Test: make ROBOTEST_FILTER="(AutoSyncWorkDataPreferenceControllerTest)"
RunSettingsRoboTests

Change-Id: I53ca027a2f2dd79655cc2eee67db236cfa03f656
Signed-off-by: tiansiming [田思明] <tiansiming@xiaomi.com>
2018-02-07 08:58:58 +08:00
Ben Lin
15312d3505 Merge "Update comment about robotests' dummy ColorDisplayController." 2018-02-06 22:32:18 +00:00
TreeHugger Robot
f504294b12 Merge "Update suggestion card width." 2018-02-06 22:14:29 +00:00
Doris Ling
579fd5eb5e Fix trust agent summary not being updated.
- move the handling for enabling the trust agent preference and its
summary from displayPreference() into updateState(), so that when user
navigates to change screen lock or update trust agent and returns to the
security settings page, the trust agent preference enabled state and
summary will be refreshed correctly.

Change-Id: I60bccfdff755a046a9f5453d39a7ac9d3ce0277c
Fixes: 72420147
Test: make RunSettingsRoboTests
2018-02-06 14:08:47 -08:00
TreeHugger Robot
def55bf102 Merge "Check device for config_enableWallpaperService before calling service." 2018-02-06 20:27:20 +00:00
Ben Lin
fb17c32b09 Update comment about robotests' dummy ColorDisplayController.
Bug: None
Test: None
Change-Id: Iadc38a3430b9002ee106782eeced350921581a29
2018-02-06 12:26:32 -08:00
Doris Ling
c627161ca6 Update suggestion card width.
- instead of using hard-coded width for 1 or 2 cards, they should take
up the whole screen width minus the defined padding, so that when the
device is in landscape mode, they look better.

Change-Id: Ic6485c858c7742a154a6d9b05fff180f161be323
Fixes: 72850225
Test: make RunSettingsRoboTests
2018-02-06 12:18:34 -08:00
TreeHugger Robot
d2a2e30889 Merge "Add new touch and notification vibration intensity settings." 2018-02-06 20:13:16 +00:00
Michael Wright
29d526719a Add new touch and notification vibration intensity settings.
Bug: 64185329
Test: ROBOTEST_FILTER=VibrationSettingsTest m -j RunSettingsRoboTests
Change-Id: I449c7e0041aabfe48935a57cde93e8af77dcd783
2018-02-06 18:14:07 +00:00
TreeHugger Robot
5135ed23c2 Merge "DND ixD changes" 2018-02-06 17:09:33 +00:00
TreeHugger Robot
085dcc3783 Merge "Notification settings updates" 2018-02-06 16:25:26 +00:00
Beverly
036d7e0bd9 DND ixD changes
- Subtext in Settings > Sound updated
- new icons for automatic dnd rules
- no toast when toggling on/off dnd rules
- dnd dialog has a warning if dnd will cause user to miss next alarm

Test: make ROBOTEST_FILTER=ZenModePreferenceControllerTest RunSettingsRoboTests -j40
Fixes: 72494029
Fixes: 72655216
Fixes: 72655609
Change-Id: I9d86d82529079f35e362f93e10914f0a60229cd8
2018-02-06 14:15:40 +00:00
Julia Reynolds
18f14f10cf Notification settings updates
- Hide channels when a group is blocked
- Update importance strings
- Allow app blocking from 'recently seen'

Test: RoboSettingsTests
Fixes: 72879584
Fixes: 72882969
Fixes: 72831483
Change-Id: I99e001d3eb9eef52251cd50da191d33923335fcf
2018-02-06 09:15:20 -05:00
TreeHugger Robot
99fc2a7ea4 Merge changes Ib0328f03,Ic10efc63
* changes:
  Add restrict and unrestrict dialog
  Add app restrict tip and detector
2018-02-06 05:20:26 +00:00
jackqdyulei
99a2de41ef Add restrict and unrestrict dialog
Add a fake unrestrict tip so we could reuse the BatteryTipDialogFragment
to build the unrestrict dialog.

After this cl, restrict dialog has two types:
1. dialog to only restrict one app
2. dialog to restrict more than one app

Will add dialog to restrict more than 5 apps when strings are finalized.

Bug: 72385333
Bug: 72227981
Test: RunSettingsRoboTests
Change-Id: Ib0328f0386efad525b331fd713dd15d060a1a649
2018-02-05 19:37:03 -08:00
jackqdyulei
ab0cde6bad Add app restrict tip and detector
1. Add RestrictAppTip with two state(new and handled)
2. Add RestrictAppDetector, and future cl will hook up
it with anomaly database
3. Add related dialog in BatteryTipDialogFragment

Bug: 72385333
Test: RunSettingsRoboTests
Change-Id: Ic10efc6387150e62b6c6ad8d4c0d16ff75564fac
2018-02-05 19:34:48 -08:00
jackqdyulei
b77fec0872 Add preference controller for battery seekbar
Also update SeekBarPreference so we can set min for it.

Bug: 72228477
Test: RunSettingsRoboTests
Change-Id: I5ab1bfd78b0bd461551012c121c7e76764843a30
2018-02-05 19:32:24 -08:00
Maggie Wang
5d8d0bc9e4 Merge "Add a footer to Location Settings page" 2018-02-06 02:35:24 +00:00
TreeHugger Robot
39fe530829 Merge "Set categories to the adapter if suggestion is not available." 2018-02-06 02:08:27 +00:00
Maggie
ca80da20b1 Add a footer to Location Settings page
At the bottom of Settings -> Security & Location -> Location, inject
footers with text provided by system apps. GmsCore uses this footer to
present legal consent info for Google Location Services.

Bug: 70350519
Test: Robo
Test: Manual
Change-Id: I201afdb30baa7b81b591d161fce5be55569b6320
2018-02-05 16:30:11 -08:00
Ben Lin
845e213514 Set categories to the adapter if suggestion is not available.
If there's no suggestion, we should set the category to the adapter
before returning.

Bug: none
Test: robotests
Change-Id: I73bb248d17edb3c398a9fb0a8f3913e7233fcc0b
2018-02-05 16:20:56 -08:00
TreeHugger Robot
d6621564f4 Merge "Increase app icon size from 24dp to 32dp." 2018-02-06 00:15:42 +00:00
Lei Yu
74f1db1d43 Merge "Clean up WifiTetherPreferenceController" 2018-02-05 23:31:42 +00:00
Ben Lin
245ac03c07 Check device for config_enableWallpaperService before calling service.
On some devices, it is possible that config_enableWallpaperService is
false, in which then there is no wallpaper service on device. Calling
WallpaperManager#getWallpaperId will then result in an NPE. We should
just do a check and return false.

Bug: 62387789
Test: RoboSettingsTest
Change-Id: I31db6845f06533d92140bf91d0f7fc7e7bedc5c5
2018-02-05 15:17:16 -08:00
Fan Zhang
8fe5d507d5 Increase app icon size from 24dp to 32dp.
The app icon size as 24dp is too small. We'd like to increase to 32dp
based on latest UX feedback and to match Material Spec v2 wrt app icon
sizes.

Test: make RunSettingsRoboTest -j40 ROBOTEST_FILTER=AppPreferenceTest
Test: visual (Launch settings -> App & notification -> verify app icon
      size increased)
Fixes: 71767701

Change-Id: I474df72075602fc48d3123127b4f9bf350374506
2018-02-05 14:37:44 -08:00
jackqdyulei
7e999df6d9 Revamp the battery saver page
1. Make BatterySaverSettings extend from DashboardFragment
2. Add new layout
3. Add battery saver controller

Future cl will add controllers for seekbar and button

Bug: 72228477
Test: RunSettingsRoboTests
Change-Id: I21fb62aef874c04eca2988271f2fd9d7aacb0c6c
2018-02-05 13:32:48 -08:00
TreeHugger Robot
f52ff28511 Merge "Autofill compat - Settings" 2018-02-05 09:55:29 +00:00