Commit Graph

52810 Commits

Author SHA1 Message Date
joshmccloskey
6b30136edf Fixed Infinite loop method call.
Test: Verified that setupwizard flow no longer causes infinite loop.
Fixes: 131106091
Change-Id: I0777fefa08063c62f7ef8cbbc252e219efa98f24
2019-04-25 00:42:31 +00:00
TreeHugger Robot
703e6aa092 Merge "Add bubbles animation" into qt-dev 2019-04-25 00:08:30 +00:00
TreeHugger Robot
30859ac832 Merge "Update "ask every time" asset." into qt-dev 2019-04-24 23:57:30 +00:00
TreeHugger Robot
c78e4d1e0f Merge "Remove disable mobile data confirm dialog for single sim." into qt-dev 2019-04-24 22:50:24 +00:00
Lei Yu
2b60204dba Merge "Fix issue in panel logging" into qt-dev 2019-04-24 22:48:55 +00:00
Fan Zhang
9fa82a370b Merge "Fix incorrect mapping to get subscriptioninfo" into qt-dev 2019-04-24 21:44:53 +00:00
lindatseng
e972b16c4b Make panel support dark mode
Slightly adjust Panel related theme/styles to support dark mode.

Screenshot:
Wifi Panel: https://screenshot.googleplex.com/5FJ1wwMjgrn.png
NFC Panel: https://screenshot.googleplex.com/AhNJhEMXCS7.png
Volume Panel: https://screenshot.googleplex.com/iyOxAz9NJPv.png
Connectivity Panel: https://screenshot.googleplex.com/pvExHZVNW7m.png

Test: Visual/Manual verification
Fixes: 130815366
Change-Id: Ic96898091c52ccebf4437d96099ad553884d1eb4
2019-04-24 21:30:40 +00:00
Fan Zhang
e83d718ff9 Include always ask button in SIM picker dialog
Fixes: 129433330
Test: manual
Change-Id: Ia7e5af56541aaf66df9e1749c1cc6e7f97d55a0b
2019-04-24 14:11:50 -07:00
TreeHugger Robot
62d580d5b4 Merge "Implement off state for SIM details page" into qt-dev 2019-04-24 21:00:38 +00:00
Fan Zhang
56c6f89a22 Remove disable mobile data confirm dialog for single sim.
Fixes: 124005813
Test: robotest
Change-Id: I2da563f26d6dbb1ec3c6c205f21a96c896b51334
2019-04-24 13:50:09 -07:00
Lei Yu
eba850e8d9 Update color filter for battery saver mode
Fixes: 129498556
Test: Manual
Change-Id: I57809c77e488b9828bea50d4c4f410d49912cd4b
2019-04-24 13:47:39 -07:00
Julia Reynolds
b7c8800cdc Add bubbles animation
Test: manual
Fixes: 130653599
Change-Id: I2bd0499de2a9140a51440a57e8ed3bd8c34cccc1
2019-04-24 16:41:56 -04:00
Lei Yu
d68c8c59e5 Fix settings unit test
Also remove some obsolete tests

Fixes: 126257657
Test: atest
Change-Id: Ib9b654b9076176db3c331bf5ca14ac185c9e0b5f
2019-04-24 20:40:59 +00:00
Andrew Sapperstein
181a8fccbd Update "ask every time" asset.
Fixes: 130550869
Test: visually inspected
Change-Id: I75356f1a05411ab9d4c396d283fd555ce7c1cd07
2019-04-24 12:56:17 -07:00
Lei Yu
3aacfca16f Fix issue in panel logging
Update log key to slice uri since previous key has no meaning.

Previously it is something like:
androidx.slice.widget.SliceLiveData$SliceLiveDataImpl@1a30b5

Bug: 131094876
Test: Manual
Change-Id: I52d605eb826821ef622aa075c04f829c60692976
2019-04-24 12:50:46 -07:00
TreeHugger Robot
235387c4f1 Merge "Update dialog background color for dark theme" into qt-dev 2019-04-24 19:44:42 +00:00
Christopher Dombroski
4b78bcd5cd Treat mode_default as denied for install_unknown_apps
Test: atest SettingsRoboTests
Bug: 123700348
Change-Id: Ieeb6456854cc3d0faa0e9c407accd94f56a25813
Merged-In: Ieeb6456854cc3d0faa0e9c407accd94f56a25813
2019-04-24 18:29:53 +00:00
Chandan Nath
f94033dafc Always show backup settings (even if backup is deactivated).
Previously,
1) we showed backup settings for main users (including secondary non-profile users) only
when backup was activated
2) for profile users, we always showed backup settings.

However, this results in a nullpointer when opening Settings when backup is deactivated
for both main and profile user.
This CL fixes that nullpointer(and also changes existing functionality since keeping
existing functionality and fixing the nullpointer would be too large a code change)

For more details, see https://b.corp.google.com/issues/129843872#comment9 and
https://b.corp.google.com/issues/129843872#comment12


Bug: 129843872

Test: 1. atest -v UserBackupSettingsActivityTest
2. atest -v BackupInactivePreferenceControllerTest
3a) backup not active for main and profile user. shows "isn't active" for both
3b) backup active for main only. shows backup settings for main user and "isn't active" for profile.
3c) backup active for both. shows backup settings for both.
3d) backup active for profile only is not possible (as profile backup is only active when main
user backup is active). if we try to force set it, we get "isn't active" for both
3e) backup not active for secondary user. shows "isn't active"
3f) backup active for secondary user. shows backup settings.


Change-Id: Icb87a047068d29eda560c45dfa4ae02bc991b1af
2019-04-24 18:26:27 +00:00
TreeHugger Robot
ab3f4062d1 Merge "Fix CTS issue on PRIVACY_SETTINGS" into qt-dev 2019-04-24 18:09:37 +00:00
Antony Sargent
74d8d9c31f Implement off state for SIM details page
When a subscription is disabled, we need to hide most things on the
details page. The UX mocks called for leaving in a few things such as
the data usage header and some carrier information, but in tests I've
done it looks like the telephony APIs don't have any of that available
when the subscription is disabled. So for now the only thing left on the
page in the disabled case is the on/off toggle at the very top.

Fixes: 129665956
Test: make RunSettingsRoboTests
Change-Id: I98f4590fca38d03b1e5ff2cf0d2b4876d2adf936
2019-04-24 10:54:47 -07:00
Julia Reynolds
2f731500ad Merge "String changes" into qt-dev 2019-04-24 17:46:42 +00:00
Julia Reynolds
42eefd0d7e Merge "Fix notification preferences" into qt-dev 2019-04-24 17:46:28 +00:00
TreeHugger Robot
08319ee328 Merge "The icon of suggestion_fingerprint should be blue." into qt-dev 2019-04-24 17:45:42 +00:00
Salvador Martinez
415f35b670 Update BatteryUtils to update system battery estimate cache
To try and ensure SysUI and Settings don't show different battery
estimates we have settings always push the estimate to the system
cache which will cause the status bar to update as well.

Test: manually trigger battery broadcasts and observe
Bug: 124030091
Change-Id: I07a17ecf2a42c3022673ad2aca438f8d6e81b41f
2019-04-24 10:35:41 -07:00
Ilya Matyukhin
172d03c758 Merge "Use auth token from intent extras" into qt-dev 2019-04-24 16:27:55 +00:00
andychou
6185e381e0 Fix incorrect mapping to get subscriptioninfo
getActiveSubscriptionInfoList() returns a list of active subscription.
It doesn't 1:1 mapping with slotId. So it is not correct to use slotId
as index to get subscriptioninfo from list.
Use framework interface getActiveSubscriptionInfoForSimSlotIndex() to
get subscriptioninfo per slotid instead.

Bug: 131123246
Test: Test with dual SIM device and atest SimStatusDialogControllerTest
pass

Change-Id: If7140f602571a5cb8dcdfff939bd84ccff0b482f
2019-04-24 23:18:51 +08:00
Julia Reynolds
21959ca6de String changes
Bug: 123899489
Test: make
Change-Id: I4ff2fdd6e0ef467d8385dcf3b75ace48458b88ab
2019-04-24 11:13:22 -04:00
Julia Reynolds
e103aa8fd2 Fix notification preferences
- ImportancePreference should not be separately clickable
- new strings

Bug: 127796543
Fixes: 131060409
Test: make sure talkback doesn't read 'double tap to activate' when
the preference is focused

Change-Id: I6b6eef0915873b4e0b44c59758e5f4b5a265364b
2019-04-24 09:59:20 -04:00
Yanting Yang
316c763316 Improve the latency of NotificationChannelSlice
Get the notification data in parallel to reduce the latency.

Fixes: 123065955
Test: visual, robotests

Change-Id: I434ec68197af214f540ba39ae9155ee7625a2742
2019-04-24 20:54:23 +08:00
tmfang
846f77ab81 Merge "Tweak search result for adaptive brightness" into qt-dev am: 4d03377901
am: 5cdafbc9ca

Change-Id: I26a132f195ae62e2f484cfdd936797f6e9fb4cd8
2019-04-24 01:21:42 -07:00
tmfang
5cdafbc9ca Merge "Tweak search result for adaptive brightness" into qt-dev
am: 4d03377901

Change-Id: Id63484b713666cecf041b3eafe20f8a0360102ad
2019-04-24 01:06:36 -07:00
Mill Chen
3032628269 Update dialog background color for dark theme
Fixes: 129993336
Test: visual
Change-Id: Ie04be80e9b2987a8f7af1c7ecd1628474486bcd0
2019-04-24 15:40:34 +08:00
Kevin Chyn
64d488595f Merge "Stay in face settings unless the user explicitly backs out" into qt-dev am: b70f2b58e0
am: 10e7e5d8d0

Change-Id: I3624db30a90f801b8b2f703afd5b53527cf5f8b7
2019-04-23 23:43:28 -07:00
clownshen
dd4764b7f4 Fix NPE when connect timeout
If user click connect button and then receive timeout event after leave
detail page, the NPE happened. Ignore the timeout event if activity
already gone.

Bug: 131141866
Test: manual test
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.details.WifiDetailPreferenceControllerTest
Change-Id: Ic22c22027386d4a6de5d693eafcd9cd463ed3415
2019-04-24 06:10:18 +00:00
TreeHugger Robot
4d03377901 Merge "Tweak search result for adaptive brightness" into qt-dev 2019-04-24 06:08:18 +00:00
hughchen
36ec99914a Merge "Fix crash when no Bluetooth feature in Settings" into qt-dev am: 7a237a40d7
am: 9eec44bdb0

Change-Id: If3bd9e5cd537dec317268385827019b0834b7bce
2019-04-23 22:50:18 -07:00
Kevin Chyn
10e7e5d8d0 Merge "Stay in face settings unless the user explicitly backs out" into qt-dev
am: b70f2b58e0

Change-Id: I49ea46f8456ed4e418d942b3a059126c1962c685
2019-04-23 22:37:29 -07:00
Kevin Chyn
b70f2b58e0 Merge "Stay in face settings unless the user explicitly backs out" into qt-dev 2019-04-24 04:56:11 +00:00
Fan Zhang
142dc4e3f7 Merge "Fix a NPE when removing accounts." into qt-dev am: 0014cd721e
am: 67c8031f08

Change-Id: I94888acb6d87bf2130c67d175bfded85a5635ebe
2019-04-23 21:54:29 -07:00
Tim Peng
7b0f887000 Update "Play media to" display rule in SoundSetting
- show under Casting mode
- hide under no connected Bluetooth devices
- update test case

Bug: 131143025
Test: make -j42 RunSettingsRoboTests
Change-Id: I0eac856970043ecd9a1975fbe382241078ece924
2019-04-24 04:23:44 +00:00
tmfang
bf2989aaa4 Fix CTS issue on PRIVACY_SETTINGS
Fixes: 130696835
Test: Manually test as following stpes
1. Tap "BYOD Managed Provisioning" under "Managed Provisioning" section
2. Tap "START BYOD PROVISIONING FLOW"
3. Tap "Cross profile intent filters are set"
4. adb logcat -s 'android.settings.PRIVACY_SETTINGS'
        -> No error about android.settings.PRIVACY_SETTINGS

Change-Id: I8fa3b61f14ca2da577493643cda4d7d0c66b8b0b
2019-04-24 12:20:57 +08:00
Ilya Matyukhin
3be240fd8a Use auth token from intent extras
Bug: 124324349
Test: confirmation dialog doesn't show up when intent has auth token
Change-Id: I9e071b06e1041b0d3c78932d8cb2c16c4c32bca5
2019-04-23 20:53:31 -07:00
Leon Liao
06a37d9f0e Replace the placeholder animation.
Update the placeholder animation in Accessibility Settings
'Time to read' and 'Time to take action'.

Bug: 119283926
Bug: 129090045
Test: Screenshot | RunSettingsRoboTests
Change-Id: I215facd35cb3b9d0fc90a5e267368de2edddf0dc
2019-04-24 11:25:02 +08:00
Kevin Chyn
d88289cd2c Merge "Update toggle layout and always show footer text" into qt-dev am: e7eba5d246
am: 8770f0866b

Change-Id: Ib159f6c9937aa37033d95f6e0b932f3f2c99ae4d
2019-04-23 20:23:24 -07:00
lindatseng
5c47099259 Merge "Fix robotests in settings/panel" into qt-dev am: 3225026ed6
am: 55c4916fb7

Change-Id: Ia01b885bb31631ebf62d85597e9a8e1358e686b8
2019-04-23 19:59:42 -07:00
hughchen
9eec44bdb0 Merge "Fix crash when no Bluetooth feature in Settings" into qt-dev
am: 7a237a40d7

Change-Id: Iaea1651a7ba22f1731ee8ad991664b073c5233c3
2019-04-23 19:57:47 -07:00
Amin Shaikh
55169adcd5 Merge "Add overlayable_icons_test.xml for Settings." into qt-dev am: cd52cf18ce
am: e6f875f267

Change-Id: Ifbc0be8431eb463c8748e919bbfa6cd543ec9711
2019-04-23 19:48:14 -07:00
TreeHugger Robot
7a237a40d7 Merge "Fix crash when no Bluetooth feature in Settings" into qt-dev 2019-04-24 02:45:09 +00:00
tmfang
e4753a3632 Tweak search result for adaptive brightness
- Create a new controller for auto brightness in
auto_brightness_detail.xml.
- We only show slice version for search result.
- Change slice summary for adaptive brightness.

Test: visual
Fixes: 130651278
Change-Id: If9b71735bbb2a0ee22676d9dfedab2cf9e778493
2019-04-24 10:04:38 +08:00
Fan Zhang
67c8031f08 Merge "Fix a NPE when removing accounts." into qt-dev
am: 0014cd721e

Change-Id: I7eb956631acac2f44040aca5c9ee325007f8e1f5
2019-04-23 19:03:19 -07:00