Commit Graph

136612 Commits

Author SHA1 Message Date
Omer Ozer
e148ee7877 Add factory reset intent to the settings app.
Bug: 302016478
Test: local
Change-Id: I784395931b32746cb45a447b330ea8d57c17b2fe
2023-10-24 23:59:33 +00:00
Chaohui Wang
066909bc07 Merge "Rearrange Settings dependencies" into main 2023-10-24 23:09:00 +00:00
Krzysztof Kosiński
0efd6d855e Clean up obsolete aliases for Truth.
Bug: 255714762
Test: presubmit
Change-Id: I9b83d3dbcc88b91ebfb88d90ebaee6d960ac7d0b
2023-10-24 23:03:57 +00:00
Joshua McCloskey
302aa72446 Settings ChooseLockscreen* dismiss in background.
Whenever launching
ChooseLockGeneric/ChooseLockPassword/ChooseLockPassword the activity
will finish itself when it goes into the background. This is to ensure
that a user only has an opporunity to complete this process once the
activity is shown. (It cannot be resumed after a power button press, or
sending the activity to the background)

Test: Verified in Settings that the ChooseLockGeneric,
ChooseLockPassword and the ChooseLockPattern activities now exit if they
are sent to the background.
Test: Same as above but in SUW
Test: m -j40 RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.password.ChooseLockPatternTest
Test: m -j40 RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.password.ChooseLockPasswordTest
Fixes: 287473148

Change-Id: Icc9142ff4672ab3669b2f425ff351b03ce7a223a
2023-10-24 21:45:16 +00:00
Daniel Norman
529090ba5d Merge "Adds 'App info' button on accessibility service + activity pages." into main 2023-10-24 21:23:50 +00:00
Daniel Norman
6616da3b71 Merge "Adds OWNERS for Settings aconfig flags, first for Accessibility." into main 2023-10-24 21:21:09 +00:00
Joseph Vincent
f29e758da9 Merge "Make private space settings page non searchable" into main 2023-10-24 12:12:18 +00:00
josephpv
31b044ed6a Prompt user to Setup a device lock if not set
This add below changes on selecting private space setting:
1. Prompt user to setup device lock if not already set
2. If device lock is set authenticate user first before displaying private space settings page

Screenshot - https://screenshot.googleplex.com/4SrYHbBMJfVuoRy.png
https://screenshot.googleplex.com/6vNWm7Lg83vfnH8.png
RecordingLink - https://drive.google.com/file/d/1r4zb3ILPRqwvP5tlwfjQ9GgnDAW4vZg6/view?usp=drive_link

Bug: 289016927
Test: atest PrivateSpaceSettingsAuthenticatorTest , atest SecuritySettingsTest
Change-Id: I0e5dfb30213843c0dec60a17d01c30cd91db89b0
2023-10-24 10:42:57 +00:00
josephpv
0fe1bc58b2 Make private space settings page non searchable
Screenshot: https://screenshot.googleplex.com/7tBd5FQ3F8SZceR.png

Bug: 306602816
Test: manual settings search for "Private Space"
Change-Id: I8fc19f6db3b002a62f82dfa9754277da26bf74c0
2023-10-24 10:27:40 +00:00
FanWu
045ab32693 Update owners file
Test: not required
Change-Id: I4195cc6bc3c5ec3e8882258ec2d73ed64385a756
2023-10-24 18:23:06 +08:00
Chaohui Wang
2a166676d4 Migrate test to TwoStatePreference
Bug: 306771414
Test: m SettingsUnitTests
Change-Id: I67c8e0c7f04faba377a156587f43929ac73e500f
2023-10-24 18:14:50 +08:00
Yiyi Shen
852ec4e22d Merge "[Audiosharing] Add audio sharing settings with the main switch." into main 2023-10-24 09:50:40 +00:00
Mark Kim
680a183ab7 Merge "Do not show "Not installed for this user" summary for archived app" into main 2023-10-24 09:02:17 +00:00
Yiyi Shen
4410df7f42 [Audiosharing] Add audio sharing settings with the main switch.
Flagged with enable_le_audio_sharing

Bug: 305620450
Test: Manual
Change-Id: I9ca520014d3f6f7147bb9b8e7648797e79b46f53
2023-10-24 16:12:13 +08:00
Chaohui Wang
6c3a637f2d Merge "Migrate new() to SwitchPreferenceCompat" into main 2023-10-24 08:05:18 +00:00
Chaohui Wang
fcc636d571 Rearrange Settings dependencies
Bug: 285231003
Test: m Settings
Change-Id: Id5adab7d9a24265b98db9959c30904e82ad60dd4
2023-10-24 15:44:38 +08:00
Chaohui Wang
a0abccadc6 Merge "Migrate mobile settings to SwitchPreferenceCompat" into main 2023-10-24 07:30:45 +00:00
SongFerng Wang
ae7b0b0996 Merge "Add try-catch for set/get wifiCalling mode" into main 2023-10-24 06:40:24 +00:00
Chaohui Wang
cfdb3b1f1b Migrate new() to SwitchPreferenceCompat
Bug: 306658427
Test: manual - on Settings pages
Change-Id: I258a8c63d5c46403c6d333a9d2f34c33cb35e27f
2023-10-24 14:05:34 +08:00
SongFerngWang
5ce87cb03d Add try-catch for set/get wifiCalling mode
The APIs can throw IllegalArgumentExceptionm, the UI need the try-catch.

Bug: 299239773
Bug: 287946939

Test: build pass
Change-Id: I4b413abc985dfa871d3c2d39798b51dc1a686313
2023-10-24 13:47:30 +08:00
Chaohui Wang
7c95dad1dd Migrate mobile settings to SwitchPreferenceCompat
Also set switch style.

Bug: 306658427
Test: manual - on Mobile Settings
Test: unit test
Change-Id: Ia0bcf9646076636b95f0b31c34113cce45f2e51a
2023-10-24 10:48:23 +08:00
Joshua Mccloskey
5036a9cb17 Merge "Created biometric provider." into main 2023-10-24 00:41:18 +00:00
Jim Shargo
da2c46d926 Merge "Revert "Adding back screenshot test to Settings."" into main 2023-10-24 00:06:03 +00:00
Jim Shargo
0d67f55cba Revert "Adding back screenshot test to Settings."
This reverts commit 4dc4e1c02a.

Reason for revert: broke the build

Change-Id: I3037248a5df06d6f92dfa9c5666625f23230646a
Bug: 307406217
2023-10-24 00:05:48 +00:00
Joshua Mccloskey
29c9e4c0b6 Merge "Adding back screenshot test to Settings." into main 2023-10-23 21:16:42 +00:00
Joshua Mccloskey
4dc4e1c02a Adding back screenshot test to Settings.
Test: atest SettingsScreenshotTests
Fixes: 307356833

Change-Id: I9e168010d6c83aad44969c60deaef8e61a10ddd1
2023-10-23 20:08:29 +00:00
Bill Yi
ff55fd7cb5 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: 639cfd9c3f -s ours am: cccaf5a711 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126854

Change-Id: I9483ec7ff7785033d8a2f95fe86e102c29246a28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:57:47 +00:00
Bill Yi
5d64ed8097 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a3d94436f2 -s ours am: 7093b062bb -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126854

Change-Id: If9d7a79acd028544048e92cbbb80a7d9d22674c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:57:44 +00:00
Bill Yi
2741f41063 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: ff0925c00f -s ours am: 00f546568c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126852

Change-Id: I6634d9e1a454a92a547ea8c16adf9bb7ba487e69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:57:31 +00:00
Bill Yi
9899094182 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5f6854e60a -s ours am: 0bf6e27ecc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126852

Change-Id: Ide4b96e7f93ba6df8e957abd4d2c0c040b8e8d95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:57:13 +00:00
Bill Yi
cccaf5a711 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: 639cfd9c3f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126854

Change-Id: Id72c67f45850ce7ee070bf953337451d901da59c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:36:53 +00:00
Bill Yi
7093b062bb [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a3d94436f2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126854

Change-Id: I67aa0cb798b4efb40a90935455b7cf0797ab956c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:36:49 +00:00
Bill Yi
00f546568c [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: ff0925c00f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126852

Change-Id: I621a669257f47089b2ca8ee08063f321d55d23d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:36:40 +00:00
Bill Yi
0bf6e27ecc [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5f6854e60a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126852

Change-Id: I2256098a5f45dd8844461368ec6cb9824ae4143c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:36:18 +00:00
Jihoon Kang
4721b48cbe Merge "Temporarily disable nullaway plugin" into main 2023-10-23 19:29:13 +00:00
Bill Yi
639cfd9c3f Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-10-23 19:16:21 +00:00
Bill Yi
ff0925c00f Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-10-23 19:16:21 +00:00
Bill Yi
b638507751 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: fb88ae863a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/25126850

Change-Id: I030b6955dd756c1b44a78f52589701af3116e61e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 19:14:40 +00:00
Bill Yi
40b64880ba Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-23 19:08:22 +00:00
Bill Yi
603e5f9e68 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-23 19:08:22 +00:00
Bill Yi
b5a8f86550 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-23 19:08:22 +00:00
Joshua McCloskey
7526b9259e Created biometric provider.
Test: Manually verified data was fetched successfully.
Test: adb shell device_config put biometrics_framework
com.android.settings.flags.biometric_settings_provider true
Test: atest BiometricSettingsProviderTest
Bug: 303595205

Change-Id: I154754eed7c36d659853ed83cc18a2e446fb7678
2023-10-23 18:50:58 +00:00
Jihoon Kang
f528f7eaf3 Temporarily disable nullaway plugin
The nullaway plugin fails in errorprone build with stubs generated from
the API signature files, although the nullability information between
the from-text and from-source stubs are identical. Below is the failing
error message:
```
packages/apps/Settings/src/com/android/settings/accessibility/AccessibilitySettingsContentObserver.java:54: error: An unhandled exception was thrown by the Error Prone static analysis plugin.
            contentResolver.registerContentObserver(uri, false, this);
                           ^
     Please report this at https://github.com/google/error-prone/issues/new and include the following:

     error-prone version: 2.15.0
     BugPattern: NullAway
     Stack Trace:
     com.google.common.util.concurrent.UncheckedExecutionException: java.lang.RuntimeException: expected call to iterator(), instead saw null
```
The error message indicates that the nullaway plugin is throwing an
uncaught exception. Given that the plugin has been recently introduced
to the tree and is currently being only used by Settings, this change
proposes to temporarily disable the plugin to unblock the from-text stub
generation feature and re-enable the plugin once the issue is fixed.

Test: m Settings
Bug: 306242755
Bug: 304077181
Change-Id: I617d8f20ceeefb339b3c1f8cd03af94a8c37fd39
2023-10-23 18:20:59 +00:00
Yiyi Shen
2bf233e30b Merge "Fix crash when showing the device not found dialog." into main 2023-10-23 12:16:23 +00:00
Mark Kim
24004592cc Do not show "Not installed for this user" summary for archived app
Test: AllAppListTest

Bug: 304255511
Change-Id: I806fed91d4716e8e21f70ec1ad8572f246c7f031
2023-10-23 12:07:31 +00:00
Mark Kim
35629bd16b Merge "Tests that archived apps are returned for AllAppListPage when "android.content.pm.archiving" flag is enabled" into main 2023-10-23 11:46:01 +00:00
Chaohui Wang
15ca95a31b Migrate to TwoStatePreference
SwitchPreference and SwitchPreferenceCompat are both TwoStatePreference.

Using TwoStatePreference in Java will helps migration in the future.

Bug: 306771414
Test: manual - check Settings pages
Change-Id: I84e1d7b09451106797c2b23d127855c6976678ca
2023-10-23 09:28:57 +00:00
Yiyi Shen
a7d0d00f4a Fix crash when showing the device not found dialog.
If users click to pair a not foundable device and then close the Settings page,
Settings will crash becasue dialog holder is closed.
This CL is part of the fix. It set the context to null when the activity
stops.

Bug: 306548036
Test: atest
Change-Id: If68e3e9cd62216ad83b2e5058f504fce35e36a06
2023-10-23 17:26:17 +08:00
Cassie Wang
7976f1e76d Merge "Add a config to show the Vpn options menu." into main am: 5abd3420c4 am: ccdd06e496 am: f582544551
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2685406

Change-Id: Iaedb4a2933ce24fbd8bd4aabb03da908beab5131
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 07:02:30 +00:00
Cassie Wang
3b7f437db8 Merge "Add a config to show the Vpn options menu." into main am: 5abd3420c4 am: 16e99c187f am: 16677a5492
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2685406

Change-Id: I5dee3042db1274b1203b08afa09dfe6798f3c4ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-23 07:01:38 +00:00