Commit Graph

2577 Commits

Author SHA1 Message Date
TreeHugger Robot
c4dafb43d3 Merge "Add type service in settings advanced page." 2017-02-18 01:08:22 +00:00
TreeHugger Robot
76cf6f9a68 Merge "Fix problem with usb mode summary not updated correctly." 2017-02-18 01:00:00 +00:00
TreeHugger Robot
5985ff098d Merge "Log search result click and its rank." 2017-02-18 00:09:01 +00:00
Matthew Fritze
592e4d739b SearchView keyboard opens and closes appropriately
- Keyboard opens when Search View opens
- Keyboard closes on query text submit
- Keyboard closes when user scrolls through results

Change-Id: I7cef383a2799eeb456fbaa07b8577c88cd35a997
Fixes: 34723251, 35164545
Test: SearchFragmentEspressoTest, manual test requested from QA
2017-02-17 23:37:26 +00:00
Doris Ling
21711681ea Fix problem with usb mode summary not updated correctly.
In UsbBackend, do not cache the usb state, but re-read it everytime when
we try to get the usb data mode.

Change-Id: I6f2863a59ee8df2c50901a630e3e145714c7dc46
Fix: 34234065
Test: make RunSettingsRoboTests
2017-02-17 15:22:13 -08:00
jackqdyulei
acc195fdde Add type service in settings advanced page.
Currently it only includes the gms service

Bug: 35317876
Test: RunSettingsRoboTests
Change-Id: I20a2a9d320efe4aed036552d450f59c89e81584a
2017-02-17 15:17:31 -08:00
jackqdyulei
e2fbdfefef Refine battery text in battery header
1. When there exists estimate time, show it, otherwise
show battery status label.
2. Change the summary based on whether it is charging.
(Estimated time left vs Time to full charge)

Bug: 35328749
Test: RunSettingsRoboTests
Change-Id: I64ee8acd248062b4effcfc58ed908be7d89621a3
2017-02-17 13:57:43 -08:00
TreeHugger Robot
07800b319d Merge "Add metric events triggers for new storage actions." 2017-02-17 20:48:34 +00:00
Matthew Fritze
04615bc1b6 Blocks resources from adding headers that match settings
Certain Xml resources have a single setting for the page
which often means the header and setting have the same
title. This CL stops the header from being indexed in
that case.

Bug: 33701673
Test: make RunSettingsRoboTests
Change-Id: Ie617414010e654c41fd014aa2fe297e6d2088ca5
2017-02-17 09:39:21 -08:00
TreeHugger Robot
c65e3a19a1 Merge "Modify test cases according to change in remove preference behavior." 2017-02-17 04:01:42 +00:00
TreeHugger Robot
309862d3b8 Merge "Make the list in advanced battery page sorted by usage." 2017-02-17 02:40:27 +00:00
TreeHugger Robot
3e0ae4ed90 Merge "Add settings for the assist gesture." 2017-02-17 02:13:00 +00:00
Doris Ling
493fd4e6d6 Recursively find preference in progressive disclosure.
Add handling to check for nested preference when finding preference
in the collapsed list.

Change-Id: I830bdd5fd99f09c505f41fd3bb2fa968eb9b13cf
Fix: 35363405
Test: make RunSettingsRoboTests
2017-02-16 17:40:40 -08:00
Doris Ling
8a7504eb12 Modify test cases according to change in remove preference behavior.
Bug: 35365702
Test: make RunSettingsRoboTests
Change-Id: I541f4bd946116c766a90da955c11933a5499fa93
2017-02-16 16:45:27 -08:00
jackqdyulei
22dbc106e7 Make the list in advanced battery page sorted by usage.
1. Make the preference dynamically generated in code
2. Make PowerUsageData comparable and add title resource id.

Bug: 34385770
Test: RunSettingsRoboTests
Change-Id: I1b90b4c6cc7107bc146e3554db04cec7641e1cde
2017-02-16 16:22:16 -08:00
TreeHugger Robot
db59347c29 Merge "Mark only browser as default in app detail page" 2017-02-17 00:04:35 +00:00
Fan Zhang
8fc4e819a2 Log search result click and its rank.
Bug: 34975477
Test: RunSettingsRoboTests
Change-Id: I86e72dbd27ac5daeafa4fb35ad55662de7b3eca9
2017-02-16 14:53:49 -08:00
Fan Zhang
6786d8cd53 Mark only browser as default in app detail page
Change-Id: I8112d859ba788a1dc67c44b5e0de668c0fc13169
Fix: 35307728
Test: make RunSettingsRoboTests
2017-02-16 14:32:05 -08:00
Daniel Nishi
e0eb1a2e27 Add metric events triggers for new storage actions.
Bug: 35063738
Test: Settings Robotests
Change-Id: I435cb16c492d3777e735266c2d3a2b1930443acb
2017-02-16 13:43:03 -08:00
TreeHugger Robot
33c51a7b5b Merge "Fix NPE in WriteWifiConfigToNfcDialog." 2017-02-16 20:26:39 +00:00
TreeHugger Robot
a35335f09b Merge "Add source metrics when launching top level setting items." 2017-02-16 20:04:31 +00:00
Amin Shaikh
5bac36a15a Fix NPE in WriteWifiConfigToNfcDialog.
Bug: 34691792
Test: m RunSettingsRoboTests
Change-Id: I0e396f4f590c8de6636c7494e20d74c562b7c9cd
2017-02-16 10:34:36 -08:00
Fan Zhang
cb287cfcd2 Add source metrics when launching top level setting items.
Change-Id: Idca6e136747fb40ba962307abd2620cdd241c3b1
Fix: 35359289
Test: make RunSettingsRoboTests
2017-02-16 10:25:49 -08:00
Daniel Nishi
ce82b66136 Merge "Fix a race condition where the extra view may not update timely." 2017-02-16 17:39:40 +00:00
TreeHugger Robot
0f28cbd21b Merge "Modify text in Apps & notifications settings." 2017-02-16 05:25:44 +00:00
TreeHugger Robot
3a399f5eb4 Merge "Log source with visibility change" 2017-02-16 04:42:44 +00:00
Doris Ling
015a50bef9 Modify text in Apps & notifications settings.
- in Settings->Apps & notifications->Apps->[select app], update the
  header summary to installation status, and move the version text to
  the bottom of the page.
- updatd preference title from Apps to App info
- update preference title from Notifications to App notifications

Bug: 34977561
Test: make RunSettingsRoboTests
Change-Id: I97e9b81c739fb99eaca2cf45fb11f208ad6cd9ca
2017-02-15 19:02:33 -08:00
TreeHugger Robot
f33561cd74 Merge "Update texts for Settings->Sound->Do not disturb" 2017-02-16 02:51:38 +00:00
Fan Zhang
c6ca314c0b Log source with visibility change
- Add a method in VisibilityLoggerMixin to log visible event using
  LogMaker, which allows logging additional FIELD_CONTEXT field.
- In Utils.startFragment, add current page's metricsCategory as an extra
  to next page.
- In next page's onResume(), extract the previous page's metricsCategory
  and send it to VisibilityLoggerMixin.visible()
- Update all caller with additional paramters

Change-Id: I8e1f2597fa465b7d3aa16fa1d21c052a3219694a
Fix: 35359289
Test: RunSettingsRoboTests
2017-02-15 17:17:19 -08:00
TreeHugger Robot
358eab0fff Merge "Update layout for App info page." 2017-02-16 01:05:40 +00:00
Fan Zhang
fe9f0fda35 Add logging when "Advanced" button is clicked
Change-Id: I8259b1b863991935165afb19e34c30dcf5056acf
Fix: 35356464
Test: RunSettingsRoboTests
2017-02-15 15:12:26 -08:00
Doris Ling
4d8a9bd879 Update texts for Settings->Sound->Do not disturb
- Update title to "Do not disturb preferences"
- Add summary text to reflect the priority only allows preferences
- Refactor the summary handling in ZenModeSettings so that the
  controller can get the summary text

Fix: 34975939
Test: make RunSettingsRoboTests

Change-Id: I3ca1dc43fe1d943735a9f625e66c89708a18300a
2017-02-15 13:53:10 -08:00
TreeHugger Robot
011d78ae47 Merge "Remove extra IndexProviders that provided bad data." 2017-02-15 21:44:15 +00:00
Doris Ling
2ed09339d4 Update layout for App info page.
- Move the app link buttons to the right
- Move the footer buttons to the top below the header
- Rename the app header details title, summary, and icon views.

Bug: 34977561
Test: make RunSettingsRoboTests
Change-Id: Id0cfc2b73b4e5cbbc1a58e497da52560892b69c8
2017-02-15 12:33:42 -08:00
TreeHugger Robot
ec6cd665b1 Merge "Skip redundant SuggestionLoader run during app start." 2017-02-15 03:04:09 +00:00
Fan Zhang
efba6b4e14 Skip redundant SuggestionLoader run during app start.
also skip DiffUtil when drawing first frame.


Fix: 34103984
Test: make RunSettingsRoboTests
Change-Id: I4891d1bca1f17c437444761eaf3002624934014d
2017-02-15 02:06:08 +00:00
TreeHugger Robot
1f52676019 Merge "Update security screen summary text when no fingerprint" 2017-02-15 00:50:39 +00:00
Philip Quinn
a9831d40d0 Add settings for the assist gesture.
Availability of the gesture is gated by a new FeatureProvider.

Test: make -j RunSettingsRoboTests; manual test on
      supported/unsupported configurations.

Change-Id: I3529367a73e33370d5112b91d5144293ffa7fa22
2017-02-14 16:45:23 -08:00
Matthew Fritze
46173a5265 Remove extra IndexProviders that provided bad data.
Gesture Settings and Wireless settings were indexing
duplicate results that only added complexity to Search.
PowerUsageDetail was never supposed to be indexed.

Bug:33701673
Test: make RunSettingsRoboTests
Change-Id: I45d1fa4bd412c3418acec24f8c98eb4736f220ab
2017-02-15 00:36:25 +00:00
TreeHugger Robot
11b2e91890 Merge "Replace footer with regular preference" 2017-02-15 00:12:21 +00:00
Fan Zhang
2cab298f13 Update security screen summary text when no fingerprint
Change-Id: I810c533b0daeab3bd67d9d5be8a89d93738b4962
Fix: 35339887
Test: RunSettingsRoboTest
2017-02-14 15:05:40 -08:00
Salvador Martinez
2f0bee5032 Replace footer with regular preference
Replaced the "Manage Storage" footer preference
with a regular preference because the footer type
is not meant to be a touch target. This should fix
the bug with not being able to click on specific
parts of the preference.

Test: run settings espresso tests
Bug: 34349518
Change-Id: I36ada2a6a537a68d9fcbe7e10773896225ecc6b2
2017-02-14 14:12:56 -08:00
Matthew Fritze
fa96bdf428 Merge "Revert "Remove Gesture settings as inline results"" 2017-02-14 22:05:05 +00:00
Matthew Fritze
5a67ccd04e Revert "Remove Gesture settings as inline results"
This reverts commit 4ec4969b33.

Change-Id: I5b0012174864bba8b196220ee29863a9a58faa69
2017-02-14 22:02:13 +00:00
TreeHugger Robot
97ced76a54 Merge "Add account preferences from account type description." 2017-02-14 21:30:41 +00:00
TreeHugger Robot
b2db7d6f9d Merge "Remove Gesture settings as inline results" 2017-02-14 19:03:57 +00:00
Doris Ling
13ac8845e7 Add account preferences from account type description.
Move the methods that handles the account type preferences to a separate
class and add the call to it in AccountDetailDashboardFragment.

Change-Id: Ib147fb73807b1264e3faedad3466126f2fd9c84d
Fix: 35224671
Test: Manual
2017-02-14 10:42:58 -08:00
Matthew Fritze
4ec4969b33 Remove Gesture settings as inline results
Given that inline results do not have intents associated,
the inline results must be self-explanatory. The gesture
settings ofter requier the video/animation to be
understood. Thus they should not be inline.

Test: RunSettingsRoboTests
Bug:
Change-Id: Iae25365b376ec510f8330bc0a0bf72883cf9a6d4
2017-02-14 09:06:41 -08:00
Anton Philippov
f8b3154586 Add tests for BackupSettingsActivity
Bug: 34925593
Test: make RunSettingsRoboTests
Change-Id: I539d417ca70224e3c7554abc097868ca366de89c
2017-02-14 11:02:40 +00:00
Fan Zhang
42aaa53e75 Add logging for settings
- Log when navigating from Settings to injected tiles.
- Log when user creates a new widget shortcut

Fix: 33209678
Fix: 30137094
Test: RunSettingsRoboTests
Change-Id: I1e0f4e00709c392cde2550fafe53890836387c99
2017-02-13 16:57:28 -08:00