Commit Graph

18373 Commits

Author SHA1 Message Date
Rajeev Kumar
a414ef872f Merge "Create a feature provider for data plan feature. This change will allow us to enable/disable this feature from adb shell." 2017-07-05 21:33:23 +00:00
Fan Zhang
e6b7bc6f15 Fix alignment for build number preference in RTL.
- Fixed by adding BidiFormatter.unicodeWrap around the whole string.

Change-Id: I3ca1292d912062db8c2fead524cd84a19eb80cff
Fix: 63135900
Test: make RunSettingsRoboTests
2017-07-05 14:20:08 -07:00
TreeHugger Robot
ff45106b49 Merge "Adjust UX for toggles when active scorer is not set." 2017-07-05 21:19:58 +00:00
jackqdyulei
e0fa4afc71 Merge "Update the method about foreground time." into oc-dr1-dev am: 96e774b7d7
am: b067dea683

Change-Id: I3ef03ee20157e41228ebe4656109abf055a20ec1
2017-07-05 20:43:58 +00:00
jackqdyulei
b067dea683 Merge "Update the method about foreground time." into oc-dr1-dev
am: 96e774b7d7

Change-Id: I4037f224cf5028abe5617775d394adfed1552b27
2017-07-05 20:42:10 +00:00
TreeHugger Robot
96e774b7d7 Merge "Update the method about foreground time." into oc-dr1-dev 2017-07-05 20:38:52 +00:00
Soroosh Mariooryad
55bb0c258d Log async ranking state in Settings search ranking
Bug: 62072727
Test: RunSettingsRoboTests

Change-Id: I2140c41d01f18a1e4b9e3f505e0afa4a8757d049
2017-07-05 13:04:22 -07:00
Sundeep Ghuman
d569195299 Use EntityHeaderController in WifiDetailPreferenceController.
Switch to the Entity header to bring parity in design of
WifiNetworkDetailsFragment and other Settings pages.

Bug: b/37252029
Test: make -j40 RunSettingsRoboTests
Change-Id: Ib11f3d37eac4dca08fa61eef67910cd328682bac
2017-07-05 12:54:38 -07:00
Doris Ling
c7d2d270ab Ensure that brightness level is within 0-100%.
Check whether the retrieved brightnesss value is out of range, and
adjust it if necessary.

Change-Id: Ieb1ccc03dcb9fa3e1ed192fcc3d217b84d4d316c
Fix: 63181935
Test: make RunSettingsRoboTests
2017-07-05 12:53:04 -07:00
Stephen Chen
7e27006a7b Adjust UX for toggles when active scorer is not set.
This change fixes two issues: when wakeup is not available, update the
number of items to show above the fold in wifi preferences. When scorer
is not set, grey out wakeup toggle and set summary to reflect the
status.

Bug: 62410973
Bug: 62343859
Test: make RunSettingsRoboTests -j40

Change-Id: I5f4131c6a86eab6c0fb03ea2b5101ba107a9189f
2017-07-05 12:29:06 -07:00
Rajeev Kumar
ad157aca52 Create a feature provider for data plan feature. This change will
allow us to enable/disable this feature from adb shell.

Bug: 62349208
Test: make RunSettingsRoboTests -j40
Change-Id: I2d0bed738d5d4cd0fe1de056ee37092d46be72b6
2017-07-05 12:25:53 -07:00
Phil Weaver
633c9be21c Migrate to new overlay-stopping flag
Bug: 62196835
Test: Started an accessibility service that displays an app
overlay and verified that it disappears when approving an
accessibility service's capabilities.

Change-Id: I7c8d8b4143a5dd1cb684c31c4503608c8d5be0e3
2017-07-05 10:41:18 -07:00
TreeHugger Robot
f0398e1294 Merge "Add an activity that starts DataUsageList fragment for mobile." 2017-07-05 17:40:13 +00:00
phweiss
7a34e9c28e When Remove Account is disallowed, show dialog
When DISALLOW_MODIFY_ACCOUNT is set by a device admin, and
the user wants to remove an account, show the support dialog
instead of showing the confirm dialog.

To use the O-API DPM.createAdminSupportIntent(), a wrapper
needs to be used, because existing Robolectric tests otherwise
don't compile.

Bug: 37413849
Test: make RunSettingsRoboTests -j40 ROBOTEST_FILTER=*RemoveAccountPreferenceControllerTest

Change-Id: If23ea304ab8b9df1748e6acf3032310843b04780
2017-07-05 19:32:48 +02:00
Daniel Nishi
5d272ce4ff Unify storage calculations.
Due to one calculation using longs and the other using doubles, there
were situations where the percentage was off-by-one between the two
places.

By changing both places to now use doubles to calculate percentages, the
numbers should be unified.

Change-Id: I4f4ed19326562e198273adc60a1593c7d1a6b6a7
Fixes: 37923610
Test: Manual
2017-07-05 10:10:15 -07:00
Daniel Sheng
20d5588a27 Added suggestions for gestures.
Bug: 30986021
Test: manual + make RunSettingsRoboTests + adb shell am instrument -w
com.android.settings.tests.unit /android.support.test.runner.AndroidJUnitRunner

Change-Id: I7aed110c81ca2fb6b90e2f359b4bb941c02bc1c3
2017-07-05 09:05:11 -07:00
Charles He
d5612408af Merge "Disable incorrect strong auth prompt strings." into oc-dr1-dev am: c619ad77bb
am: 3ae7bacff4

Change-Id: I6c0e42bc214d68628e65ea2c90852b282f935690
2017-07-03 15:38:13 +00:00
Charles He
3ae7bacff4 Merge "Disable incorrect strong auth prompt strings." into oc-dr1-dev
am: c619ad77bb

Change-Id: I6d4e95b63896365308c8acaa07699d53560d64b4
2017-07-03 15:34:45 +00:00
Charles He
c619ad77bb Merge "Disable incorrect strong auth prompt strings." into oc-dr1-dev 2017-07-03 15:32:09 +00:00
Charles He
701ac5cbee Disable incorrect strong auth prompt strings.
The prompt strings on the confirm credentials screen (pin, password,
pattern) are incorrect. They currently say strong auth is "required
after device restarts". But instead they should be "required for
additional security" because strong auth can be enforced not only after
device or profile restarts, but also after profile key eviction, for
example.

Unfortunately, we've already missed the window for string changes.
Therefore, as an alternative, we use generic prompt strings in this CL,
to avoid conveying the incorrect (and misleading) information. We'll
follow up with another CL in master with a proper string change to fix
the issue.

Bug: 36511626
Test: manual
Test: make SettingsRoboTests
Change-Id: I44f84420b88bb4933ad0afa6e8032af465de0cd3
2017-07-03 09:42:20 +01:00
Kevin Chyn
8b2304f232 Fix Assist Gesture settings check
Fixes: 63181412

Test: manual
Change-Id: Ie51cc4bb62c68722e4613850bfdb4dc67ae15e77
2017-06-30 22:41:56 -07:00
Kevin Chyn
9fde3fe2ab Merge "Assist gesture setting should not be available on unsupported devices" into oc-dr1-dev am: 72a94e9f5a
am: 408efb26f0

Change-Id: I696511821f64f7bc09819cf1d45374125b7905c0
2017-07-01 03:11:52 +00:00
Kevin Chyn
408efb26f0 Merge "Assist gesture setting should not be available on unsupported devices" into oc-dr1-dev
am: 72a94e9f5a

Change-Id: I7748c0537a6eebb1fd460b3039a9a53dc070e19e
2017-07-01 03:06:52 +00:00
TreeHugger Robot
72a94e9f5a Merge "Assist gesture setting should not be available on unsupported devices" into oc-dr1-dev 2017-07-01 02:59:19 +00:00
TreeHugger Robot
d9f978af21 Merge "Code cleanup: DashboardAdapter.category is no longer a list" 2017-07-01 01:06:58 +00:00
Jeff Davidson
4ba7478fdf Don't show "Wipe eSIMs" checkbox for developers.
Per UX review feedback, it doesn't make sense to show this just
because someone has developer options turned on. So only show it if
the user has ever downloaded an eSIM profile.

Change-Id: If474451dddcaa75bce1e57ce2f1751ef3adf45ee
Test: TreeHugger
Fixes: 63147904
2017-07-01 01:06:19 +00:00
Antony Sargent
1b6e7d76ed Fix Bluetooth device details crash on screen rotation
We were getting the following exception when you rotated the Bluetooth
device details screen:

java.lang.RuntimeException: Unable to start activity
ComponentInfo{com.android.settings/com.android.settings.SubSettings}:
java.lang.IllegalStateException: This Activity already has an action bar
supplied by the window decor. Do not request Window.FEATURE_ACTION_BAR
and set android:windowActionBar to false in your theme to use a Toolbar
instead.

It turns out that allowing EntityHeaderController to inflate the
settings_entity_header.xml view seems to cause this - if you instead
manually include a LayoutPreference and hand that to
EntityHeaderController, you don't have the problem.

The rotation failure couldn't be tested with Robolectric because our
version doesn't support using FragmentTestUtil.startFragment for
fragments which use PreferenceScreen's ("sorry, not yet
implemented"). So instead this includes an app test.

Bug: 62447414
Test: runtest --path=BluetoothDeviceDetailsRotationTest.java
Change-Id: I8d052d1f4ab6e2b0ca5c0e513ec366bdcc382d99
2017-06-30 16:34:40 -07:00
Kevin Chyn
1db30b7749 Assist gesture setting should not be available on unsupported devices
Fixes: 63176246

Test: manual
Change-Id: I17cd338eafd2e1a86d1e82d81bc9817eaf18d57b
2017-06-30 16:27:49 -07:00
jackqdyulei
43cbee6914 Update the method about foreground time.
For now it uses MIN(STATE_TOP_TIME, FOREGROUND_ACTIVITY_TIME) and this
method is used in both display and screen smearing.

Bug: 63080621
Test: RunSettingsRoboTests
Change-Id: I2ca3109697aa66fae67d8b2f4f10c4d08bb99d59
2017-06-30 16:18:29 -07:00
TreeHugger Robot
b35d7301d7 Merge "Remove animation from account detail page." 2017-06-30 22:49:31 +00:00
Fan Zhang
b487fae5d8 Code cleanup: DashboardAdapter.category is no longer a list
We only ever display a single DashboardCategory in homepaeg, so the
category doesn't need to be a list in DashboardData/Adapter

Change-Id: I57db02bb45cbc511f0fce1bf33043b51ef9db15c
Fix: 33861822
Test: updated robotests
2017-06-30 15:30:51 -07:00
Salvador Martinez
11a5b9bd4d Merge "Add BatteryInfo logging to settings" into oc-dr1-dev am: 9a3b115cc8
am: 97642af54d

Change-Id: Id4f7032e735067ab9a81476e83003c942eb4f826
2017-06-30 22:16:47 +00:00
Salvador Martinez
97642af54d Merge "Add BatteryInfo logging to settings" into oc-dr1-dev
am: 9a3b115cc8

Change-Id: I447d0d7689f77b12a0caf9374155883217ff330a
2017-06-30 22:05:53 +00:00
TreeHugger Robot
9a3b115cc8 Merge "Add BatteryInfo logging to settings" into oc-dr1-dev 2017-06-30 21:58:38 +00:00
TreeHugger Robot
283895c03b Merge "Sorting search results with TreeSet instead of Collection.sort" 2017-06-30 20:16:37 +00:00
TreeHugger Robot
a1bf76a69d Merge "Also tint the settings icon in DashboardAdapter.setCategory()." 2017-06-30 20:07:40 +00:00
Jason Monk
6434f44971 Allow clicking on guest user am: c1cc9fefa8
am: bc4df21ef7

Change-Id: I013a1c3eae74d34a05494d7a4a78f51e9ddd3470
2017-06-30 19:51:03 +00:00
Jason Monk
bc4df21ef7 Allow clicking on guest user
am: c1cc9fefa8

Change-Id: I828716ff982cd2f8bedc96b74c1abc44716cc753
2017-06-30 19:43:00 +00:00
Soroosh Mariooryad
cf66647a4e Sorting search results with TreeSet instead of Collection.sort
Benchmarking shows lower sorting latencies with with TreeSet, specially
with larger lists:

Average Latencies(ms):
                  list size in [0, 115]         list size in [40, 115]
Collection.sort   39.22                         77.57
TreeSet           30.23                         52.06

Test: RunSettingsRoboTests

Bug: 38197948
Bug: 37312700

Change-Id: I1dd7c77900e8e98e26a8417f2b77582532e1a5f3
2017-06-30 12:04:13 -07:00
Jason Monk
c1cc9fefa8 Allow clicking on guest user
This is needed since the user switch will be hidden by default in
QS and will show up once multi-user has been activated in some way.

Test: click on guest
Bug: 37152893
Change-Id: I351a5d95e9e8a5e47e388d9f0611924b077754da
2017-06-30 11:29:40 -04:00
TreeHugger Robot
afeb5e2d45 Merge "Settings app changes spell checker settings directly without TSM APIs" 2017-06-30 15:19:35 +00:00
Sundeep Ghuman
0a1003a8df Merge "Don't scroll when removing saved networks." into oc-dr1-dev am: 1e561edb45
am: b963c1190f

Change-Id: I389ffac52942e382e145de94c166578d6ead48ad
2017-06-30 00:12:41 +00:00
Sundeep Ghuman
b963c1190f Merge "Don't scroll when removing saved networks." into oc-dr1-dev
am: 1e561edb45

Change-Id: I9fa78596bdcbaeac90aaee55ddcde3f698ad907f
2017-06-30 00:04:37 +00:00
Sundeep Ghuman
1e561edb45 Merge "Don't scroll when removing saved networks." into oc-dr1-dev 2017-06-29 23:56:51 +00:00
Salvador Martinez
cc7c9603db Add BatteryInfo logging to settings
This Cl adds a few log statements to BatteryInfo to try
and determine what the bottleneck in the Battery Settings
Advanced page could be.

Test: robotests still pass
Bug: 62959645
Change-Id: I1ff712d97bc8be78873c63e187edbffa8e10cd21
2017-06-29 16:53:27 -07:00
Andrew Sapperstein
b2c69878d1 Merge "Fix robotests." into oc-dr1-dev am: db72caf3ea
am: 8e1c3b9b1b

Change-Id: I2990a108691e8123df1eeefc50f650d0b8d318a6
2017-06-29 23:42:57 +00:00
Andrew Sapperstein
8e1c3b9b1b Merge "Fix robotests." into oc-dr1-dev
am: db72caf3ea

Change-Id: I8893ca932f1cfcb20d72609eaf994bc7ddb9f143
2017-06-29 23:35:26 +00:00
Andrew Sapperstein
51e4a66446 Fix robotests.
Change-Id: Ia0615bfdd303a19b145ead44979a03ccdd29bf41
Fixes: 63141368
Test: robotest
2017-06-29 16:24:32 -07:00
Doris Ling
328e1466f3 Remove animation from account detail page.
Set the preference comparison callback to null for the account detail
fragment so that there won't be animation when the we insert the dynamic
tiles.

Change-Id: I35c9fcda500e58d0a18f6ad4ef6f0651166fd70a
Fix: 62365204
Test: visual
2017-06-29 14:46:09 -07:00
Fan Zhang
a29346bab8 Change the way we generate stable id for DashboardSummary
- The countItem() method generates id based on position of Tile. This is
not truely stable.
- Added stable id constants for static views, and use hash of title as
stable id for tiles.

Bug: 33861822
Test: robotests
Change-Id: Ibbc88c82655503dc3964cb0c430c779dc9c93d41
2017-06-29 14:21:43 -07:00