Commit Graph

2453 Commits

Author SHA1 Message Date
Roshan Pius
a5bd1cf34f settings(dev): Remove NFC stack logging control
We are now turning on verbose logging by default.

Bug: 327517842
Test: Compiles
Change-Id: I3c6026e230c7d35f04d9771442fadbf040a84b94
2024-02-29 09:44:37 -08:00
Kangping Dong
abd5f23fe9 Merge "[Thread] add Thread toggle in settings" into main am: 522e193947
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2909326

Change-Id: I8640f2cf4a90203972a5db703ebb3e027224c746
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-29 17:43:51 +00:00
Kangping Dong
5fc01ddd6e [Thread] add Thread toggle in settings
Allows a user to disable or enable Thread network / radio from
settings.

In this commit, a toggle is added to Settings > Connected devices >
Connection preferences to control Thread state. See the screenshots
below:
1. Thread is on: https://screenshot.googleplex.com/7FqqbzRX6rGwvSb
2. Thread is off: https://screenshot.googleplex.com/AmfRAhzuukULAAG
3. Thread is disabled by airplane mode: https://screenshot.googleplex.com/7zcesyomrveCqFE
4. Thread is searchable: https://screenshot.googleplex.com/9yFL2jeSuEhJwrS

Requirements:
1. the in-take bug: b/327098435
2. See the screenshot above
3. Test with `atest SettingsUnitTests` and manual tests
4. +2 from Yuwen
5. Flagged by "com.android.net.thread.platform.flags.Flags.thread_enabled_platform"
6. It doesn't need B&R, no preferences are added (the state is in
   Android framework (mainline module))
7. Confirmed searchable
8. Code written in Kotlin

Bug: 296990038
Bug: 319077562
Test: atest SettingsUnitTests
Change-Id: Ifa2264b8e59a5112290fd0224cb75ad228732077
2024-02-29 18:05:49 +08:00
Rafael Higuera Silva
be3a609c25 Merge "Add new dialogue when user is going to delete sim that use RAC." into main 2024-02-26 04:09:19 +00:00
Rafael Higuera Silva
736df6d2ef Add new dialogue when user is going to delete sim that use RAC.
Test: make
Bug: 316419093
Change-Id: Iaed54afa7cfd20c1dd6adbd4d50f54cab3da095d
2024-02-23 23:11:56 +00:00
Treehugger Robot
c76c7ac67f Merge "Adding FingerprintEnrollConfirmation" into main 2024-02-22 23:56:51 +00:00
Joshua McCloskey
0fe0f4d9ae Adding FingerprintEnrollConfirmation
Bug: 295217067
Test: atest FingerprintEnrollConfirmationScreenshotTest.kt
Test: adb shell device_config put biometrics_framework com.android.settings.flags.fingerprint_v2_enrollment true
Change-Id: I0b4995a97b7bccd35e26ed89bbbf14b80af4b0e1
2024-02-22 18:28:08 +00:00
Olivier Nshimiye
75ada354ed Merge "Add a toggle for enabling/disabling sensitive lockscreen notifications for Private Space" into main 2024-02-22 14:22:33 +00:00
Olivier Nshimiye
baecaee2a5 Add a toggle for enabling/disabling sensitive lockscreen notifications for Private Space
This adds a toggle in the Private Space Settings page to control the
lockscreen sensitive notifications for the private profile.
Sensitive notifications for private profile will still be disabled if
sensitive notifications are disabled for the main user.

Demo link:https://drive.google.com/file/d/1--LNXziTRTMvfdsJZAh90SiNiPxWNcI8/view?usp=sharing

Bug: 317067050
Test: atest SettingsUnitTests:HidePrivateSpaceSensitiveNotificationsControllerTest

Change-Id: Ie7f18c1a940e5ffd64112a01c48ac9dee58cb1ab
2024-02-22 11:10:54 +00:00
Wu Ahan
888d636cfa Merge "Refactor SfpsEnrollmentFeatureImplTest" into main 2024-02-22 02:14:30 +00:00
Joshua Mccloskey
5d6ed31261 Merge "Adding biometric FRR Notification atom." into main 2024-02-22 01:04:07 +00:00
Hani Kazmi
05427e6903 Merge changes from topics "ecm-manager", "ecm-tests" into main
* changes:
  Replace ECM AppOps call with service
  Wired remaining SpecialAppAccess for ECM.
2024-02-21 19:29:04 +00:00
Hani Kazmi
206300962f Replace ECM AppOps call with service
A new ECM service was introcuded in changeId
I831391e4437b51b3312b5273a2360bd029a3d8ee.

We begin calling it, and update/cleanup method signatures to match.

Note: There are two feature flags:

1. enhancedConfirmationModeApisEnabled - read only, protects the
   mainline API.

2. extendEcmToAllSettings - runtime - gates calls to the above APIs.

We use both so we can ramp up in teamfood as needed.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I945ec51df5cd63de548a8ffdd1acc4f09f2301e5
2024-02-21 14:43:02 +00:00
Yiyi Shen
a2577fd60e [Audiosharing] Impl audio sharing feature provider in Settings
Bug: 324023639
Test: manual
Change-Id: I4005ea8fbc0983a833f5a7dee2815f09eab48d3c
2024-02-20 08:06:55 +00:00
Wu Ahan
c7e3149a25 Refactor SfpsEnrollmentFeatureImplTest
Bug: 288155127
Test: atest SfpsEnrollmentFeatureImplTest
Change-Id: I2725e73ad595db752328bc5092ff4295f634c154
2024-02-19 14:49:26 +00:00
Zoey Chen
f322a43a57 [ToA] Add the metrics in Settings
Bug: 323462103
Test: manual + presubmit
Change-Id: Ic7ad80ed0829b11de4f8f7278149292d0cd80622
2024-02-17 07:39:28 +00:00
Becca Hughes
62fa76f719 Merge "Hide "additional services" if there is only a single primary services" into main 2024-02-15 23:54:59 +00:00
Joshua McCloskey
e5f62676c8 Adding biometric FRR Notification atom.
Test: statsd_testdrive 793
Test: statsd_testdrive 184
Test: m -j50 RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.biometrics
Test: atest FingerprintUpdaterTest FaceUpdaterTest
Bug: 302171089

Change-Id: I4c921b75321db79cc975b98b54b176a43379cd7c
2024-02-15 19:09:35 +00:00
Joshua Mccloskey
1c711222f9 Merge "Adding more biometric screenshot tests" into main 2024-02-15 17:17:51 +00:00
Hani Kazmi
96ab2b9e25 Wired remaining SpecialAppAccess for ECM.
This change enables the remaining settings for ECM, and adds tests for
both this and previous ECM changes.

Bug: 297372999
Test: Tested on device
Test: atest SpaPrivilegedLibTests
Test: atest com.android.settings.applications.specialaccess.notificationaccess
Test: atest com.android.settings.datausage
Test: atest PremiumSmsAccessTest
Test: atest RestrictedPreferenceHelperTest
Change-Id: I73d39d765dba0c1a75111c37b29ccf1c85d2cdd8
2024-02-15 15:15:23 +00:00
Becca Hughes
7046a96c9a Merge "Update "none selected" state to align with mocks:" into main 2024-02-13 20:15:18 +00:00
Becca Hughes
c627cdbdba Hide "additional services" if there is only a single primary services
There is a case where there is a single primary service (e.g.
a fresh device) and we should hide additional services in that
case.

Test: unit + manual
Bug: 325077523
Change-Id: I9efb785ac3f7a328fdccd138e585f766d46fa282
2024-02-13 19:06:07 +00:00
Joshua McCloskey
d92faeb1cf Adding more biometric screenshot tests
Test: atest FingerprintEnrollIntroScreenshotTest FingerprintEnrollFindSensorScreenshotTest FingerprintEnrollEnrollingScreenshotTest
Bug: 297083009
Change-Id: I11df6fbaefa9d333dcfe803577947a4be7af9882
2024-02-13 18:59:46 +00:00
Becca Hughes
5cbc60dcf3 Merge "Fix bug where maximum provider limit was not being reflected" into main 2024-02-13 18:52:59 +00:00
Chengfei Tao
d1618f94ff Merge "SettingsGoogle: Add ContextualScreenTimeout" into main 2024-02-13 01:44:06 +00:00
Becca Hughes
f368299931 Fix bug where maximum provider limit was not being reflected
The limit of 5 providers had two issues, one it did not
reserve one slot for primary which meant that you could
enable 6 and also even though it wouldn't save and would
show an error when you hit that limit the toggle was not
reset which made it look like it was enabled.

Test: on device + unit
Bug: 324426504
Change-Id: Ibec4efd6394835729869194181161fe8ae743e76
2024-02-12 23:45:35 +00:00
Becca Hughes
6cca4f32e6 Update "none selected" state to align with mocks:
Mocks:
https://screenshot.googleplex.com/BYsmSRcRL5dhjve

Implementation:
https://hsv.googleplex.com/4797150908121088

Change-Id: I47e8f784fa850da4271170d44b3eb770721c3e8b
Test: on device & unit
Bug: 322074376
2024-02-12 23:29:27 +00:00
chengfeitao
ffb6e7e21b SettingsGoogle: Add ContextualScreenTimeout
Store contextual screen timeout preference when the
corresponding switch is toggled.

Bug: 295232527

Test: atest ExternalSettingsProviderTest
Test: atest ContextualTimeoutPreferenceControllerTest
Change-Id: I093d180f4b11ebb806c4b1949ff5428520c8f40f
2024-02-12 23:14:40 +00:00
Ronish Kalia
902abe911d Merge "[DON'T BLOCK] Test ownership migration rules" into main 2024-02-12 19:30:40 +00:00
Joshua Mccloskey
f06d5cf975 Merge "Updating navigation view model" into main 2024-02-12 18:39:56 +00:00
Ravneet Dhanjal
50edf6755d Merge "Add camera extension fallback toggle" into main 2024-02-09 19:26:12 +00:00
Aditya Choudhary
01735e6b40 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
Change-Id: I7fbd55a92f4302a6e03bcff0283737fd9295165d
Merged-In: I7fbd55a92f4302a6e03bcff0283737fd9295165d
2024-02-09 17:45:41 +00:00
Aditya Choudhary
4f5c1ac5bc [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3f65505208d57fa18be353f815c44fdd6f004f4b)
Merged-In: I7fbd55a92f4302a6e03bcff0283737fd9295165d
Change-Id: I7fbd55a92f4302a6e03bcff0283737fd9295165d
2024-02-09 16:54:41 +00:00
Aditya Choudhary
3f65505208 [DON'T BLOCK] Test ownership migration rules
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.

For more details please refer to the link below,
go/new-android-ownership-model

Bug: 304529413
Test: N/A
Change-Id: I7fbd55a92f4302a6e03bcff0283737fd9295165d
2024-02-09 16:14:48 +00:00
Emilian Peev
1a56189eca Add camera extension fallback toggle
Android camera extensions
(https://source.android.com/docs/core/camera/camerax-vendor-extensions)
will be able to use SW fallback implementations
on devices that do not ship the corresponding
the device specific functionality.
Since the SW fallback will be using a new data
path, it was suggested that users must be able to
control and enable/disable the SW fallback
via the Settings app.

Bug: 297083874
Test: atest packages/apps/Settings/tests/unit/src/com/android/settings/privacy/CameraExtensionsFallbackPreferenceControllerTest.java

Change-Id: I1b97777babe1c9f4ea4f2f6ee3d8251fea11146e
2024-02-09 00:07:05 +00:00
Elliot Sisteron
185542bd96 Enable Safety Center & Security unit tests on presubmit.
See b/323650746 and b/323649900 for issues that should’ve been caught by pre-submit.

Bug: 323649900
Bug: 323650746
Change-Id: I77d664b6fce6a3f76a4c9a6b39202f6e9d47da33
Test: atest SettingsUnitTests
2024-02-08 16:08:40 +00:00
Joshua McCloskey
98374376cc Updating navigation view model
Test: atest com.android.settings.fingerprint2.ui.enrollment.modules.enrolling.rfps.viewmodel
com.android.settings.fingerprint2.ui.enrollment.viewmodel
com.android.settings.fingerprint2.ui.settings
com.android.settings.fingerprint2.domain.interactor
com.android.settings.fingerprint2.enrollment.viewmodel
Bug: 295205754

Change-Id: I210712ab76050b89452fb871cd2a4fb28bfd4012
2024-02-07 18:33:52 +00:00
Matías Hernández
67484c2791 Merge "Fix cast of RestrictedSwitchPreference to SwitchPreference" into main 2024-02-07 11:00:03 +00:00
Zoey Chen
6368895adf Merge "[ToA] Metrics in Settings" into main 2024-02-07 08:07:13 +00:00
Wu Ahan
3bea5fcc98 Merge "Increase test coverage for fps pause enrollment feature" into main 2024-02-07 07:28:54 +00:00
Zoey Chen
7dc497dfcc [ToA] Metrics in Settings
Bug: 323462103
Test: atest TermsOfAddressNotSpecifiedControllerTest
Test: atest TermsOfAddressNeutralControllerTest
Test: atest TermsOfAddressMasculineControllerTest
Test: atest TermsOfAddressFeminineControllerTest
Change-Id: I09c3ad4c92275ba48b810b1971a4e98e54e5136d
2024-02-07 05:46:16 +00:00
Becca Hughes
3aa7212b26 Merge "Fix enterprise settings bug" into main 2024-02-06 22:35:07 +00:00
Wu Ahan
5e577c03e5 Increase test coverage for fps pause enrollment feature
Bug: 288155127
Test: atest SfpsEnrollmentFeatureImplTest
Change-Id: I1a067d78262daf4903dd7a8b8c60b582c0945719
2024-02-06 15:15:15 +00:00
Becca Hughes
401ebcb53d Fix enterprise settings bug
This fixes a bug where the picker
is not using the correct user id
and also ensures that the settings
activity uses the correct user when
launched.

Test: flash & test w/ work profile
Bug 322071206

Change-Id: I846593ff9ae320d9bb774e3e79ed9ef41f101ff5
2024-02-05 10:58:09 -08:00
Elliot Sisteron
8d89dbc5ae Merge "Fix tests for SecurityAdvancedSettings." into main 2024-02-05 16:59:23 +00:00
Elliot Sisteron
5418e292c9 Fix tests for SecurityAdvancedSettings.
It seems these tests have been failing for a while (probably they were never passing in the first place; as the issue appears to be with the tests and not the prod code).

Are they not being run on pre and/or post-submit?

Bug: 323650746
Change-Id: I97db7183898930792d1ff0d2de592f26f8b78b01
Test: atest SecurityAdvancedSettingsTest
2024-02-05 12:58:30 +00:00
Elliot Sisteron
f26e541e86 Fix tests for BiometricsSafetySource and LockScreenSafetySource.
It seems these tests have been failing for a while (probably they were never passing in the first place; as the issue appears to be with the tests and not the prod code).

Are they not being run on pre and/or post-submit?

Bug: 323649900
Test: atest LockScreenSafetySourceTest && atest BiometricsSafetySourceTest
Change-Id: Ie75241455317da6749ccf648dae71c49ea9f766f
2024-02-05 11:56:53 +00:00
Matías Hernández
41367eab25 Fix cast of RestrictedSwitchPreference to SwitchPreference
The class was changed to extend SwitchPreferenceCompat instead in ag/25160408.

Fix: 323649099
Test: atest ChannelListPreferenceControllerTest
Change-Id: I0d9fd82d0087dd11eb7c3d6c6912788725b18b43
2024-02-05 12:28:42 +01:00
Becca Hughes
d8a82105e0 Merge "Fix settings flakiness bug" into main 2024-02-03 00:15:57 +00:00
Becca Hughes
7df4f0f4bd Fix settings flakiness bug
The flakiness was caused by mVisibility
being out of sync and resulting in the
preference being hidden / shown incorrectly.

Test: manual & unit tests
Bug: 322072349
Change-Id: I588da2100b8f2cea38f2bdb63af4e8d19d0efd0b
2024-02-02 22:43:30 +00:00