From fdf7220a03b6e823807b3786b727a9be598d01b5 Mon Sep 17 00:00:00 2001 From: Vasu Nori Date: Mon, 17 Jan 2011 13:50:18 -0800 Subject: [PATCH] bug:3308791 appusage should include space used on /sdcard when "application usage" is clicked on, drop the screen into Settings --> Applications --> Manage Applications (all tab, sorted by size) Change-Id: I64e11ae9a92529b5fb2781941e532951ad3d04c1 --- src/com/android/settings/deviceinfo/Memory.java | 8 +++++++- .../android/settings/deviceinfo/MemoryMeasurement.java | 8 +++++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/com/android/settings/deviceinfo/Memory.java b/src/com/android/settings/deviceinfo/Memory.java index c2a51b041a2..1860d6d3388 100644 --- a/src/com/android/settings/deviceinfo/Memory.java +++ b/src/com/android/settings/deviceinfo/Memory.java @@ -57,7 +57,7 @@ import java.util.List; public class Memory extends SettingsPreferenceFragment implements OnCancelListener, MeasurementReceiver { private static final String TAG = "Memory"; - private static final boolean localLOGV = false; + static final boolean localLOGV = false; private static final String MEMORY_SD_SIZE = "memory_sd_size"; @@ -278,6 +278,12 @@ public class Memory extends SettingsPreferenceFragment implements OnCancelListen intent.setClass(getActivity(), com.android.settings.MediaFormat.class); startActivity(intent); return true; + } else if (preference == mInternalAppsUsage) { + Intent intent = new Intent(Intent.ACTION_MANAGE_PACKAGE_STORAGE); + intent.setClass(getActivity(), + com.android.settings.Settings.ManageApplicationsActivity.class); + startActivity(intent); + return true; } return false; diff --git a/src/com/android/settings/deviceinfo/MemoryMeasurement.java b/src/com/android/settings/deviceinfo/MemoryMeasurement.java index 19bd78422ea..1aef20234d2 100644 --- a/src/com/android/settings/deviceinfo/MemoryMeasurement.java +++ b/src/com/android/settings/deviceinfo/MemoryMeasurement.java @@ -307,7 +307,9 @@ public class MemoryMeasurement { return; } if (succeeded) { - mAppsSizeForThisStatsObserver += stats.codeSize + stats.dataSize; + mAppsSizeForThisStatsObserver += stats.codeSize + stats.dataSize + + stats.externalCacheSize + stats.externalDataSize + + stats.externalMediaSize + stats.externalObbSize; } synchronized (mAppsList) { @@ -363,8 +365,8 @@ public class MemoryMeasurement { long mediaSize; try { - // TODO get these directories from somewhere - mediaSize = imcs.calculateDirectorySize("/data/media"); + mediaSize = imcs.calculateDirectorySize( + Environment.getExternalStorageDirectory().getAbsolutePath()); } catch (Exception e) { Log.i(TAG, "Could not read memory from default container service"); return;