Fix crash in Monkey test.
When battery page is launched, BatteryTipLoader will start running. If we rotate the screen before loader is finished, it will store null to Bundle and will crash when restoring from that Bundle. In this cl, we add null pointer check for tip list to avoid the crash. Also remove a TODO since it is obsolete. Change-Id: Ic59bc20c633f3a7467f7b5e95da062160bcb4e93 Fixes: 77534165 Test: RunSettingsRoboTests
This commit is contained in:
@@ -91,6 +91,9 @@ public class BatteryTipPreferenceController extends BasePreferenceController {
|
||||
}
|
||||
|
||||
public void updateBatteryTips(List<BatteryTip> batteryTips) {
|
||||
if (batteryTips == null) {
|
||||
return;
|
||||
}
|
||||
if (mBatteryTips == null) {
|
||||
mBatteryTips = batteryTips;
|
||||
} else {
|
||||
@@ -100,7 +103,6 @@ public class BatteryTipPreferenceController extends BasePreferenceController {
|
||||
}
|
||||
}
|
||||
|
||||
//TODO(b/70570352): try to reuse the existing preference rather than remove and add.
|
||||
mPreferenceGroup.removeAll();
|
||||
for (int i = 0, size = batteryTips.size(); i < size; i++) {
|
||||
final BatteryTip batteryTip = mBatteryTips.get(i);
|
||||
|
Reference in New Issue
Block a user