Merge "Fix UserDetailsSettingsTest for mAppCopyingPref"

This commit is contained in:
Adam Bookatz
2022-02-03 22:36:12 +00:00
committed by Android (Google) Code Review

View File

@@ -62,7 +62,6 @@ import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
@@ -89,6 +88,7 @@ public class UserDetailsSettingsTest {
private static final String KEY_ENABLE_TELEPHONY = "enable_calling"; private static final String KEY_ENABLE_TELEPHONY = "enable_calling";
private static final String KEY_REMOVE_USER = "remove_user"; private static final String KEY_REMOVE_USER = "remove_user";
private static final String KEY_APP_AND_CONTENT_ACCESS = "app_and_content_access"; private static final String KEY_APP_AND_CONTENT_ACCESS = "app_and_content_access";
private static final String KEY_APP_COPYING = "app_copying";
private static final int DIALOG_CONFIRM_REMOVE = 1; private static final int DIALOG_CONFIRM_REMOVE = 1;
@@ -105,6 +105,8 @@ public class UserDetailsSettingsTest {
private Preference mRemoveUserPref; private Preference mRemoveUserPref;
@Mock @Mock
private Preference mAppAndContentAccessPref; private Preference mAppAndContentAccessPref;
@Mock
private Preference mAppCopyingPref;
private FragmentActivity mActivity; private FragmentActivity mActivity;
private Context mContext; private Context mContext;
@@ -145,6 +147,7 @@ public class UserDetailsSettingsTest {
doReturn(mRemoveUserPref).when(mFragment).findPreference(KEY_REMOVE_USER); doReturn(mRemoveUserPref).when(mFragment).findPreference(KEY_REMOVE_USER);
doReturn(mAppAndContentAccessPref) doReturn(mAppAndContentAccessPref)
.when(mFragment).findPreference(KEY_APP_AND_CONTENT_ACCESS); .when(mFragment).findPreference(KEY_APP_AND_CONTENT_ACCESS);
doReturn(mAppCopyingPref).when(mFragment).findPreference(KEY_APP_COPYING);
} }
@After @After
@@ -163,7 +166,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_userSelected_shouldSetupSwitchPref() { public void initialize_userSelected_shouldSetupSwitchPref() {
setupSelectedUser(); setupSelectedUser();
doReturn("Switch to " + mUserInfo.name) doReturn("Switch to " + mUserInfo.name)
@@ -179,7 +181,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_guestSelected_shouldSetupSwitchPref() { public void initialize_guestSelected_shouldSetupSwitchPref() {
setupSelectedGuest(); setupSelectedGuest();
doReturn("Switch to " + mUserInfo.name) doReturn("Switch to " + mUserInfo.name)
@@ -195,7 +196,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_userSelected_shouldNotShowAppAndContentPref() { public void initialize_userSelected_shouldNotShowAppAndContentPref() {
setupSelectedUser(); setupSelectedUser();
@@ -205,7 +205,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_guestSelected_shouldNotShowAppAndContentPref() { public void initialize_guestSelected_shouldNotShowAppAndContentPref() {
setupSelectedGuest(); setupSelectedGuest();
@@ -259,7 +258,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminWithTelephony_shouldShowPhonePreference() { public void initialize_adminWithTelephony_shouldShowPhonePreference() {
setupSelectedUser(); setupSelectedUser();
doReturn(true).when(mTelephonyManager).isVoiceCapable(); doReturn(true).when(mTelephonyManager).isVoiceCapable();
@@ -272,7 +270,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminNoTelephony_shouldNotShowPhonePreference() { public void initialize_adminNoTelephony_shouldNotShowPhonePreference() {
setupSelectedUser(); setupSelectedUser();
doReturn(false).when(mTelephonyManager).isVoiceCapable(); doReturn(false).when(mTelephonyManager).isVoiceCapable();
@@ -306,7 +303,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminSelectsSecondaryUser_shouldShowRemovePreference() { public void initialize_adminSelectsSecondaryUser_shouldShowRemovePreference() {
setupSelectedUser(); setupSelectedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -319,7 +315,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminSelectsNewRestrictedUser_shouldOpenAppContentScreen() { public void initialize_adminSelectsNewRestrictedUser_shouldOpenAppContentScreen() {
setupSelectedRestrictedUser(); setupSelectedRestrictedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -342,7 +337,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminSelectsRestrictedUser_shouldSetupPreferences() { public void initialize_adminSelectsRestrictedUser_shouldSetupPreferences() {
setupSelectedRestrictedUser(); setupSelectedRestrictedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -361,7 +355,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminSelectsExistingRestrictedUser_shouldNotStartAppAndContentAccess() { public void initialize_adminSelectsExistingRestrictedUser_shouldNotStartAppAndContentAccess() {
setupSelectedRestrictedUser(); setupSelectedRestrictedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -373,7 +366,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_adminSelectsGuest_shouldShowRemovePreference() { public void initialize_adminSelectsGuest_shouldShowRemovePreference() {
setupSelectedGuest(); setupSelectedGuest();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -396,7 +388,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_disallowRemoveUserRestriction_shouldNotShowRemovePreference() { public void initialize_disallowRemoveUserRestriction_shouldNotShowRemovePreference() {
setupSelectedUser(); setupSelectedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -408,7 +399,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_userHasCallRestriction_shouldSetPhoneSwitchUnChecked() { public void initialize_userHasCallRestriction_shouldSetPhoneSwitchUnChecked() {
setupSelectedUser(); setupSelectedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -421,7 +411,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_noCallRestriction_shouldSetPhoneSwitchChecked() { public void initialize_noCallRestriction_shouldSetPhoneSwitchChecked() {
setupSelectedUser(); setupSelectedUser();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -432,7 +421,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_guestSelected_noCallRestriction_shouldSetPhonePreference() { public void initialize_guestSelected_noCallRestriction_shouldSetPhonePreference() {
setupSelectedGuest(); setupSelectedGuest();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -444,7 +432,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_guestSelected_callRestriction_shouldSetPhonePreference() { public void initialize_guestSelected_callRestriction_shouldSetPhonePreference() {
setupSelectedGuest(); setupSelectedGuest();
mUserManager.setIsAdminUser(true); mUserManager.setIsAdminUser(true);
@@ -457,7 +444,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_switchUserDisallowed_shouldSetAdminDisabledOnSwitchPreference() { public void initialize_switchUserDisallowed_shouldSetAdminDisabledOnSwitchPreference() {
setupSelectedUser(); setupSelectedUser();
mUserCapabilities.mDisallowSwitchUser = true; mUserCapabilities.mDisallowSwitchUser = true;
@@ -473,7 +459,6 @@ public class UserDetailsSettingsTest {
} }
@Test @Test
@Ignore
public void initialize_switchUserAllowed_shouldSetSwitchPreferenceEnabled() { public void initialize_switchUserAllowed_shouldSetSwitchPreferenceEnabled() {
setupSelectedUser(); setupSelectedUser();
mUserCapabilities.mDisallowSwitchUser = false; mUserCapabilities.mDisallowSwitchUser = false;