PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update colors

Browse Source 
For night mode and a11y

Test: manual
Fixes: 129507563
Change-Id: Ic675cbe0aaf0ccbb18d57729c26b5b55ca907910
This commit is contained in:
Julia Reynolds
2019-05-02 17:36:40 -04:00
parent 27e0c844ae
commit fc5f111bb9
5 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
color-check-baseline.xml
View File

@@ -3373,4 +3373,20 @@
column="10"/> column="10"/>
</issue> </issue>
<issue
id="HardCodedColor"
severity="Error"
message="Avoid using hardcoded color"
category="Correctness"
priority="4"
summary="Using hardcoded color"
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.&#xA;This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
errorLine1=" android:color=&quot;@color/notification_importance_selection_bg&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="res/drawable/button_border_selected.xml"
line="21"
column="10"/>
</issue>
</issues> </issues>

4
res/drawable/button_border_selected.xml
View File

@@ -16,8 +16,10 @@
--> -->
<shape xmlns:android="http://schemas.android.com/apk/res/android" <shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="rectangle"> android:shape="rectangle">
<solid
android:color="@color/notification_importance_selection_bg" />
<stroke <stroke
android:width="2dp" android:width="1dp"
android:color="?android:attr/textColorSecondary"/> android:color="?android:attr/textColorSecondary"/>
<corners android:radius="@dimen/rect_button_radius" /> <corners android:radius="@dimen/rect_button_radius" />
</shape> </shape>

2
res/drawable/button_border_unselected.xml
View File

@@ -17,7 +17,7 @@
<shape xmlns:android="http://schemas.android.com/apk/res/android" <shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="rectangle"> android:shape="rectangle">
<stroke <stroke
android:width="2dp" android:width="1dp"
android:color="?android:attr/textColorSecondary"/> android:color="?android:attr/textColorSecondary"/>
<corners android:radius="@dimen/rect_button_radius" /> <corners android:radius="@dimen/rect_button_radius" />

1
res/values-night/colors.xml
View File

@@ -26,5 +26,6 @@
<color name="search_bar_background">@*android:color/material_grey_800</color> <color name="search_bar_background">@*android:color/material_grey_800</color>
<!-- Dialog background color --> <!-- Dialog background color -->
<color name="dialog_background">@*android:color/material_grey_800</color> <color name="dialog_background">@*android:color/material_grey_800</color>
<color name="notification_importance_selection_bg">@*android:color/material_grey_800</color>
</resources> </resources>

1
res/values/colors.xml
View File

@@ -127,6 +127,7 @@
<color name="notification_silence_color">#FF32c1de</color> <color name="notification_silence_color">#FF32c1de</color>
<color name="notification_alert_color">#FFF87B2B</color> <color name="notification_alert_color">#FFF87B2B</color>
<color name="notification_importance_button_unselected">#FFDADCE0</color> <color name="notification_importance_button_unselected">#FFDADCE0</color>
<color name="notification_importance_selection_bg">#FFFFFF</color>
<!-- launcher icon color --> <!-- launcher icon color -->
<color name="icon_launcher_setting_color">@*android:color/accent_device_default_light</color> <color name="icon_launcher_setting_color">@*android:color/accent_device_default_light</color>