diff --git a/src/com/android/settings/network/telephony/MobileDataPreferenceController.java b/src/com/android/settings/network/telephony/MobileDataPreferenceController.java index 4b6a72851e6..31b8138db2c 100644 --- a/src/com/android/settings/network/telephony/MobileDataPreferenceController.java +++ b/src/com/android/settings/network/telephony/MobileDataPreferenceController.java @@ -25,10 +25,10 @@ import android.telephony.TelephonyManager; import android.text.TextUtils; import androidx.annotation.VisibleForTesting; +import androidx.fragment.app.FragmentManager; import androidx.lifecycle.LifecycleObserver; import androidx.lifecycle.LifecycleOwner; import androidx.lifecycle.OnLifecycleEvent; -import androidx.fragment.app.FragmentManager; import androidx.preference.Preference; import androidx.preference.PreferenceScreen; import androidx.preference.SwitchPreference; @@ -232,13 +232,12 @@ public class MobileDataPreferenceController extends TelephonyTogglePreferenceCon mSubscriptionInfoEntityList.forEach(entity -> { if (entity.getSubId() == mSubId) { mSubscriptionInfoEntity = entity; + if (entity.getSubId() == SubscriptionManager.getDefaultDataSubscriptionId()) { + mDefaultSubId = entity.getSubId(); + } } }); - int subId = mSubscriptionInfoEntity.getSubId(); - if (mSubscriptionInfoEntity != null - && subId == SubscriptionManager.getDefaultDataSubscriptionId()) { - mDefaultSubId = subId; - } + update(); refreshSummary(mPreference); } diff --git a/tests/unit/src/com/android/settings/network/telephony/MobileDataPreferenceControllerTest.java b/tests/unit/src/com/android/settings/network/telephony/MobileDataPreferenceControllerTest.java index 03733960f1a..4d480253306 100644 --- a/tests/unit/src/com/android/settings/network/telephony/MobileDataPreferenceControllerTest.java +++ b/tests/unit/src/com/android/settings/network/telephony/MobileDataPreferenceControllerTest.java @@ -20,7 +20,6 @@ import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEA import static com.google.common.truth.Truth.assertThat; -import static org.mockito.Matchers.anyInt; import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.verify;