Add Open button to launch instant app.
- move logic from InstantAppButtonsController into InstantAppButtonsPreferenceController, as it is not really necessary to have separate control to be in different class. - add logic to check if the instant app provides a default launch uri. If so, show a Open button to launch the uri, and move the Install button into option menu. If not, Install button remains as is. - also update the instant app button layout to match the regular 2 buttons layout. Change-Id: Ibcae780ad697ca93a48604b03c8f4600dd3c0472 Fixes: 69562807 Test: make RunSettingsRoboTests
This commit is contained in:
Doris Ling
@@ -18,30 +18,62 @@ package com.android.settings.applications.appinfo;
|
||||
|
||||
import android.app.AlertDialog;
|
||||
import android.content.Context;
|
||||
import android.content.DialogInterface;
|
||||
import android.content.Intent;
|
||||
import android.content.pm.PackageManager;
|
||||
import android.content.pm.ResolveInfo;
|
||||
import android.net.Uri;
|
||||
import android.os.Bundle;
|
||||
import android.os.UserHandle;
|
||||
import android.support.annotation.VisibleForTesting;
|
||||
import android.support.v7.preference.PreferenceScreen;
|
||||
import android.text.TextUtils;
|
||||
import android.view.Menu;
|
||||
import android.view.MenuInflater;
|
||||
import android.view.MenuItem;
|
||||
import android.view.View;
|
||||
import android.widget.Button;
|
||||
|
||||
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.applications.ApplicationFeatureProvider;
|
||||
import com.android.settings.applications.AppStoreUtil;
|
||||
import com.android.settings.applications.LayoutPreference;
|
||||
import com.android.settings.applications.instantapps.InstantAppButtonsController;
|
||||
import com.android.settings.core.BasePreferenceController;
|
||||
import com.android.settings.overlay.FeatureFactory;
|
||||
import com.android.settingslib.applications.AppUtils;
|
||||
import com.android.settingslib.core.lifecycle.Lifecycle;
|
||||
import com.android.settingslib.core.lifecycle.LifecycleObserver;
|
||||
import com.android.settingslib.core.lifecycle.events.OnCreateOptionsMenu;
|
||||
import com.android.settingslib.core.lifecycle.events.OnOptionsItemSelected;
|
||||
import com.android.settingslib.core.lifecycle.events.OnPrepareOptionsMenu;
|
||||
import com.android.settingslib.wrapper.PackageManagerWrapper;
|
||||
|
||||
public class InstantAppButtonsPreferenceController extends BasePreferenceController {
|
||||
import java.util.List;
|
||||
|
||||
public class InstantAppButtonsPreferenceController extends BasePreferenceController implements
|
||||
LifecycleObserver, OnCreateOptionsMenu, OnPrepareOptionsMenu, OnOptionsItemSelected,
|
||||
DialogInterface.OnClickListener {
|
||||
|
||||
private static final String KEY_INSTANT_APP_BUTTONS = "instant_app_buttons";
|
||||
private static final String META_DATA_DEFAULT_URI = "default-url";
|
||||
|
||||
private final AppInfoDashboardFragment mParent;
|
||||
private final String mPackageName;
|
||||
private InstantAppButtonsController mInstantAppButtonsController;
|
||||
private final PackageManagerWrapper mPackageManagerWrapper;
|
||||
private String mLaunchUri;
|
||||
private LayoutPreference mPreference;
|
||||
private MenuItem mInstallMenu;
|
||||
|
||||
public InstantAppButtonsPreferenceController(Context context, AppInfoDashboardFragment parent,
|
||||
String packageName) {
|
||||
String packageName, Lifecycle lifecycle) {
|
||||
super(context, KEY_INSTANT_APP_BUTTONS);
|
||||
mParent = parent;
|
||||
mPackageName = packageName;
|
||||
mPackageManagerWrapper = new PackageManagerWrapper(context.getPackageManager());
|
||||
mLaunchUri = getDefaultLaunchUri();
|
||||
if (lifecycle != null) {
|
||||
lifecycle.addObserver(this);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -53,22 +85,98 @@ public class InstantAppButtonsPreferenceController extends BasePreferenceControl
|
||||
@Override
|
||||
public void displayPreference(PreferenceScreen screen) {
|
||||
super.displayPreference(screen);
|
||||
LayoutPreference buttons =
|
||||
(LayoutPreference) screen.findPreference(KEY_INSTANT_APP_BUTTONS);
|
||||
mInstantAppButtonsController = getApplicationFeatureProvider()
|
||||
.newInstantAppButtonsController(mParent,
|
||||
buttons.findViewById(R.id.instant_app_button_container),
|
||||
id -> mParent.showDialogInner(id, 0))
|
||||
.setPackageName(mPackageName)
|
||||
.show();
|
||||
mPreference = (LayoutPreference) screen.findPreference(KEY_INSTANT_APP_BUTTONS);
|
||||
initButtons(mPreference.findViewById(R.id.instant_app_button_container));
|
||||
}
|
||||
|
||||
public AlertDialog createDialog(int id) {
|
||||
return mInstantAppButtonsController.createDialog(id);
|
||||
@Override
|
||||
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
|
||||
if (!TextUtils.isEmpty(mLaunchUri)) {
|
||||
menu.add(0, AppInfoDashboardFragment.INSTALL_INSTANT_APP_MENU, 2, R.string.install_text)
|
||||
.setShowAsAction(MenuItem.SHOW_AS_ACTION_NEVER);
|
||||
}
|
||||
}
|
||||
|
||||
@VisibleForTesting
|
||||
ApplicationFeatureProvider getApplicationFeatureProvider() {
|
||||
return FeatureFactory.getFactory(mContext).getApplicationFeatureProvider(mContext);
|
||||
@Override
|
||||
public boolean onOptionsItemSelected(MenuItem menuItem) {
|
||||
if (menuItem.getItemId() == AppInfoDashboardFragment.INSTALL_INSTANT_APP_MENU) {
|
||||
final Intent appStoreIntent = AppStoreUtil.getAppStoreLink(mContext, mPackageName);
|
||||
if (appStoreIntent != null) {
|
||||
mParent.startActivity(appStoreIntent);
|
||||
}
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onPrepareOptionsMenu(Menu menu) {
|
||||
mInstallMenu = menu.findItem(AppInfoDashboardFragment.INSTALL_INSTANT_APP_MENU);
|
||||
final Intent appStoreIntent = AppStoreUtil.getAppStoreLink(mContext, mPackageName);
|
||||
if (appStoreIntent == null) {
|
||||
mInstallMenu.setEnabled(false);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onClick(DialogInterface dialog, int which) {
|
||||
FeatureFactory.getFactory(mContext).getMetricsFeatureProvider()
|
||||
.action(mContext, MetricsEvent.ACTION_SETTINGS_CLEAR_INSTANT_APP, mPackageName);
|
||||
mPackageManagerWrapper.deletePackageAsUser(
|
||||
mPackageName, null, 0, UserHandle.myUserId());
|
||||
}
|
||||
|
||||
AlertDialog createDialog(int id) {
|
||||
if (id == AppInfoDashboardFragment.DLG_CLEAR_INSTANT_APP) {
|
||||
AlertDialog confirmDialog = new AlertDialog.Builder(mContext)
|
||||
.setPositiveButton(R.string.clear_instant_app_data, this)
|
||||
.setNegativeButton(R.string.cancel, null)
|
||||
.setTitle(R.string.clear_instant_app_data)
|
||||
.setMessage(mContext.getString(R.string.clear_instant_app_confirmation))
|
||||
.create();
|
||||
return confirmDialog;
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
private void initButtons(View view) {
|
||||
final Button installButton = view.findViewById(R.id.install);
|
||||
final Button clearDataButton = view.findViewById(R.id.clear_data);
|
||||
final Button launchButton = view.findViewById(R.id.launch);
|
||||
if (!TextUtils.isEmpty(mLaunchUri)) {
|
||||
installButton.setVisibility(View.GONE);
|
||||
final Intent intent = new Intent(Intent.ACTION_VIEW);
|
||||
intent.setData(Uri.parse(mLaunchUri));
|
||||
launchButton.setOnClickListener(v -> mParent.startActivity(intent));
|
||||
} else {
|
||||
launchButton.setVisibility(View.GONE);
|
||||
final Intent appStoreIntent = AppStoreUtil.getAppStoreLink(mContext, mPackageName);
|
||||
if (appStoreIntent != null) {
|
||||
installButton.setOnClickListener(v -> mParent.startActivity(appStoreIntent));
|
||||
} else {
|
||||
installButton.setEnabled(false);
|
||||
}
|
||||
}
|
||||
clearDataButton.setOnClickListener(
|
||||
v -> mParent.showDialogInner(mParent.DLG_CLEAR_INSTANT_APP, 0));
|
||||
}
|
||||
|
||||
private String getDefaultLaunchUri() {
|
||||
final PackageManager manager = mContext.getPackageManager();
|
||||
final Intent intent = new Intent(Intent.ACTION_MAIN);
|
||||
intent.addCategory(Intent.CATEGORY_LAUNCHER);
|
||||
intent.setPackage(mPackageName);
|
||||
final List<ResolveInfo> infos = manager.queryIntentActivities(
|
||||
intent, PackageManager.GET_META_DATA | PackageManager.MATCH_INSTANT);
|
||||
for (ResolveInfo info : infos) {
|
||||
final Bundle metaData = info.activityInfo.metaData;
|
||||
if (metaData != null) {
|
||||
final String launchUri = metaData.getString(META_DATA_DEFAULT_URI);
|
||||
if (!TextUtils.isEmpty(launchUri)) {
|
||||
return launchUri;
|
||||
}
|
||||
}
|
||||
}
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user