PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash when trying to open app info page

Browse Source 
Fixed a crash in App info page that happens when
no work profile exists, also fixed some unit tests.

Fixes: 152933121
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=InteractAcrossProfilesDetailsTest
Change-Id: I7a1e5857cb1e10b96b33abd64359ba30459b1b13
This commit is contained in:
kholoud mohamed
2020-04-01 12:20:10 +01:00
committed by Kholoud Mohamed
parent 0d3732a595
commit f9a03cd415
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/applications/specialaccess/interactacrossprofiles/InteractAcrossProfilesDetails.java
View File

@@ -240,6 +240,9 @@ public class InteractAcrossProfilesDetails extends AppInfoBase
Context context, String packageName) { Context context, String packageName) {
UserManager userManager = context.getSystemService(UserManager.class); UserManager userManager = context.getSystemService(UserManager.class);
UserHandle workProfile = InteractAcrossProfilesSettings.getWorkProfile(userManager); UserHandle workProfile = InteractAcrossProfilesSettings.getWorkProfile(userManager);
if (workProfile == null) {
return false;
}
UserHandle personalProfile = userManager.getProfileParent(workProfile); UserHandle personalProfile = userManager.getProfileParent(workProfile);
return context.getSystemService( return context.getSystemService(
CrossProfileApps.class).canConfigureInteractAcrossProfiles(packageName) CrossProfileApps.class).canConfigureInteractAcrossProfiles(packageName)

18
tests/robotests/src/com/android/settings/applications/specialaccess/interactacrossprofiles/InteractAcrossProfilesDetailsTest.java
View File

@@ -75,7 +75,7 @@ public class InteractAcrossProfilesDetailsTest {
assertThat(InteractAcrossProfilesDetails.getPreferenceSummary( assertThat(InteractAcrossProfilesDetails.getPreferenceSummary(
mContext, CROSS_PROFILE_PACKAGE_NAME)) mContext, CROSS_PROFILE_PACKAGE_NAME))
.isEqualTo(mContext.getString(R.string.app_permission_summary_allowed)); .isEqualTo(mContext.getString(R.string.interact_across_profiles_summary_allowed));
} }
@Test @Test
@@ -98,7 +98,21 @@ public class InteractAcrossProfilesDetailsTest {
assertThat(InteractAcrossProfilesDetails.getPreferenceSummary( assertThat(InteractAcrossProfilesDetails.getPreferenceSummary(
mContext, CROSS_PROFILE_PACKAGE_NAME)) mContext, CROSS_PROFILE_PACKAGE_NAME))
.isEqualTo(mContext.getString(R.string.app_permission_summary_not_allowed)); .isEqualTo(mContext.getString(
R.string.interact_across_profiles_summary_not_allowed));
}
@Test
public void getPreferenceSummary_noWorkProfile_returnsNotAllowed() {
shadowOf(mUserManager).addUser(
PERSONAL_PROFILE_ID, "personal-profile"/* name */, 0/* flags */);
shadowOf(mPackageManager).setInstalledPackagesForUserId(
PERSONAL_PROFILE_ID, ImmutableList.of(CROSS_PROFILE_PACKAGE_NAME));
assertThat(InteractAcrossProfilesDetails.getPreferenceSummary(
mContext, CROSS_PROFILE_PACKAGE_NAME))
.isEqualTo(mContext.getString(
R.string.interact_across_profiles_summary_not_allowed));
} }
private PermissionInfo createCrossProfilesPermissionInfo() { private PermissionInfo createCrossProfilesPermissionInfo() {