From f94932801adc369ffeeea24a963a48c3504271fb Mon Sep 17 00:00:00 2001 From: Milton Wu Date: Wed, 28 Jun 2023 21:51:53 +0800 Subject: [PATCH] [BiometricsV2] Add retry button Add retry button for FingerprintEnrollErrorDialog and make sure that this button works well in the whole enrollment flow. Bug: 287168522 Test: manually test this dialog with error and rotate devices Test: atest FingerprintEnrollEnrollingViewModelTest Test: atest FingerprintEnrollErrorDialogViewModelTest Test: atest FingerprintEnrollProgressViewModelTest Test: atest FingerprintEnrollmentActivityTest Test: atest biometrics-enrollment-test Change-Id: Ica1d91d077ca322caca5551068f2a3c23b544361 --- Android.bp | 1 + res/layout/udfps_enroll_enrolling_v2.xml | 20 +- .../udfps_enroll_enrolling_v2_udfps_view.xml | 36 +++ .../factory/BiometricsViewModelFactory.java | 12 +- .../FingerprintEnrollEnrollingErrorDialog.kt | 75 ------ .../FingerprintEnrollEnrollingRfpsFragment.kt | 228 ++++++++++------- .../FingerprintEnrollEnrollingSfpsFragment.kt | 211 ++++++++++------ ...FingerprintEnrollEnrollingUdfpsFragment.kt | 236 ++++++++++++------ .../ui/view/FingerprintEnrollErrorDialog.kt | 123 +++++++++ .../view/FingerprintEnrollFindRfpsFragment.kt | 155 ++++++------ .../view/FingerprintEnrollFindSfpsFragment.kt | 173 +++++++------ .../ui/view/FingerprintEnrollmentActivity.kt | 118 +++++---- .../ui/viewmodel/DeviceRotationViewModel.java | 13 +- .../FingerprintEnrollEnrollingViewModel.java | 90 +------ .../FingerprintEnrollErrorDialogViewModel.kt | 51 ++++ .../FingerprintEnrollProgressViewModel.java | 37 ++- .../ui/widget/UdfpsEnrollView.java | 27 +- .../view/FingerprintEnrollmentActivityTest.kt | 46 ++-- ...ngerprintEnrollEnrollingViewModelTest.java | 29 +-- ...ngerprintEnrollErrorDialogViewModelTest.kt | 134 ++++++++++ ...ingerprintEnrollProgressViewModelTest.java | 52 ++-- 21 files changed, 1138 insertions(+), 729 deletions(-) create mode 100644 res/layout/udfps_enroll_enrolling_v2_udfps_view.xml delete mode 100644 src/com/android/settings/biometrics2/ui/view/FingerprintEnrollEnrollingErrorDialog.kt create mode 100644 src/com/android/settings/biometrics2/ui/view/FingerprintEnrollErrorDialog.kt create mode 100644 src/com/android/settings/biometrics2/ui/viewmodel/FingerprintEnrollErrorDialogViewModel.kt create mode 100644 tests/unit/src/com/android/settings/biometrics2/ui/viewmodel/FingerprintEnrollErrorDialogViewModelTest.kt diff --git a/Android.bp b/Android.bp index 1351d031b73..baf9914bb44 100644 --- a/Android.bp +++ b/Android.bp @@ -77,6 +77,7 @@ android_library { "setupcompat", "setupdesign", "androidx.lifecycle_lifecycle-runtime", + "androidx.lifecycle_lifecycle-runtime-ktx", "androidx.lifecycle_lifecycle-viewmodel", "guava", "jsr305", diff --git a/res/layout/udfps_enroll_enrolling_v2.xml b/res/layout/udfps_enroll_enrolling_v2.xml index 4675606592d..b579bed3f05 100644 --- a/res/layout/udfps_enroll_enrolling_v2.xml +++ b/res/layout/udfps_enroll_enrolling_v2.xml @@ -70,25 +70,7 @@ app:lottie_loop="true" app:lottie_speed=".85" /> - - - - - - - +