isAvailable is true by default in dev options

- isAvailable() is defaulted to return true for all developer options
 preferences
 - child controllers should override for custom hiding logic

Bug: 34203528
Test: make RunSettingsRoboTests -j40
Change-Id: I89921f801c25e74bf78d02c55b5f34cf1d464cd0

src/com/android/settings/development/BluetoothAbsoluteVolumePreferenceController.java

@@ -38,11 +38,6 @@ public class BluetoothAbsoluteVolumePreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return BLUETOOTH_DISABLE_ABSOLUTE_VOLUME_KEY;

src/com/android/settings/development/BluetoothDeviceNoNamePreferenceController.java

@@ -38,11 +38,6 @@ public class BluetoothDeviceNoNamePreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return BLUETOOTH_SHOW_DEVICES_WITHOUT_NAMES_KEY;

src/com/android/settings/development/BluetoothSnoopLogPreferenceController.java

@@ -37,11 +37,6 @@ public class BluetoothSnoopLogPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return PREFERENCE_KEY;

src/com/android/settings/development/DebugViewAttributesPreferenceController.java

@@ -39,11 +39,6 @@ public class DebugViewAttributesPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return DEBUG_VIEW_ATTRIBUTES_KEY;

src/com/android/settings/development/DeveloperOptionsPreferenceController.java

@@ -51,6 +51,16 @@ public abstract class DeveloperOptionsPreferenceController extends
         return false;
     }
 
+    /**
+     * Child classes should override this method to create custom logic for hiding preferences.
+     *
+     * @return true if the preference is to be displayed.
+     */
+    @Override
+    public boolean isAvailable() {
+        return true;
+    }
+
     /**
      * Called when developer options is enabled
      */

src/com/android/settings/development/DisableAutomaticUpdatesPreferenceController.java

@@ -43,11 +43,6 @@ public class DisableAutomaticUpdatesPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return OTA_DISABLE_AUTOMATIC_UPDATE_KEY;

src/com/android/settings/development/MobileDataAlwaysOnPreferenceController.java

@@ -39,11 +39,6 @@ public class MobileDataAlwaysOnPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return MOBILE_DATA_ALWAYS_ON;

src/com/android/settings/development/PointerLocationPreferenceController.java

@@ -39,11 +39,6 @@ public class PointerLocationPreferenceController extends DeveloperOptionsPrefere
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return POINTER_LOCATION_KEY;

src/com/android/settings/development/SelectDebugAppPreferenceController.java

@@ -48,11 +48,6 @@ public class SelectDebugAppPreferenceController extends DeveloperOptionsPreferen
         mPackageManager = new PackageManagerWrapper(mContext.getPackageManager());
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return DEBUG_APP_KEY;

src/com/android/settings/development/ShowSurfaceUpdatesPreferenceController.java

@@ -50,11 +50,6 @@ public class ShowSurfaceUpdatesPreferenceController extends DeveloperOptionsPref
         mSurfaceFlinger = ServiceManager.getService(SURFACE_FLINGER_SERVICE_KEY);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return SHOW_SCREEN_UPDATES_KEY;

src/com/android/settings/development/ShowTapsPreferenceController.java

@@ -39,11 +39,6 @@ public class ShowTapsPreferenceController extends DeveloperOptionsPreferenceCont
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return SHOW_TOUCHES_KEY;

src/com/android/settings/development/StayAwakePreferenceController.java

@@ -61,11 +61,6 @@ public class StayAwakePreferenceController extends DeveloperOptionsPreferenceCon
         }
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return PREFERENCE_KEY;

src/com/android/settings/development/TetheringHardwareAccelPreferenceController.java

@@ -41,11 +41,6 @@ public class TetheringHardwareAccelPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return TETHERING_HARDWARE_OFFLOAD;

src/com/android/settings/development/WaitForDebuggerPreferenceController.java

@@ -48,11 +48,6 @@ public class WaitForDebuggerPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return WAIT_FOR_DEBUGGER_KEY;

src/com/android/settings/development/WifiAggressiveHandoverPreferenceController.java

@@ -42,11 +42,6 @@ public class WifiAggressiveHandoverPreferenceController extends
         mWifiManager = (WifiManager) context.getSystemService(Context.WIFI_SERVICE);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return WIFI_AGGRESSIVE_HANDOVER_KEY;

src/com/android/settings/development/WifiDisplayCertificationPreferenceController.java

@@ -40,11 +40,6 @@ public class WifiDisplayCertificationPreferenceController extends
         super(context);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return WIFI_DISPLAY_CERTIFICATION_KEY;

src/com/android/settings/development/WifiRoamScansPreferenceController.java

@@ -42,11 +42,6 @@ public class WifiRoamScansPreferenceController extends
         mWifiManager = (WifiManager) context.getSystemService(Context.WIFI_SERVICE);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return WIFI_ALLOW_SCAN_WITH_TRAFFIC_KEY;

src/com/android/settings/development/WifiVerboseLoggingPreferenceController.java

@@ -42,11 +42,6 @@ public class WifiVerboseLoggingPreferenceController extends
         mWifiManager = (WifiManager) context.getSystemService(Context.WIFI_SERVICE);
     }
 
-    @Override
-    public boolean isAvailable() {
-        return true;
-    }
-
     @Override
     public String getPreferenceKey() {
         return WIFI_VERBOSE_LOGGING_KEY;