From 7a5ec887840f81601c22d96761c3f4df2face7bd Mon Sep 17 00:00:00 2001
From: Becca Hughes <beccahughes@google.com>
Date: Wed, 10 May 2023 17:15:38 +0000
Subject: [PATCH 1/2] Fix credman provider not showing

Test: ondevice
Bug: 281787107
Change-Id: I4cc4cc2216a7c452ee63cb742a292dadbd46714f
---
 ...faultWorkCombinedPreferenceController.java | 22 -------------------
 1 file changed, 22 deletions(-)

diff --git a/src/com/android/settings/applications/credentials/DefaultWorkCombinedPreferenceController.java b/src/com/android/settings/applications/credentials/DefaultWorkCombinedPreferenceController.java
index 74bf9026b2f..eb0aa7abfd3 100644
--- a/src/com/android/settings/applications/credentials/DefaultWorkCombinedPreferenceController.java
+++ b/src/com/android/settings/applications/credentials/DefaultWorkCombinedPreferenceController.java
@@ -16,12 +16,9 @@
 
 package com.android.settings.applications.credentials;
 
-import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.os.UserHandle;
-import android.provider.Settings;
-import android.text.TextUtils;
 
 import com.android.settings.Utils;
 import com.android.settingslib.applications.DefaultAppInfo;
@@ -47,25 +44,6 @@ public class DefaultWorkCombinedPreferenceController extends DefaultCombinedPref
         return "default_credman_autofill_main_work";
     }
 
-    @Override
-    protected DefaultAppInfo getDefaultAppInfo() {
-        final String flattenComponent =
-                Settings.Secure.getStringForUser(
-                        mContext.getContentResolver(),
-                        DefaultCombinedPicker.AUTOFILL_SETTING,
-                        mUserHandle.getIdentifier());
-        if (!TextUtils.isEmpty(flattenComponent)) {
-            DefaultAppInfo appInfo =
-                    new DefaultAppInfo(
-                            mContext,
-                            mPackageManager,
-                            mUserHandle.getIdentifier(),
-                            ComponentName.unflattenFromString(flattenComponent));
-            return appInfo;
-        }
-        return null;
-    }
-
     @Override
     protected Intent getSettingIntent(DefaultAppInfo info) {
         if (info == null) {

From 68470a4f2768bdc42c35a373da46e973b0ecc778 Mon Sep 17 00:00:00 2001
From: Becca Hughes <beccahughes@google.com>
Date: Tue, 9 May 2023 21:45:09 +0000
Subject: [PATCH 2/2] Warn earlier about 5 provider limit

Test: ondevice
Bug: 281616441
Change-Id: I4c4d257e1a0a6396b3948a2b50462bbef1987729
---
 .../CredentialManagerPreferenceController.java | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/com/android/settings/applications/credentials/CredentialManagerPreferenceController.java b/src/com/android/settings/applications/credentials/CredentialManagerPreferenceController.java
index d6808a4014c..9b959c5f622 100644
--- a/src/com/android/settings/applications/credentials/CredentialManagerPreferenceController.java
+++ b/src/com/android/settings/applications/credentials/CredentialManagerPreferenceController.java
@@ -533,16 +533,9 @@ public class CredentialManagerPreferenceController extends BasePreferenceControl
                     boolean isChecked = pref.isChecked();
 
                     if (isChecked) {
-                        if (togglePackageNameEnabled(packageName)) {
-                            // Enable all prefs.
-                            if (mPrefs.containsKey(packageName)) {
-                                mPrefs.get(packageName).setChecked(true);
-                            }
-                        } else {
-                            // Since we failed to show toggle the switch back to off.
-                            pref.setChecked(false);
-
+                        if (mEnabledPackageNames.size() >= MAX_SELECTABLE_PROVIDERS) {
                             // Show the error if too many enabled.
+                            pref.setChecked(false);
                             final DialogFragment fragment = newErrorDialogFragment();
 
                             if (fragment == null || mFragmentManager == null) {
@@ -550,8 +543,15 @@ public class CredentialManagerPreferenceController extends BasePreferenceControl
                             }
 
                             fragment.show(mFragmentManager, ErrorDialogFragment.TAG);
+                            return true;
                         }
 
+                        togglePackageNameEnabled(packageName);
+
+                        // Enable all prefs.
+                        if (mPrefs.containsKey(packageName)) {
+                            mPrefs.get(packageName).setChecked(true);
+                        }
                         return true;
                     } else {
                         // If we are disabling the last enabled provider then show a warning.