Remove lifecycle-extensions from Settings

Bug: 259352947
Test: Make Settings
Change-Id: Ide9749494ae89ca401120eb5ffee9c0d87043c48
This commit is contained in:
Chaohui Wang
2022-11-16 17:56:47 +08:00
parent 148774d287
commit f55f9932d9
7 changed files with 24 additions and 24 deletions

View File

@@ -72,7 +72,7 @@ android_library {
"setupcompat", "setupcompat",
"setupdesign", "setupdesign",
"androidx.lifecycle_lifecycle-runtime", "androidx.lifecycle_lifecycle-runtime",
"androidx.lifecycle_lifecycle-extensions", "androidx.lifecycle_lifecycle-viewmodel",
"guava", "guava",
"jsr305", "jsr305",
"net-utils-framework-common", "net-utils-framework-common",

View File

@@ -35,7 +35,7 @@ import android.widget.ProgressBar;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentManager;
import androidx.lifecycle.ViewModelProviders; import androidx.lifecycle.ViewModelProvider;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.instrumentation.InstrumentedDialogFragment; import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
@@ -62,7 +62,7 @@ public class ProgressDialogFragment extends InstrumentedDialogFragment {
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);
mViewModel = ViewModelProviders.of(this.getActivity()).get(SupportedLinkViewModel.class); mViewModel = new ViewModelProvider(this.getActivity()).get(SupportedLinkViewModel.class);
} }
@Override @Override

View File

@@ -28,7 +28,7 @@ import android.util.Log;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.fragment.app.Fragment; import androidx.fragment.app.Fragment;
import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentManager;
import androidx.lifecycle.ViewModelProviders; import androidx.lifecycle.ViewModelProvider;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.instrumentation.InstrumentedDialogFragment; import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
@@ -50,7 +50,7 @@ public class SupportedLinksDialogFragment extends InstrumentedDialogFragment {
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);
mPackage = getArguments().getString(AppLaunchSettings.APP_PACKAGE_KEY); mPackage = getArguments().getString(AppLaunchSettings.APP_PACKAGE_KEY);
mViewModel = ViewModelProviders.of(this.getActivity()).get(SupportedLinkViewModel.class); mViewModel = new ViewModelProvider(this.getActivity()).get(SupportedLinkViewModel.class);
mSupportedLinkWrapperList = mViewModel.getSupportedLinkWrapperList(); mSupportedLinkWrapperList = mViewModel.getSupportedLinkWrapperList();
} }

View File

@@ -38,7 +38,7 @@ import android.util.Log;
import android.util.Pair; import android.util.Pair;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.lifecycle.ViewModelProviders; import androidx.lifecycle.ViewModelProvider;
import androidx.preference.ListPreference; import androidx.preference.ListPreference;
import androidx.preference.Preference; import androidx.preference.Preference;
@@ -208,7 +208,7 @@ public class TextToSpeechSettings extends SettingsPreferenceFragment
} }
final TextToSpeechViewModel ttsViewModel = final TextToSpeechViewModel ttsViewModel =
ViewModelProviders.of(this).get(TextToSpeechViewModel.class); new ViewModelProvider(this).get(TextToSpeechViewModel.class);
Pair<TextToSpeech, Boolean> ttsAndNew = ttsViewModel.getTtsAndWhetherNew(mInitListener); Pair<TextToSpeech, Boolean> ttsAndNew = ttsViewModel.getTtsAndWhetherNew(mInitListener);
mTts = ttsAndNew.first; mTts = ttsAndNew.first;
// If the TTS object is not newly created, we need to run the setup on the settings side to // If the TTS object is not newly created, we need to run the setup on the settings side to
@@ -237,7 +237,7 @@ public class TextToSpeechSettings extends SettingsPreferenceFragment
} }
if (!mTts.getDefaultEngine().equals(mTts.getCurrentEngine())) { if (!mTts.getDefaultEngine().equals(mTts.getCurrentEngine())) {
final TextToSpeechViewModel ttsViewModel = final TextToSpeechViewModel ttsViewModel =
ViewModelProviders.of(this).get(TextToSpeechViewModel.class); new ViewModelProvider(this).get(TextToSpeechViewModel.class);
try { try {
// If the current engine isn't the default engine shut down the current engine in // If the current engine isn't the default engine shut down the current engine in
// preparation for creating the new engine. // preparation for creating the new engine.

View File

@@ -37,7 +37,7 @@ import android.view.ViewGroup;
import android.widget.Button; import android.widget.Button;
import android.widget.ImageView; import android.widget.ImageView;
import androidx.lifecycle.ViewModelProviders; import androidx.lifecycle.ViewModelProvider;
import com.android.settings.R; import com.android.settings.R;
@@ -74,7 +74,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
@Override @Override
public void onFailure(int code, String ssid, SparseArray<int[]> channelListArray, public void onFailure(int code, String ssid, SparseArray<int[]> channelListArray,
int[] operatingClassArray) { int[] operatingClassArray) {
Log.d(TAG, "EasyConnectConfiguratorStatusCallback.onFailure: " + code); Log.d(TAG, "EasyConnectConfiguratorStatusCallback.onFailure: " + code);
if (!TextUtils.isEmpty(ssid)) { if (!TextUtils.isEmpty(ssid)) {
Log.d(TAG, "Tried SSID: " + ssid); Log.d(TAG, "Tried SSID: " + ssid);
@@ -123,7 +123,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
} }
private Intent getResultIntent(int code, String ssid, SparseArray<int[]> channelListArray, private Intent getResultIntent(int code, String ssid, SparseArray<int[]> channelListArray,
int[] operatingClassArray) { int[] operatingClassArray) {
Intent intent = new Intent(); Intent intent = new Intent();
intent.putExtra(EXTRA_EASY_CONNECT_ERROR_CODE, code); intent.putExtra(EXTRA_EASY_CONNECT_ERROR_CODE, code);
@@ -195,7 +195,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
} }
if (code == mLatestStatusCode) { if (code == mLatestStatusCode) {
throw(new IllegalStateException("Tried restarting EasyConnectSession but still" throw (new IllegalStateException("Tried restarting EasyConnectSession but still"
+ "receiving EASY_CONNECT_EVENT_FAILURE_BUSY")); + "receiving EASY_CONNECT_EVENT_FAILURE_BUSY"));
} }
@@ -220,7 +220,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
break; break;
case EasyConnectStatusCallback.EASY_CONNECT_EVENT_FAILURE_INVALID_NETWORK: case EasyConnectStatusCallback.EASY_CONNECT_EVENT_FAILURE_INVALID_NETWORK:
throw(new IllegalStateException("Wi-Fi DPP configurator used a non-PSK/non-SAE" throw (new IllegalStateException("Wi-Fi DPP configurator used a non-PSK/non-SAE"
+ "network to handshake")); + "network to handshake"));
case EasyConnectStatusCallback.EASY_CONNECT_EVENT_FAILURE_CANNOT_FIND_NETWORK: case EasyConnectStatusCallback.EASY_CONNECT_EVENT_FAILURE_CANNOT_FIND_NETWORK:
@@ -238,7 +238,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
break; break;
default: default:
throw(new IllegalStateException("Unexpected Wi-Fi DPP error")); throw (new IllegalStateException("Unexpected Wi-Fi DPP error"));
} }
setHeaderTitle(R.string.wifi_dpp_could_not_add_device); setHeaderTitle(R.string.wifi_dpp_could_not_add_device);
@@ -297,7 +297,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
} }
final WifiDppInitiatorViewModel model = final WifiDppInitiatorViewModel model =
ViewModelProviders.of(this).get(WifiDppInitiatorViewModel.class); new ViewModelProvider(this).get(WifiDppInitiatorViewModel.class);
model.getStatusCode().observe(this, statusCode -> { model.getStatusCode().observe(this, statusCode -> {
// After configuration change, observe callback will be triggered, // After configuration change, observe callback will be triggered,
@@ -318,7 +318,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
@Override @Override
public final View onCreateView(LayoutInflater inflater, ViewGroup container, public final View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) { Bundle savedInstanceState) {
return inflater.inflate(R.layout.wifi_dpp_add_device_fragment, container, return inflater.inflate(R.layout.wifi_dpp_add_device_fragment, container,
/* attachToRoot */ false); /* attachToRoot */ false);
} }
@@ -343,7 +343,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
mChooseDifferentNetwork = view.findViewById(R.id.choose_different_network); mChooseDifferentNetwork = view.findViewById(R.id.choose_different_network);
mChooseDifferentNetwork.setOnClickListener(v -> mChooseDifferentNetwork.setOnClickListener(v ->
mClickChooseDifferentNetworkListener.onClickChooseDifferentNetwork() mClickChooseDifferentNetworkListener.onClickChooseDifferentNetwork()
); );
mLeftButton.setText(getContext(), R.string.cancel); mLeftButton.setText(getContext(), R.string.cancel);
@@ -394,7 +394,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
final int networkId = final int networkId =
((WifiDppConfiguratorActivity) getActivity()).getWifiNetworkConfig().getNetworkId(); ((WifiDppConfiguratorActivity) getActivity()).getWifiNetworkConfig().getNetworkId();
final WifiDppInitiatorViewModel model = final WifiDppInitiatorViewModel model =
ViewModelProviders.of(this).get(WifiDppInitiatorViewModel.class); new ViewModelProvider(this).get(WifiDppInitiatorViewModel.class);
model.startEasyConnectAsConfiguratorInitiator(qrCode, networkId); model.startEasyConnectAsConfiguratorInitiator(qrCode, networkId);
} }
@@ -403,6 +403,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
public interface OnClickChooseDifferentNetworkListener { public interface OnClickChooseDifferentNetworkListener {
void onClickChooseDifferentNetwork(); void onClickChooseDifferentNetwork();
} }
private OnClickChooseDifferentNetworkListener mClickChooseDifferentNetworkListener; private OnClickChooseDifferentNetworkListener mClickChooseDifferentNetworkListener;
@Override @Override
@@ -422,7 +423,7 @@ public class WifiDppAddDeviceFragment extends WifiDppQrCodeBaseFragment {
// Check is Easy Connect handshaking or not // Check is Easy Connect handshaking or not
private boolean isEasyConnectHandshaking() { private boolean isEasyConnectHandshaking() {
final WifiDppInitiatorViewModel model = final WifiDppInitiatorViewModel model =
ViewModelProviders.of(this).get(WifiDppInitiatorViewModel.class); new ViewModelProvider(this).get(WifiDppInitiatorViewModel.class);
return model.isWifiDppHandshaking(); return model.isWifiDppHandshaking();
} }

View File

@@ -53,7 +53,7 @@ import android.widget.TextView;
import androidx.annotation.StringRes; import androidx.annotation.StringRes;
import androidx.annotation.UiThread; import androidx.annotation.UiThread;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import androidx.lifecycle.ViewModelProviders; import androidx.lifecycle.ViewModelProvider;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.overlay.FeatureFactory; import com.android.settings.overlay.FeatureFactory;
@@ -298,7 +298,7 @@ public class WifiDppQrCodeScannerFragment extends WifiDppQrCodeBaseFragment impl
} }
final WifiDppInitiatorViewModel model = final WifiDppInitiatorViewModel model =
ViewModelProviders.of(this).get(WifiDppInitiatorViewModel.class); new ViewModelProvider(this).get(WifiDppInitiatorViewModel.class);
model.getEnrolleeSuccessNetworkId().observe(this, networkId -> { model.getEnrolleeSuccessNetworkId().observe(this, networkId -> {
// After configuration change, observe callback will be triggered, // After configuration change, observe callback will be triggered,
@@ -719,7 +719,7 @@ public class WifiDppQrCodeScannerFragment extends WifiDppQrCodeBaseFragment impl
private void startWifiDppEnrolleeInitiator(WifiQrCode wifiQrCode) { private void startWifiDppEnrolleeInitiator(WifiQrCode wifiQrCode) {
final WifiDppInitiatorViewModel model = final WifiDppInitiatorViewModel model =
ViewModelProviders.of(this).get(WifiDppInitiatorViewModel.class); new ViewModelProvider(this).get(WifiDppInitiatorViewModel.class);
model.startEasyConnectAsEnrolleeInitiator(wifiQrCode.getQrCode()); model.startEasyConnectAsEnrolleeInitiator(wifiQrCode.getQrCode());
} }
@@ -765,7 +765,7 @@ public class WifiDppQrCodeScannerFragment extends WifiDppQrCodeBaseFragment impl
// Check is Easy Connect handshaking or not // Check is Easy Connect handshaking or not
private boolean isWifiDppHandshaking() { private boolean isWifiDppHandshaking() {
final WifiDppInitiatorViewModel model = final WifiDppInitiatorViewModel model =
ViewModelProviders.of(this).get(WifiDppInitiatorViewModel.class); new ViewModelProvider(this).get(WifiDppInitiatorViewModel.class);
return model.isWifiDppHandshaking(); return model.isWifiDppHandshaking();
} }

View File

@@ -39,7 +39,6 @@ android_app {
"setupcompat", "setupcompat",
"setupdesign", "setupdesign",
"androidx.lifecycle_lifecycle-runtime", "androidx.lifecycle_lifecycle-runtime",
"androidx.lifecycle_lifecycle-extensions",
"androidx.test.core", "androidx.test.core",
"androidx.test.runner", "androidx.test.runner",
"androidx.test.ext.junit", "androidx.test.ext.junit",