From 0e2147c5e2f7f1227ebf61a9c1fa60ce4a81f0d1 Mon Sep 17 00:00:00 2001 From: Jason Chiu Date: Tue, 30 Aug 2022 10:46:19 +0800 Subject: [PATCH] Fix the injection disappearance in the Account detail page displayTile() requires some parameters to determine whether to show the injection tiles and update the intent, but the parameters were not initialized. Move the parameter initialization before super.onCreate() since displayTile() will be called in super.onCreate(). Test: visual, robotest Fix: 242673595 Change-Id: Idf2d758a8b8c4230e644bcd0d286a278d258b736 --- .../settings/accounts/AccountDetailDashboardFragment.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/accounts/AccountDetailDashboardFragment.java b/src/com/android/settings/accounts/AccountDetailDashboardFragment.java index 1485500931b..0668c62b758 100644 --- a/src/com/android/settings/accounts/AccountDetailDashboardFragment.java +++ b/src/com/android/settings/accounts/AccountDetailDashboardFragment.java @@ -64,8 +64,7 @@ public class AccountDetailDashboardFragment extends DashboardFragment { @Override public void onCreate(Bundle icicle) { - super.onCreate(icicle); - getPreferenceManager().setPreferenceComparisonCallback(null); + // Initialize the parameters since displayTile() will be called in super.onCreate(). Bundle args = getArguments(); final Activity activity = getActivity(); mUserHandle = Utils.getSecureTargetUser(activity.getActivityToken(), @@ -82,6 +81,9 @@ public class AccountDetailDashboardFragment extends DashboardFragment { mAccountType = args.getString(KEY_ACCOUNT_TYPE); } } + + super.onCreate(icicle); + getPreferenceManager().setPreferenceComparisonCallback(null); mAccountSynController.init(mAccount, mUserHandle); mRemoveAccountController.init(mAccount, mUserHandle); }