diff --git a/res/values/strings.xml b/res/values/strings.xml index b2d7ac0062e..8de711284d5 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4817,7 +4817,7 @@ Interaction controls - Downloaded apps + Downloaded services Experimental @@ -4921,7 +4921,7 @@ Touch feedback - Use %1$s + Use service Use color correction @@ -5147,7 +5147,7 @@ - View and perform actions + View and platform actions It can track your interactions diff --git a/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java b/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java index 4fe65073a86..b28d8b5e541 100644 --- a/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java @@ -85,16 +85,6 @@ public class ToggleAccessibilityServicePreferenceFragment mLockPatternUtils = new LockPatternUtils(getActivity()); } - @Override - public void onViewCreated(View view, Bundle savedInstanceState) { - super.onViewCreated(view, savedInstanceState); - mSwitchBar.setLabelDelegate((boolean isChecked) -> { - final AccessibilityServiceInfo info = getAccessibilityServiceInfo(); - return getString(R.string.accessibility_service_master_switch_title, - info.getResolveInfo().loadLabel(getPackageManager())); - }); - } - @Override public void onResume() { mSettingsContentObserver.register(getContentResolver()); @@ -130,7 +120,7 @@ public class ToggleAccessibilityServicePreferenceFragment return serviceInfo; } } - throw new IllegalStateException("ServiceInfo is not found."); + return null; } @Override @@ -138,12 +128,18 @@ public class ToggleAccessibilityServicePreferenceFragment switch (dialogId) { case DIALOG_ID_ENABLE_WARNING: { final AccessibilityServiceInfo info = getAccessibilityServiceInfo(); + if (info == null) { + return null; + } mDialog = AccessibilityServiceWarning .createCapabilitiesDialog(getActivity(), info, this); break; } case DIALOG_ID_DISABLE_WARNING: { AccessibilityServiceInfo info = getAccessibilityServiceInfo(); + if (info == null) { + return null; + } mDialog = AccessibilityServiceWarning .createDisableDialog(getActivity(), info, this); break; diff --git a/src/com/android/settings/widget/SwitchBar.java b/src/com/android/settings/widget/SwitchBar.java index 33413040e82..f8743d1fa47 100644 --- a/src/com/android/settings/widget/SwitchBar.java +++ b/src/com/android/settings/widget/SwitchBar.java @@ -61,16 +61,6 @@ public class SwitchBar extends LinearLayout implements CompoundButton.OnCheckedC void onSwitchChanged(Switch switchView, boolean isChecked); } - public interface LabelDelegate { - /** - * Called to create label and set the title with Accessibility - * service name to the textView of switchBar. - * - * @param isChecked The checked state of switchView. - */ - String createLabel(boolean isChecked); - } - private static final int[] XML_ATTRIBUTES = { R.attr.switchBarMarginStart, R.attr.switchBarMarginEnd, @@ -100,7 +90,6 @@ public class SwitchBar extends LinearLayout implements CompoundButton.OnCheckedC private boolean mDisabledByAdmin; private EnforcedAdmin mEnforcedAdmin = null; private String mMetricsTag; - private LabelDelegate mLabelDelegate; public SwitchBar(Context context) { @@ -189,11 +178,7 @@ public class SwitchBar extends LinearLayout implements CompoundButton.OnCheckedC } public void setTextViewLabelAndBackground(boolean isChecked) { - if(mLabelDelegate != null) { - mLabel = mLabelDelegate.createLabel(isChecked); - } else { - mLabel = getResources().getString(isChecked ? mOnTextId : mOffTextId); - } + mLabel = getResources().getString(isChecked ? mOnTextId : mOffTextId); setBackgroundColor(isChecked ? mBackgroundActivatedColor : mBackgroundColor); updateText(); } @@ -398,9 +383,4 @@ public class SwitchBar extends LinearLayout implements CompoundButton.OnCheckedC requestLayout(); } - - public void setLabelDelegate(LabelDelegate labelDelegate) { - mLabelDelegate = labelDelegate; - setTextViewLabelAndBackground(isChecked()); - } }