From 6ba89c33a404f6ca990bbff2d626662b5d530b96 Mon Sep 17 00:00:00 2001 From: timhypeng Date: Mon, 9 Dec 2019 13:56:54 +0800 Subject: [PATCH] Add sample rate preference controller for Bluetooth developer option Bug: 142227996 Test: make -j50 RunSettingsRoboTests Change-Id: I84198ae04221c2f28c1d8e596e4a8f295e7a76d1 --- ...hSampleRateDialogPreferenceController.java | 133 +++++++++++++++++ ...pleRateDialogPreferenceControllerTest.java | 138 ++++++++++++++++++ 2 files changed, 271 insertions(+) create mode 100644 src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceController.java create mode 100644 tests/robotests/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceControllerTest.java diff --git a/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceController.java b/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceController.java new file mode 100644 index 00000000000..9e4b99ef88c --- /dev/null +++ b/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceController.java @@ -0,0 +1,133 @@ +/* + * Copyright (C) 2019 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.development.bluetooth; + +import android.bluetooth.BluetoothCodecConfig; +import android.content.Context; +import android.util.Log; + +import androidx.annotation.VisibleForTesting; +import androidx.preference.PreferenceScreen; + +import com.android.settings.development.BluetoothA2dpConfigStore; +import com.android.settingslib.core.lifecycle.Lifecycle; + +import java.util.ArrayList; +import java.util.List; + +/** + * Dialog preference controller to set the Bluetooth A2DP config of sample rate + */ +public class BluetoothSampleRateDialogPreferenceController extends + AbstractBluetoothDialogPreferenceController { + + private static final String KEY = "bluetooth_sample_rate_settings"; + private static final String TAG = "BtSampleRateCtr"; + + public BluetoothSampleRateDialogPreferenceController(Context context, Lifecycle lifecycle, + BluetoothA2dpConfigStore store) { + super(context, lifecycle, store); + } + + @Override + public String getPreferenceKey() { + return KEY; + } + + @Override + public void displayPreference(PreferenceScreen screen) { + super.displayPreference(screen); + ((BaseBluetoothDialogPreference) mPreference).setCallback(this); + } + + @Override + protected void writeConfigurationValues(final int index) { + int sampleRateValue = BluetoothCodecConfig.SAMPLE_RATE_NONE; // default + switch (index) { + case 0: + final BluetoothCodecConfig currentConfig = getCurrentCodecConfig(); + if (currentConfig != null) { + sampleRateValue = getHighestSampleRate(getSelectableByCodecType( + currentConfig.getCodecType())); + } + break; + case 1: + sampleRateValue = BluetoothCodecConfig.SAMPLE_RATE_44100; + break; + case 2: + sampleRateValue = BluetoothCodecConfig.SAMPLE_RATE_48000; + break; + case 3: + sampleRateValue = BluetoothCodecConfig.SAMPLE_RATE_88200; + break; + case 4: + sampleRateValue = BluetoothCodecConfig.SAMPLE_RATE_96000; + break; + default: + break; + } + mBluetoothA2dpConfigStore.setSampleRate(sampleRateValue); + } + + @Override + protected int getCurrentIndexByConfig(BluetoothCodecConfig config) { + if (config == null) { + Log.e(TAG, "Unable to get current config index. Config is null."); + } + return convertCfgToBtnIndex(config.getSampleRate()); + } + + @Override + public List getSelectableIndex() { + List selectableIndex = new ArrayList<>(); + selectableIndex.add(getDefaultIndex()); + final BluetoothCodecConfig currentConfig = getCurrentCodecConfig(); + if (currentConfig != null) { + final int configs = + getSelectableByCodecType(currentConfig.getCodecType()).getSampleRate(); + for (int sampleRate : SAMPLE_RATES) { + if ((configs & sampleRate) != 0) { + selectableIndex.add(convertCfgToBtnIndex(sampleRate)); + } + } + } + return selectableIndex; + } + + @VisibleForTesting + int convertCfgToBtnIndex(int config) { + int index = getDefaultIndex(); + switch (config) { + case BluetoothCodecConfig.SAMPLE_RATE_44100: + index = 1; + break; + case BluetoothCodecConfig.SAMPLE_RATE_48000: + index = 2; + break; + case BluetoothCodecConfig.SAMPLE_RATE_88200: + index = 3; + break; + case BluetoothCodecConfig.SAMPLE_RATE_96000: + index = 4; + break; + default: + Log.e(TAG, "Unsupported config:" + config); + break; + } + return index; + } +} diff --git a/tests/robotests/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceControllerTest.java new file mode 100644 index 00000000000..d274a5730d2 --- /dev/null +++ b/tests/robotests/src/com/android/settings/development/bluetooth/BluetoothSampleRateDialogPreferenceControllerTest.java @@ -0,0 +1,138 @@ +/* + * Copyright (C) 2019 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.settings.development.bluetooth; + +import static com.google.common.truth.Truth.assertThat; + +import static org.mockito.Mockito.spy; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import android.bluetooth.BluetoothA2dp; +import android.bluetooth.BluetoothCodecConfig; +import android.bluetooth.BluetoothCodecStatus; +import android.content.Context; + +import androidx.lifecycle.LifecycleOwner; +import androidx.preference.PreferenceScreen; + +import com.android.settings.development.BluetoothA2dpConfigStore; +import com.android.settingslib.core.lifecycle.Lifecycle; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; +import org.robolectric.RobolectricTestRunner; +import org.robolectric.RuntimeEnvironment; + +import java.util.ArrayList; +import java.util.List; + +@RunWith(RobolectricTestRunner.class) +public class BluetoothSampleRateDialogPreferenceControllerTest { + + @Mock + private BluetoothA2dp mBluetoothA2dp; + @Mock + private PreferenceScreen mScreen; + + private BluetoothSampleRateDialogPreferenceController mController; + private BluetoothSampleRateDialogPreference mPreference; + private BluetoothA2dpConfigStore mBluetoothA2dpConfigStore; + private BluetoothCodecStatus mCodecStatus; + private BluetoothCodecConfig mCodecConfigAAC; + private BluetoothCodecConfig mCodecConfigSBC; + private Context mContext; + private LifecycleOwner mLifecycleOwner; + private Lifecycle mLifecycle; + + @Before + public void setup() { + MockitoAnnotations.initMocks(this); + mContext = RuntimeEnvironment.application; + mLifecycleOwner = () -> mLifecycle; + mLifecycle = new Lifecycle(mLifecycleOwner); + mBluetoothA2dpConfigStore = spy(new BluetoothA2dpConfigStore()); + mController = spy(new BluetoothSampleRateDialogPreferenceController(mContext, mLifecycle, + mBluetoothA2dpConfigStore)); + mPreference = new BluetoothSampleRateDialogPreference(mContext); + when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); + mController.displayPreference(mScreen); + mCodecConfigAAC = new BluetoothCodecConfig(BluetoothCodecConfig.SOURCE_CODEC_TYPE_AAC, + BluetoothCodecConfig.CODEC_PRIORITY_DEFAULT, + BluetoothCodecConfig.SAMPLE_RATE_48000 | BluetoothCodecConfig.SAMPLE_RATE_88200, + BluetoothCodecConfig.BITS_PER_SAMPLE_NONE, + BluetoothCodecConfig.CHANNEL_MODE_NONE, + 0, 0, 0, 0); + mCodecConfigSBC = new BluetoothCodecConfig(BluetoothCodecConfig.SOURCE_CODEC_TYPE_SBC, + BluetoothCodecConfig.CODEC_PRIORITY_DEFAULT, + BluetoothCodecConfig.SAMPLE_RATE_96000, + BluetoothCodecConfig.BITS_PER_SAMPLE_NONE, + BluetoothCodecConfig.CHANNEL_MODE_NONE, + 0, 0, 0, 0); + } + + @Test + public void writeConfigurationValues_selectDefault_setHighest() { + mCodecConfigSBC = new BluetoothCodecConfig(BluetoothCodecConfig.SOURCE_CODEC_TYPE_SBC); + BluetoothCodecConfig[] mCodecConfigs = {mCodecConfigAAC, mCodecConfigSBC}; + mCodecStatus = new BluetoothCodecStatus(mCodecConfigAAC, null, mCodecConfigs); + when(mBluetoothA2dp.getCodecStatus(null)).thenReturn(mCodecStatus); + mController.onBluetoothServiceConnected(mBluetoothA2dp); + + mController.writeConfigurationValues(0); + verify(mBluetoothA2dpConfigStore).setSampleRate(BluetoothCodecConfig.SAMPLE_RATE_88200); + } + + @Test + public void writeConfigurationValues_checkSampleRate() { + mController.writeConfigurationValues(1); + verify(mBluetoothA2dpConfigStore).setSampleRate(BluetoothCodecConfig.SAMPLE_RATE_44100); + + mController.writeConfigurationValues(2); + verify(mBluetoothA2dpConfigStore).setSampleRate(BluetoothCodecConfig.SAMPLE_RATE_48000); + + mController.writeConfigurationValues(3); + verify(mBluetoothA2dpConfigStore).setSampleRate(BluetoothCodecConfig.SAMPLE_RATE_88200); + + mController.writeConfigurationValues(4); + verify(mBluetoothA2dpConfigStore).setSampleRate(BluetoothCodecConfig.SAMPLE_RATE_96000); + } + + @Test + public void getCurrentIndexByConfig_verifyIndex() { + assertThat(mController.getCurrentIndexByConfig(mCodecConfigSBC)).isEqualTo( + mController.convertCfgToBtnIndex(BluetoothCodecConfig.SAMPLE_RATE_96000)); + } + + @Test + public void getSelectableIndex_verifyList() { + BluetoothCodecConfig[] mCodecConfigs = {mCodecConfigAAC, mCodecConfigSBC}; + mCodecStatus = new BluetoothCodecStatus(mCodecConfigAAC, null, mCodecConfigs); + when(mBluetoothA2dp.getCodecStatus(null)).thenReturn(mCodecStatus); + mController.onBluetoothServiceConnected(mBluetoothA2dp); + List indexList = new ArrayList<>(); + indexList.add(mController.getDefaultIndex()); + indexList.add(mController.convertCfgToBtnIndex(BluetoothCodecConfig.SAMPLE_RATE_48000)); + indexList.add(mController.convertCfgToBtnIndex(BluetoothCodecConfig.SAMPLE_RATE_88200)); + + assertThat(mController.getSelectableIndex().containsAll(indexList)).isTrue(); + assertThat(indexList.containsAll(mController.getSelectableIndex())).isTrue(); + } +}