From f44308a78d35db9cc211f26cd811c067460b18f1 Mon Sep 17 00:00:00 2001 From: John Wang Date: Thu, 30 Jun 2011 14:31:44 -0700 Subject: [PATCH] Display FCC id for LTE in Settings. If ro.ril.fccid is set by RIL, display it at Settings -> About Tablet -> FCC Equipment ID. bug:4965501 Change-Id: I920ab071bf1997c4fbf3ce81f88e24f512d004c3 --- res/values/strings.xml | 4 +- res/xml/device_info_settings.xml | 44 +++++++++++-------- .../android/settings/DeviceInfoSettings.java | 8 ++++ 3 files changed, 36 insertions(+), 20 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 7808b638afb..4ecb0e0cede 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1511,6 +1511,8 @@ Android version Model number + + FCC Equipment ID Baseband version @@ -1591,7 +1593,7 @@ Media - Downloads + Downloads Pictures, Videos diff --git a/res/xml/device_info_settings.xml b/res/xml/device_info_settings.xml index 492c9d12ddb..ea79fe0b7a5 100644 --- a/res/xml/device_info_settings.xml +++ b/res/xml/device_info_settings.xml @@ -4,9 +4,9 @@ Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - + http://www.apache.org/licenses/LICENSE-2.0 - + Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -19,20 +19,20 @@ - + - + - + - - + - - + - - + + + + - - + - - diff --git a/src/com/android/settings/DeviceInfoSettings.java b/src/com/android/settings/DeviceInfoSettings.java index c3fe955d34f..d041c0523f2 100644 --- a/src/com/android/settings/DeviceInfoSettings.java +++ b/src/com/android/settings/DeviceInfoSettings.java @@ -55,6 +55,8 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment { private static final String KEY_DEVICE_MODEL = "device_model"; private static final String KEY_BASEBAND_VERSION = "baseband_version"; private static final String KEY_FIRMWARE_VERSION = "firmware_version"; + private static final String KEY_EQUIPMENT_ID = "fcc_equipment_id"; + private static final String PROPERTY_EQUIPMENT_ID = "ro.ril.fccid"; long[] mHits = new long[3]; @@ -78,6 +80,7 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment { setStringSummary(KEY_FIRMWARE_VERSION, Build.VERSION.RELEASE); findPreference(KEY_FIRMWARE_VERSION).setEnabled(true); setValueSummary(KEY_BASEBAND_VERSION, "gsm.version.baseband"); + setValueSummary(KEY_EQUIPMENT_ID, PROPERTY_EQUIPMENT_ID); setStringSummary(KEY_DEVICE_MODEL, Build.MODEL); setStringSummary(KEY_BUILD_NUMBER, Build.DISPLAY); findPreference(KEY_KERNEL_VERSION).setSummary(getFormattedKernelVersion()); @@ -86,6 +89,11 @@ public class DeviceInfoSettings extends SettingsPreferenceFragment { removePreferenceIfPropertyMissing(getPreferenceScreen(), "safetylegal", PROPERTY_URL_SAFETYLEGAL); + // Remove Equipment id preference if FCC ID is not set by RIL + removePreferenceIfPropertyMissing(getPreferenceScreen(), KEY_EQUIPMENT_ID, + PROPERTY_EQUIPMENT_ID); + + // Remove Baseband version if wifi-only device if (Utils.isWifiOnly()) { getPreferenceScreen().removePreference(findPreference(KEY_BASEBAND_VERSION));