From 049184fdec1f01e87de0777ca1a3874297878b6f Mon Sep 17 00:00:00 2001 From: Sunny Shao Date: Wed, 12 Apr 2023 21:33:45 +0800 Subject: [PATCH] Add a feature flag for SPA metrics - Add a new SETTINGS_ENABLE_SPA_METRICS flag. Bug: 277540990 Bug: 253979024 Test: atest SpaActivityTest SpaLogDataTest MetricsDataModelTest Change-Id: Iba7a44715cf6ba78c3b84d559faf71a0be33d8d3 --- src/com/android/settings/spa/SettingsSpaEnvironment.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/spa/SettingsSpaEnvironment.kt b/src/com/android/settings/spa/SettingsSpaEnvironment.kt index f5d1e9b73e8..b07b344b128 100644 --- a/src/com/android/settings/spa/SettingsSpaEnvironment.kt +++ b/src/com/android/settings/spa/SettingsSpaEnvironment.kt @@ -17,6 +17,7 @@ package com.android.settings.spa import android.content.Context +import android.util.FeatureFlagUtils import com.android.settings.spa.about.AboutPhonePageProvider import com.android.settings.spa.app.AllAppListPageProvider import com.android.settings.spa.app.AppsMainPageProvider @@ -44,6 +45,7 @@ import com.android.settings.spa.system.LanguageAndInputPageProvider import com.android.settings.spa.system.SystemMainPageProvider import com.android.settingslib.spa.framework.common.SettingsPageProviderRepository import com.android.settingslib.spa.framework.common.SpaEnvironment +import com.android.settingslib.spa.framework.common.SpaLogger import com.android.settingslib.spa.framework.common.createSettingsPage import com.android.settingslib.spaprivileged.template.app.TogglePermissionAppListProvider import com.android.settingslib.spaprivileged.template.app.TogglePermissionAppListTemplate @@ -90,5 +92,8 @@ open class SettingsSpaEnvironment(context: Context) : SpaEnvironment(context) { ), ) } - override val logger = SpaLogProvider + override val logger = + if (FeatureFlagUtils.isEnabled(context, FeatureFlagUtils.SETTINGS_ENABLE_SPA_METRICS)) + SpaLogProvider + else object: SpaLogger {} }