PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bug preventing users from clicking settings suggestions twice

Browse Source 
In an attempt to fix a monkey test crash which would open a
suggestion, click back and tap the same one again. The change
unfortunately prevented this for all users, but was not caught
because of a debug flag set on my device. A unit test will be added
to master to catch such cases, as tracked by this bug:
b/31937112

Change-Id: Ib1cff07e54903df687454bdbf2ed1416485ab34f
Fixes: 31926102
Test: Manual
This commit is contained in:
Matthew Fritze
2016-10-04 13:39:27 -07:00
parent 9c54a67d66
commit f265dbc447
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/com/android/settings/SettingsActivity.java
View File

@@ -1273,11 +1273,7 @@ public class SettingsActivity extends SettingsDrawerActivity
if (intent == null || ActivityManager.isUserAMonkey()) { if (intent == null || ActivityManager.isUserAMonkey()) {
return; return;
} }
final ComponentName componentName = intent.getComponent(); mCurrentSuggestion = intent.getComponent();
if (componentName.equals(mCurrentSuggestion)) {
return;
}
mCurrentSuggestion = componentName;
startActivityForResult(intent, REQUEST_SUGGESTION); startActivityForResult(intent, REQUEST_SUGGESTION);
} }