PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Change title to aspect ratio (experimental)" into udc-qpr-dev

Browse Source
This commit is contained in:
Graciela Putri
2023-09-21 18:25:20 +00:00
committed by Android (Google) Code Review
parent 8a7228ac82 bbb58cac69
commit f1c7bf3440
6 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
res/xml/apps.xml
View File

@@ -116,7 +116,7 @@
<Preference
android:key="aspect_ratio_apps"
android:title="@string/aspect_ratio_title"
android:title="@string/aspect_ratio_experimental_title"
android:summary="@string/summary_placeholder"
android:order="22"
settings:controller="com.android.settings.applications.appcompat.UserAspectRatioAppsPreferenceController"

2
res/xml/user_aspect_ratio_details.xml
View File

@@ -19,7 +19,7 @@
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:settings="http://schemas.android.com/apk/res-auto"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:title="@string/aspect_ratio_title">
android:title="@string/aspect_ratio_experimental_title">
<com.android.settingslib.widget.ActionButtonsPreference
android:key="header_view" />

2
src/com/android/settings/spa/app/appcompat/UserAspectRatioAppPreference.kt
View File

@@ -43,7 +43,7 @@ fun UserAspectRatioAppPreference(app: ApplicationInfo) {
if (!presenter.isAvailableFlow.collectAsStateWithLifecycle(initialValue = false).value) return
Preference(object : PreferenceModel {
override val title = stringResource(R.string.aspect_ratio_title)
override val title = stringResource(R.string.aspect_ratio_experimental_title)
override val summary = presenter.summaryFlow.collectAsStateWithLifecycle(
initialValue = stringResource(R.string.summary_placeholder),
)

4
src/com/android/settings/spa/app/appcompat/UserAspectRatioAppsPageProvider.kt
View File

@@ -83,7 +83,7 @@ object UserAspectRatioAppsPageProvider : SettingsPageProvider {
@VisibleForTesting
fun EntryItem() =
Preference(object : PreferenceModel {
override val title = stringResource(R.string.aspect_ratio_title)
override val title = stringResource(R.string.aspect_ratio_experimental_title)
override val summary = getSummary().toState()
override val onClick = navigator(name)
})
@@ -105,7 +105,7 @@ fun UserAspectRatioAppList(
= { AppList() },
) {
AppListPage(
title = stringResource(R.string.aspect_ratio_title),
title = stringResource(R.string.aspect_ratio_experimental_title),
listModel = rememberContext(::UserAspectRatioAppListModel),
appList = appList,
header = {

2
tests/spa_unit/src/com/android/settings/spa/app/appcompat/UserAspectRatioAppPreferenceTest.kt
View File

@@ -145,7 +145,7 @@ class UserAspectRatioAppPreferenceTest {
composeTestRule.onNode(
hasTextExactly(
context.getString(R.string.aspect_ratio_title),
context.getString(R.string.aspect_ratio_experimental_title),
context.getString(R.string.user_aspect_ratio_app_default)
),
).assertIsDisplayed().assertIsEnabled()

7
tests/spa_unit/src/com/android/settings/spa/app/appcompat/UserAspectRatioAppsPageProviderTest.kt
View File

@@ -60,7 +60,7 @@ class UserAspectRatioAppsPageProviderTest {
@Test
fun injectEntry_title() {
setInjectEntry()
composeTestRule.onNodeWithText(context.getString(R.string.aspect_ratio_title))
composeTestRule.onNodeWithText(context.getString(R.string.aspect_ratio_experimental_title))
.assertIsDisplayed()
}
@@ -75,7 +75,8 @@ class UserAspectRatioAppsPageProviderTest {
@Test
fun injectEntry_onClick_navigate() {
setInjectEntry()
composeTestRule.onNodeWithText(context.getString(R.string.aspect_ratio_title)).performClick()
composeTestRule.onNodeWithText(context.getString(R.string.aspect_ratio_experimental_title))
.performClick()
assertThat(fakeNavControllerWrapper.navigateCalledWith).isEqualTo("UserAspectRatioAppsPage")
}
@@ -93,7 +94,7 @@ class UserAspectRatioAppsPageProviderTest {
UserAspectRatioAppList {}
}
composeTestRule.onNodeWithText(context.getString(R.string.aspect_ratio_title))
composeTestRule.onNodeWithText(context.getString(R.string.aspect_ratio_experimental_title))
.assertIsDisplayed()
}