Improve settings cold start latency.
- Move view initialization from onViewCreated to onCreateView. This doesn't really improve anything, it simply aligns the code more with view's lifecycle management. - Move dashboard category init into background. The init contains logic invoking packageManager, which can be very expensive. - Remove any call to DashboardFeatureProvider from SummaryLoader, and delay the getCategory call until someone calls setListener(). - call updateCategory() from background thread. Test: rerun app launch test. Avg latency drops back to pre-suggestion-v2 level. Test: robotest Fixes: 68761512 Change-Id: I5ec85af08e7b610786e439bda93b3651f5975593
This commit is contained in:
@@ -16,6 +16,10 @@
|
||||
|
||||
package com.android.settings.dashboard;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
import static org.mockito.Mockito.verifyZeroInteractions;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
import android.app.Activity;
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
@@ -23,6 +27,7 @@ import android.content.Intent;
|
||||
import com.android.settings.TestConfig;
|
||||
import com.android.settings.testutils.FakeFeatureFactory;
|
||||
import com.android.settings.testutils.SettingsRobolectricTestRunner;
|
||||
import com.android.settingslib.drawer.CategoryKey;
|
||||
import com.android.settingslib.drawer.DashboardCategory;
|
||||
import com.android.settingslib.drawer.Tile;
|
||||
|
||||
@@ -35,12 +40,6 @@ import org.mockito.MockitoAnnotations;
|
||||
import org.robolectric.Robolectric;
|
||||
import org.robolectric.annotation.Config;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
|
||||
import static com.google.common.truth.Truth.assertThat;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
@RunWith(SettingsRobolectricTestRunner.class)
|
||||
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
||||
public class SummaryLoaderTest {
|
||||
@@ -65,14 +64,14 @@ public class SummaryLoaderTest {
|
||||
mCallbackInvoked = false;
|
||||
|
||||
final Activity activity = Robolectric.buildActivity(Activity.class).get();
|
||||
final List<DashboardCategory> categories = new ArrayList<>();
|
||||
mSummaryLoader = new SummaryLoader(activity, categories);
|
||||
mSummaryLoader.setSummaryConsumer(new SummaryLoader.SummaryConsumer() {
|
||||
@Override
|
||||
public void notifySummaryChanged(Tile tile) {
|
||||
mCallbackInvoked = true;
|
||||
}
|
||||
});
|
||||
|
||||
mSummaryLoader = new SummaryLoader(activity, CategoryKey.CATEGORY_HOMEPAGE);
|
||||
mSummaryLoader.setSummaryConsumer(tile -> mCallbackInvoked = true);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void newInstance_shouldNotLoadCategory() {
|
||||
verifyZeroInteractions(mFeatureFactory.dashboardFeatureProvider);
|
||||
}
|
||||
|
||||
@Test
|
||||
|
Reference in New Issue
Block a user