Merge "Ignore any summary provided for injected settings"

This commit is contained in:
Tom O'Neill
2014-03-03 18:49:42 +00:00
committed by Android (Google) Code Review

View File

@@ -244,12 +244,12 @@ class SettingsInjector {
}
/**
* Adds an injected setting to the root with status "Loading...".
* Adds an injected setting to the root.
*/
private Preference addServiceSetting(List<Preference> prefs, InjectedSetting info) {
Preference pref = new Preference(mContext);
pref.setTitle(info.title);
pref.setSummary(R.string.location_loading_injected_setting);
pref.setSummary(null);
PackageManager pm = mContext.getPackageManager();
Drawable icon = pm.getDrawable(info.packageName, info.iconId, null);
pref.setIcon(icon);
@@ -425,12 +425,11 @@ class SettingsInjector {
@Override
public void handleMessage(Message msg) {
Bundle bundle = msg.getData();
String summary = bundle.getString(SettingInjectorService.SUMMARY_KEY);
boolean enabled = bundle.getBoolean(SettingInjectorService.ENABLED_KEY, true);
if (Log.isLoggable(TAG, Log.DEBUG)) {
Log.d(TAG, setting + ": received " + msg + ", bundle: " + bundle);
}
preference.setSummary(summary);
preference.setSummary(null);
preference.setEnabled(enabled);
mHandler.sendMessage(
mHandler.obtainMessage(WHAT_RECEIVED_STATUS, Setting.this));