From fa18f4de06bbdeedf759c20d5adcb8fff667f4fa Mon Sep 17 00:00:00 2001 From: Bonian Chen Date: Mon, 21 Mar 2022 01:05:23 +0000 Subject: [PATCH] Revert "[Settings] Resolves unsynced infomation between status bar and settings" This reverts commit 4f3ac2fcbd733fcf96633ac610e403259c94666b. Reason for revert: Should be fixed by ag/15270340, and removing this one helps to avoid UI from shifting when user click on buttons within "Internet" settings UI (b/222805255). Change-Id: I149f4beab329a6ba69434c6d923e1d6bc054b27d --- .../network/SubscriptionsPreferenceController.java | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/com/android/settings/network/SubscriptionsPreferenceController.java b/src/com/android/settings/network/SubscriptionsPreferenceController.java index 87c46974fb9..218e3ecb4ba 100644 --- a/src/com/android/settings/network/SubscriptionsPreferenceController.java +++ b/src/com/android/settings/network/SubscriptionsPreferenceController.java @@ -41,7 +41,6 @@ import android.telephony.TelephonyDisplayInfo; import android.telephony.TelephonyManager; import android.text.Html; import android.util.ArraySet; -import android.util.Log; import androidx.annotation.VisibleForTesting; import androidx.collection.ArrayMap; @@ -194,7 +193,6 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl mSignalStrengthListener.pause(); mTelephonyDisplayInfoListener.pause(); unRegisterReceiver(); - resetProviderPreferenceSummary(); } @Override @@ -276,7 +274,6 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl String result = mSubsPrefCtrlInjector.getNetworkType( mContext, mConfig, mTelephonyDisplayInfo, subId, isCarrierNetworkActive); if (mSubsPrefCtrlInjector.isActiveCellularNetwork(mContext) || isCarrierNetworkActive) { - Log.i(TAG, "Active cellular network or active carrier network."); result = mContext.getString(R.string.preference_summary_default_combination, mContext.getString(R.string.mobile_data_connection_active), result); } else if (!isDataInService) { @@ -327,13 +324,6 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl return icon; } - private void resetProviderPreferenceSummary() { - if (mSubsGearPref == null) { - return; - } - mSubsGearPref.setSummary(""); - } - @VisibleForTesting boolean shouldInflateSignalStrength(int subId) { return SignalStrengthUtil.shouldInflateSignalStrength(mContext, subId);