Settings: Protect sensitive data on the about phone

- Hide some personal info like phone number and IMEI.
- IMEI shows on a tap, so why not.
- Avoid showing this in screenshot/screenrecord

Co-authored-by: El Dainosor <eldainosor@gmail.com>
Change-Id: I45b7898da440c36045aec64a0a86fb804116cd9d
This commit is contained in:
althafvly
2019-10-25 07:16:45 +00:00
committed by Mohammed Althaf T
parent 0960af0bf3
commit ed95f35423
4 changed files with 24 additions and 6 deletions

View File

@@ -56,7 +56,24 @@ public class PhoneNumberPreferenceController extends BasePreferenceController {
@Override
public CharSequence getSummary() {
return getFirstPhoneNumber();
return mContext.getString(R.string.device_info_protected_single_press);
}
@Override
public boolean handlePreferenceTreeClick(Preference preference) {
String prefKey = preference.getKey();
if (prefKey.startsWith(KEY_PHONE_NUMBER)) {
int simSlotNumber = 0;
if (!TextUtils.equals(prefKey, KEY_PHONE_NUMBER)) {
// Get multisim slot number from preference key.
// Multisim preference key is KEY_PHONE_NUMBER + simSlotNumber
simSlotNumber = Integer.parseInt(
prefKey.replaceAll("[^0-9]", ""));
}
final Preference simStatusPreference = mPreferenceList.get(simSlotNumber);
simStatusPreference.setSummary(getPhoneNumber(simSlotNumber));
}
return super.handlePreferenceTreeClick(preference);
}
@Override
@@ -73,7 +90,6 @@ public class PhoneNumberPreferenceController extends BasePreferenceController {
final Preference multiSimPreference = createNewPreference(screen.getContext());
multiSimPreference.setOrder(phonePreferenceOrder + simSlotNumber);
multiSimPreference.setKey(KEY_PHONE_NUMBER + simSlotNumber);
multiSimPreference.setSelectable(false);
category.addPreference(multiSimPreference);
mPreferenceList.add(multiSimPreference);
}
@@ -84,7 +100,7 @@ public class PhoneNumberPreferenceController extends BasePreferenceController {
for (int simSlotNumber = 0; simSlotNumber < mPreferenceList.size(); simSlotNumber++) {
final Preference simStatusPreference = mPreferenceList.get(simSlotNumber);
simStatusPreference.setTitle(getPreferenceTitle(simSlotNumber));
simStatusPreference.setSummary(getPhoneNumber(simSlotNumber));
simStatusPreference.setSummary(getSummary());
}
}

View File

@@ -96,7 +96,7 @@ public class ImeiInfoPreferenceController extends BasePreferenceController {
@Override
public CharSequence getSummary() {
return getSummary(0);
return mContext.getString(R.string.device_info_protected_single_press);
}
private CharSequence getSummary(int simSlot) {
@@ -113,6 +113,7 @@ public class ImeiInfoPreferenceController extends BasePreferenceController {
}
ImeiInfoDialogFragment.show(mFragment, simSlot, preference.getTitle().toString());
preference.setSummary(getSummary(simSlot));
return true;
}
@@ -129,7 +130,7 @@ public class ImeiInfoPreferenceController extends BasePreferenceController {
private void updatePreference(Preference preference, int simSlot) {
preference.setTitle(getTitle(simSlot));
preference.setSummary(getSummary(simSlot));
preference.setSummary(getSummary());
}
private CharSequence getTitleForGsmPhone(int simSlot) {