PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't allow CBRS subscriptions to be set as default for Calls/SMS

Browse Source 
CBRS subscriptions (also known as "opportunistic" in the code base) are
data-only and it should not be possible to try to set them as the
default for Calls or SMS.

Fixes: 125855327
Test: make RunSettingsRoboTests
Change-Id: Ie20ef21ccc7b27315089f6a61cceb6e1512ec373
This commit is contained in:
Antony Sargent
2019-04-05 09:55:12 -07:00
parent 44427259e8
commit ed5c2a1b10
2 changed files with 42 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/com/android/settings/network/telephony/DefaultSubscriptionController.java
View File

@@ -28,6 +28,7 @@ import com.android.settings.core.BasePreferenceController;
import com.android.settings.network.SubscriptionUtil;
import com.android.settings.network.SubscriptionsChangeListener;
import java.util.ArrayList;
import java.util.List;
import androidx.lifecycle.Lifecycle;
@@ -124,27 +125,29 @@ public abstract class DefaultSubscriptionController extends BasePreferenceContro
// We'll have one entry for each available subscription, plus one for a "ask me every
// time" entry at the end.
final CharSequence[] displayNames = new CharSequence[subs.size() + 1];
final CharSequence[] subscriptionIds = new CharSequence[subs.size() + 1];
final ArrayList<CharSequence> displayNames = new ArrayList<>();
final ArrayList<CharSequence> subscriptionIds = new ArrayList<>();
final int serviceDefaultSubId = getDefaultSubscriptionId();
boolean subIsAvailable = false;
int i = 0;
for (; i < subs.size(); i++) {
displayNames[i] = subs.get(i).getDisplayName();
final int subId = subs.get(i).getSubscriptionId();
subscriptionIds[i] = Integer.toString(subId);
for (SubscriptionInfo sub : subs) {
if (sub.isOpportunistic()) {
continue;
}
displayNames.add(sub.getDisplayName());
final int subId = sub.getSubscriptionId();
subscriptionIds.add(Integer.toString(subId));
if (subId == serviceDefaultSubId) {
subIsAvailable = true;
}
}
// Add the extra "Ask every time" value at the end.
displayNames[i] = mContext.getString(R.string.calls_and_sms_ask_every_time);
subscriptionIds[i] = Integer.toString(SubscriptionManager.INVALID_SUBSCRIPTION_ID);
displayNames.add(mContext.getString(R.string.calls_and_sms_ask_every_time));
subscriptionIds.add(Integer.toString(SubscriptionManager.INVALID_SUBSCRIPTION_ID));
mPreference.setEntries(displayNames);
mPreference.setEntryValues(subscriptionIds);
mPreference.setEntries(displayNames.toArray(new CharSequence[0]));
mPreference.setEntryValues(subscriptionIds.toArray(new CharSequence[0]));
if (subIsAvailable) {
mPreference.setValue(Integer.toString(serviceDefaultSubId));