PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Mass clean up: don't cast class when not needed."

Browse Source
This commit is contained in:
Fan Zhang
2019-02-14 23:13:44 +00:00
committed by Android (Google) Code Review
parent a670f752ce 7db118e367
commit ed2db4aaa1
77 changed files with 153 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/accounts/AccountHeaderPreferenceController.java
View File

@@ -84,7 +84,7 @@ public class AccountHeaderPreferenceController extends AbstractPreferenceControl
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mHeaderPreference = (LayoutPreference) screen.findPreference(KEY_ACCOUNT_HEADER);
mHeaderPreference = screen.findPreference(KEY_ACCOUNT_HEADER);
}
@Override

3
src/com/android/settings/accounts/RemoveAccountPreferenceController.java
View File

@@ -66,8 +66,7 @@ public class RemoveAccountPreferenceController extends AbstractPreferenceControl
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
final LayoutPreference removeAccountPreference =
(LayoutPreference) screen.findPreference(KEY_REMOVE_ACCOUNT);
final LayoutPreference removeAccountPreference = screen.findPreference(KEY_REMOVE_ACCOUNT);
Button removeAccountButton = (Button) removeAccountPreference.findViewById(R.id.button);
removeAccountButton.setOnClickListener(this);
}

2
src/com/android/settings/applications/RecentAppsPreferenceController.java
View File

@@ -138,7 +138,7 @@ public class RecentAppsPreferenceController extends AbstractPreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
mCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mCategory = screen.findPreference(getPreferenceKey());
mSeeAllPref = screen.findPreference(KEY_SEE_ALL);
mDivider = screen.findPreference(KEY_DIVIDER);
super.displayPreference(screen);

2
src/com/android/settings/applications/appinfo/AppHeaderViewPreferenceController.java
View File

@@ -63,7 +63,7 @@ public class AppHeaderViewPreferenceController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mHeader = (LayoutPreference) screen.findPreference(KEY_HEADER);
mHeader = screen.findPreference(KEY_HEADER);
final Activity activity = mParent.getActivity();
mEntityHeaderController = EntityHeaderController
.newInstance(activity, mParent, mHeader.findViewById(R.id.entity_header))

2
src/com/android/settings/applications/appinfo/InstantAppButtonsPreferenceController.java
View File

@@ -77,7 +77,7 @@ public class InstantAppButtonsPreferenceController extends BasePreferenceControl
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (LayoutPreference) screen.findPreference(KEY_INSTANT_APP_BUTTONS);
mPreference = screen.findPreference(KEY_INSTANT_APP_BUTTONS);
initButtons(mPreference.findViewById(R.id.instant_app_button_container));
}

2
src/com/android/settings/applications/managedomainurls/DomainAppPreferenceController.java
View File

@@ -63,7 +63,7 @@ public class DomainAppPreferenceController extends BasePreferenceController impl
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mDomainAppList = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mDomainAppList = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/applications/specialaccess/deviceadmin/DeviceAdminListPreferenceController.java
View File

@@ -116,7 +116,7 @@ public class DeviceAdminListPreferenceController extends BasePreferenceControlle
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mPreferenceGroup = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/biometrics/face/FaceSettingsAttentionPreferenceController.java
View File

@@ -56,7 +56,7 @@ public class FaceSettingsAttentionPreferenceController extends TogglePreferenceC
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (SwitchPreference) screen.findPreference(KEY);
mPreference = screen.findPreference(KEY);
}
@Override

2
src/com/android/settings/biometrics/face/FaceSettingsVideoPreferenceController.java
View File

@@ -44,7 +44,7 @@ public class FaceSettingsVideoPreferenceController extends VideoPreferenceContro
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mVideoPreference = (VideoPreference) screen.findPreference(KEY_VIDEO);
mVideoPreference = screen.findPreference(KEY_VIDEO);
mVideoPreference.onViewVisible(false /* paused */);
}
}

3
src/com/android/settings/bluetooth/BluetoothDetailsHeaderController.java
View File

@@ -52,8 +52,7 @@ public class BluetoothDetailsHeaderController extends BluetoothDetailsController
@Override
protected void init(PreferenceScreen screen) {
final LayoutPreference headerPreference =
(LayoutPreference) screen.findPreference(KEY_DEVICE_HEADER);
final LayoutPreference headerPreference = screen.findPreference(KEY_DEVICE_HEADER);
mHeaderController = EntityHeaderController.newInstance(mFragment.getActivity(), mFragment,
headerPreference.findViewById(R.id.entity_header));
screen.addPreference(headerPreference);

2
src/com/android/settings/connecteddevice/AddDevicePreferenceController.java
View File

@@ -68,7 +68,7 @@ public class AddDevicePreferenceController extends BasePreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreference = (Preference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
}

2
src/com/android/settings/connecteddevice/AvailableMediaDeviceGroupController.java
View File

@@ -84,7 +84,7 @@ public class AvailableMediaDeviceGroupController extends BasePreferenceControlle
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(KEY);
mPreferenceGroup = screen.findPreference(KEY);
mPreferenceGroup.setVisible(false);
updateTitle();
mBluetoothDeviceUpdater.setPrefContext(screen.getContext());

2
src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java
View File

@@ -74,7 +74,7 @@ public class ConnectedDeviceGroupController extends BasePreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(KEY);
mPreferenceGroup = screen.findPreference(KEY);
mPreferenceGroup.setVisible(false);
final Context context = screen.getContext();

2
src/com/android/settings/connecteddevice/PreviouslyConnectedDevicePreferenceController.java
View File

@@ -60,7 +60,7 @@ public class PreviouslyConnectedDevicePreferenceController extends BasePreferenc
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mPreferenceGroup = screen.findPreference(getPreferenceKey());
mPreferenceGroup.setVisible(false);
if (isAvailable()) {

2
src/com/android/settings/connecteddevice/SavedDeviceGroupController.java
View File

@@ -74,7 +74,7 @@ public class SavedDeviceGroupController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
if (isAvailable()) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(KEY);
mPreferenceGroup = screen.findPreference(KEY);
mPreferenceGroup.setVisible(false);
final Context context = screen.getContext();

2
src/com/android/settings/connecteddevice/usb/UsbDetailsDataRoleController.java
View File

@@ -57,7 +57,7 @@ public class UsbDetailsDataRoleController extends UsbDetailsController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mPreferenceCategory = screen.findPreference(getPreferenceKey());
mHostPref = makeRadioPreference(UsbBackend.dataRoleToString(DATA_ROLE_HOST),
R.string.usb_control_host);
mDevicePref = makeRadioPreference(UsbBackend.dataRoleToString(DATA_ROLE_DEVICE),

4
src/com/android/settings/connecteddevice/usb/UsbDetailsFunctionsController.java
View File

@@ -68,14 +68,14 @@ public class UsbDetailsFunctionsController extends UsbDetailsController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mProfilesContainer = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mProfilesContainer = screen.findPreference(getPreferenceKey());
}
/**
* Gets a switch preference for the particular option, creating it if needed.
*/
private RadioButtonPreference getProfilePreference(String key, int titleId) {
RadioButtonPreference pref = (RadioButtonPreference) mProfilesContainer.findPreference(key);
RadioButtonPreference pref = mProfilesContainer.findPreference(key);
if (pref == null) {
pref = new RadioButtonPreference(mProfilesContainer.getContext());
pref.setKey(key);

3
src/com/android/settings/connecteddevice/usb/UsbDetailsHeaderController.java
View File

@@ -40,8 +40,7 @@ public class UsbDetailsHeaderController extends UsbDetailsController {
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
final LayoutPreference headerPreference =
(LayoutPreference) screen.findPreference(KEY_DEVICE_HEADER);
final LayoutPreference headerPreference = screen.findPreference(KEY_DEVICE_HEADER);
mHeaderController = EntityHeaderController.newInstance(mFragment.getActivity(), mFragment,
headerPreference.findViewById(R.id.entity_header));
}

2
src/com/android/settings/connecteddevice/usb/UsbDetailsPowerRoleController.java
View File

@@ -58,7 +58,7 @@ public class UsbDetailsPowerRoleController extends UsbDetailsController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mPreferenceCategory = screen.findPreference(getPreferenceKey());
mSwitchPreference = new SwitchPreference(mPreferenceCategory.getContext());
mSwitchPreference.setTitle(R.string.usb_use_power_only);
mSwitchPreference.setOnPreferenceClickListener(this);

2
src/com/android/settings/development/AbstractBluetoothA2dpPreferenceController.java
View File

@@ -65,7 +65,7 @@ public abstract class AbstractBluetoothA2dpPreferenceController extends
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ListPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
// Set a default value because BluetoothCodecConfig is null initially.
mPreference.setValue(mListValues[getDefaultIndex()]);

2
src/com/android/settings/development/OemUnlockPreferenceController.java
View File

@@ -77,7 +77,7 @@ public class OemUnlockPreferenceController extends DeveloperOptionsPreferenceCon
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (RestrictedSwitchPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

6
src/com/android/settings/development/OverlayCategoryPreferenceController.java
View File

@@ -41,7 +41,6 @@ import com.android.settingslib.development.DeveloperOptionsPreferenceController;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Optional;
/**
* Preference controller to allow users to choose an overlay from a list for a given category.
@@ -91,7 +90,7 @@ public class OverlayCategoryPreferenceController extends DeveloperOptionsPrefere
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
setPreference((ListPreference) screen.findPreference(getPreferenceKey()));
setPreference(screen.findPreference(getPreferenceKey()));
}
@VisibleForTesting
@@ -124,7 +123,8 @@ public class OverlayCategoryPreferenceController extends DeveloperOptionsPrefere
if (PACKAGE_DEVICE_DEFAULT.equals(packageName)) {
return mOverlayManager.setEnabled(currentPackageName, false, USER_SYSTEM);
} else {
return mOverlayManager.setEnabledExclusiveInCategory(packageName, USER_SYSTEM);
return mOverlayManager.setEnabledExclusiveInCategory(packageName,
USER_SYSTEM);
}
} catch (RemoteException re) {
Log.w(TAG, "Error enabling overlay.", re);

2
src/com/android/settings/development/PictureColorModePreferenceController.java
View File

@@ -56,7 +56,7 @@ public class PictureColorModePreferenceController extends DeveloperOptionsPrefer
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ColorModePreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
if (mPreference != null) {
mPreference.updateCurrentAndSupported();
}

2
src/com/android/settings/development/StayAwakePreferenceController.java
View File

@@ -72,7 +72,7 @@ public class StayAwakePreferenceController extends DeveloperOptionsPreferenceCon
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (RestrictedSwitchPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/development/featureflags/FeatureFlagsPreferenceController.java
View File

@@ -45,7 +45,7 @@ public class FeatureFlagsPreferenceController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mGroup = screen.findPreference(getPreferenceKey());
}
@Override

3
src/com/android/settings/development/gamedriver/GameDriverAppPreferenceController.java
View File

@@ -113,7 +113,7 @@ public class GameDriverAppPreferenceController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mPreferenceGroup = screen.findPreference(getPreferenceKey());
final Context context = mPreferenceGroup.getContext();
for (AppInfo appInfo : mAppInfos) {
@@ -179,6 +179,7 @@ public class GameDriverAppPreferenceController extends BasePreferenceController
info = applicationInfo;
label = packageManager.getApplicationLabel(applicationInfo).toString();
}
final ApplicationInfo info;
final String label;
}

2
src/com/android/settings/deviceinfo/storage/AutomaticStorageManagementSwitchPreferenceController.java
View File

@@ -61,7 +61,7 @@ public class AutomaticStorageManagementSwitchPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mSwitch = (MasterSwitchPreference) screen.findPreference(getPreferenceKey());
mSwitch = screen.findPreference(getPreferenceKey());
}
@Override

15
src/com/android/settings/deviceinfo/storage/SecondaryUserController.java
View File

@@ -49,8 +49,10 @@ public class SecondaryUserController extends AbstractPreferenceController implem
private static final int USER_PROFILE_INSERTION_LOCATION = 6;
private static final int SIZE_NOT_SET = -1;
private @NonNull UserInfo mUser;
private @Nullable StorageItemPreference mStoragePreference;
private @NonNull
UserInfo mUser;
private @Nullable
StorageItemPreference mStoragePreference;
private Drawable mUserIcon;
private long mSize;
private long mTotalSizeBytes;
@@ -58,6 +60,7 @@ public class SecondaryUserController extends AbstractPreferenceController implem
/**
* Adds the appropriate controllers to a controller list for handling all secondary users on
* a device.
*
* @param context Context for initializing the preference controllers.
* @param userManager UserManagerWrapper for figuring out which controllers to add.
*/
@@ -91,6 +94,7 @@ public class SecondaryUserController extends AbstractPreferenceController implem
/**
* Constructor for a given secondary user.
*
* @param context Context to initialize the underlying {@link AbstractPreferenceController}.
* @param info {@link UserInfo} for the secondary user which this controllers covers.
*/
@@ -107,7 +111,7 @@ public class SecondaryUserController extends AbstractPreferenceController implem
mStoragePreference = new StorageItemPreference(screen.getContext());
PreferenceGroup group =
(PreferenceGroup) screen.findPreference(TARGET_PREFERENCE_GROUP_KEY);
screen.findPreference(TARGET_PREFERENCE_GROUP_KEY);
mStoragePreference.setTitle(mUser.name);
mStoragePreference.setKey(PREFERENCE_KEY_BASE + mUser.id);
if (mSize != SIZE_NOT_SET) {
@@ -140,6 +144,7 @@ public class SecondaryUserController extends AbstractPreferenceController implem
/**
* Sets the size for the preference.
*
* @param size Size in bytes.
*/
public void setSize(long size) {
@@ -151,6 +156,7 @@ public class SecondaryUserController extends AbstractPreferenceController implem
/**
* Sets the total size for the preference for the progress bar.
*
* @param totalSizeBytes Total size in bytes.
*/
public void setTotalSize(long totalSizeBytes) {
@@ -185,8 +191,7 @@ public class SecondaryUserController extends AbstractPreferenceController implem
@Override
public void displayPreference(PreferenceScreen screen) {
PreferenceGroup group =
(PreferenceGroup) screen.findPreference(TARGET_PREFERENCE_GROUP_KEY);
final PreferenceGroup group = screen.findPreference(TARGET_PREFERENCE_GROUP_KEY);
if (group == null) {
return;
}

14
src/com/android/settings/deviceinfo/storage/StorageItemPreferenceController.java
View File

@@ -235,13 +235,13 @@ public class StorageItemPreferenceController extends AbstractPreferenceControlle
@Override
public void displayPreference(PreferenceScreen screen) {
mScreen = screen;
mPhotoPreference = (StorageItemPreference) screen.findPreference(PHOTO_KEY);
mAudioPreference = (StorageItemPreference) screen.findPreference(AUDIO_KEY);
mGamePreference = (StorageItemPreference) screen.findPreference(GAME_KEY);
mMoviesPreference = (StorageItemPreference) screen.findPreference(MOVIES_KEY);
mAppPreference = (StorageItemPreference) screen.findPreference(OTHER_APPS_KEY);
mSystemPreference = (StorageItemPreference) screen.findPreference(SYSTEM_KEY);
mFilePreference = (StorageItemPreference) screen.findPreference(FILES_KEY);
mPhotoPreference = screen.findPreference(PHOTO_KEY);
mAudioPreference = screen.findPreference(AUDIO_KEY);
mGamePreference = screen.findPreference(GAME_KEY);
mMoviesPreference = screen.findPreference(MOVIES_KEY);
mAppPreference = screen.findPreference(OTHER_APPS_KEY);
mSystemPreference = screen.findPreference(SYSTEM_KEY);
mFilePreference = screen.findPreference(FILES_KEY);
setFilesPreferenceVisibility();
}

3
src/com/android/settings/deviceinfo/storage/StorageSummaryDonutPreferenceController.java
View File

@@ -46,7 +46,6 @@ public class StorageSummaryDonutPreferenceController extends AbstractPreferenceC
/**
* Converts a used storage amount to a formatted text.
*
* @param context Context
* @param usedBytes used bytes of storage
* @return a formatted text.
*/
@@ -59,7 +58,7 @@ public class StorageSummaryDonutPreferenceController extends AbstractPreferenceC
@Override
public void displayPreference(PreferenceScreen screen) {
mSummary = (StorageSummaryDonutPreference) screen.findPreference("pref_summary");
mSummary = screen.findPreference("pref_summary");
mSummary.setEnabled(true);
}

3
src/com/android/settings/display/NightModePreferenceController.java
View File

@@ -52,8 +52,7 @@ public class NightModePreferenceController extends AbstractPreferenceController
setVisible(screen, KEY_NIGHT_MODE, false /* visible */);
return;
}
ListPreference mNightModePreference = (ListPreference) screen.findPreference(
KEY_NIGHT_MODE);
final ListPreference mNightModePreference = screen.findPreference(KEY_NIGHT_MODE);
if (mNightModePreference != null) {
final UiModeManager uiManager =
(UiModeManager) mContext.getSystemService(UI_MODE_SERVICE);

6
src/com/android/settings/dream/StartNowPreferenceController.java
View File

@@ -54,8 +54,8 @@ public class StartNowPreferenceController extends AbstractPreferenceController i
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
LayoutPreference pref = (LayoutPreference) screen.findPreference(getPreferenceKey());
Button startButton = (Button)pref.findViewById(R.id.dream_start_now_button);
LayoutPreference pref = screen.findPreference(getPreferenceKey());
Button startButton = pref.findViewById(R.id.dream_start_now_button);
startButton.setOnClickListener(v -> mBackend.startDreaming());
}
@@ -63,7 +63,7 @@ public class StartNowPreferenceController extends AbstractPreferenceController i
public void updateState(Preference preference) {
super.updateState(preference);
Button startButton = (Button)((LayoutPreference)preference)
Button startButton = ((LayoutPreference) preference)
.findViewById(R.id.dream_start_now_button);
startButton.setEnabled(mBackend.getWhenToDreamSetting() != DreamBackend.NEVER);
}

2
src/com/android/settings/fuelgauge/BatteryAppListPreferenceController.java
View File

@@ -143,7 +143,7 @@ public class BatteryAppListPreferenceController extends AbstractPreferenceContro
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPrefContext = screen.getContext();
mAppListGroup = (PreferenceGroup) screen.findPreference(mPreferenceKey);
mAppListGroup = screen.findPreference(mPreferenceKey);
}
@Override

2
src/com/android/settings/fuelgauge/batterysaver/BatterySaverButtonPreferenceController.java
View File

@@ -72,7 +72,7 @@ public class BatterySaverButtonPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (TwoStateButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/gestures/GesturePreferenceController.java
View File

@@ -51,7 +51,7 @@ public abstract class GesturePreferenceController extends TogglePreferenceContro
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mVideoPreference = (VideoPreference) screen.findPreference(getVideoPrefKey());
mVideoPreference = screen.findPreference(getVideoPrefKey());
}
}

24
src/com/android/settings/gestures/PreventRingingGesturePreferenceController.java
View File

@@ -45,9 +45,11 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
implements RadioButtonPreference.OnClickListener, LifecycleObserver, OnSaveInstanceState,
OnResume, OnPause, OnCreate, PreferenceControllerMixin {
@VisibleForTesting static final String KEY_VIBRATE = "prevent_ringing_option_vibrate";
@VisibleForTesting
static final String KEY_VIBRATE = "prevent_ringing_option_vibrate";
@VisibleForTesting static final String KEY_MUTE = "prevent_ringing_option_mute";
@VisibleForTesting
static final String KEY_MUTE = "prevent_ringing_option_mute";
private final String KEY_VIDEO_PAUSED = "key_video_paused";
private final String PREF_KEY_VIDEO = "gesture_prevent_ringing_video";
@@ -57,9 +59,12 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
private VideoPreference mVideoPreference;
private boolean mVideoPaused;
@VisibleForTesting PreferenceCategory mPreferenceCategory;
@VisibleForTesting RadioButtonPreference mVibratePref;
@VisibleForTesting RadioButtonPreference mMutePref;
@VisibleForTesting
PreferenceCategory mPreferenceCategory;
@VisibleForTesting
RadioButtonPreference mVibratePref;
@VisibleForTesting
RadioButtonPreference mMutePref;
private SettingObserver mSettingObserver;
@@ -75,8 +80,10 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreferenceCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
if (!isAvailable()) {
return;
}
mPreferenceCategory = screen.findPreference(getPreferenceKey());
mVibratePref = makeRadioPreference(KEY_VIBRATE, R.string.prevent_ringing_option_vibrate);
mMutePref = makeRadioPreference(KEY_MUTE, R.string.prevent_ringing_option_mute);
@@ -84,8 +91,7 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
mSettingObserver = new SettingObserver(mPreferenceCategory);
}
mVideoPreference = (VideoPreference) screen.findPreference(getVideoPrefKey());
}
mVideoPreference = screen.findPreference(getVideoPrefKey());
}
@Override

5
src/com/android/settings/gestures/PreventRingingSwitchPreferenceController.java
View File

@@ -41,7 +41,8 @@ public class PreventRingingSwitchPreferenceController extends AbstractPreference
private final Context mContext;
private SettingObserver mSettingObserver;
@VisibleForTesting SwitchBar mSwitch;
@VisibleForTesting
SwitchBar mSwitch;
public PreventRingingSwitchPreferenceController(Context context) {
super(context);
@@ -57,7 +58,7 @@ public class PreventRingingSwitchPreferenceController extends AbstractPreference
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
LayoutPreference pref = (LayoutPreference) screen.findPreference(getPreferenceKey());
LayoutPreference pref = screen.findPreference(getPreferenceKey());
if (pref != null) {
mSettingObserver = new SettingObserver(pref);
mSwitch = pref.findViewById(R.id.switch_bar);

3
src/com/android/settings/location/LocationForWorkPreferenceController.java
View File

@@ -57,8 +57,7 @@ public class LocationForWorkPreferenceController extends LocationBasePreferenceC
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference =
(RestrictedSwitchPreference) screen.findPreference(KEY_MANAGED_PROFILE_SWITCH);
mPreference = screen.findPreference(KEY_MANAGED_PROFILE_SWITCH);
}
@Override

3
src/com/android/settings/location/LocationServicePreferenceController.java
View File

@@ -84,8 +84,7 @@ public class LocationServicePreferenceController extends LocationBasePreferenceC
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mCategoryLocationServices =
(PreferenceCategory) screen.findPreference(KEY_LOCATION_SERVICES);
mCategoryLocationServices = screen.findPreference(KEY_LOCATION_SERVICES);
}
@Override

3
src/com/android/settings/location/RecentLocationAccessPreferenceController.java
View File

@@ -69,8 +69,7 @@ public class RecentLocationAccessPreferenceController extends AbstractPreference
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
final LayoutPreference preference = (LayoutPreference) screen.findPreference(
KEY_APPS_DASHBOARD);
final LayoutPreference preference = screen.findPreference(KEY_APPS_DASHBOARD);
final View view = preference.findViewById(R.id.app_entities_header);
mController = AppEntitiesHeaderController.newInstance(mContext, view)
.setHeaderTitleRes(R.string.location_category_recent_location_access)

2
src/com/android/settings/network/AirplaneModePreferenceController.java
View File

@@ -81,7 +81,7 @@ public class AirplaneModePreferenceController extends TogglePreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mAirplaneModePreference = (SwitchPreference) screen.findPreference(getPreferenceKey());
mAirplaneModePreference = screen.findPreference(getPreferenceKey());
}
}

2
src/com/android/settings/network/MultiNetworkHeaderController.java
View File

@@ -65,7 +65,7 @@ public class MultiNetworkHeaderController extends BasePreferenceController imple
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceCategory = (PreferenceCategory) screen.findPreference(mPreferenceKey);
mPreferenceCategory = screen.findPreference(mPreferenceKey);
mPreferenceCategory.setVisible(isAvailable());
mWifiController.displayPreference(screen);
mSubscriptionsController.displayPreference(screen);

3
src/com/android/settings/network/SubscriptionsPreferenceController.java
View File

@@ -107,7 +107,7 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl
@Override
public void displayPreference(PreferenceScreen screen) {
mPreferenceGroup = (PreferenceGroup) screen.findPreference(mPreferenceGroupKey);
mPreferenceGroup = screen.findPreference(mPreferenceGroupKey);
update();
}
@@ -209,7 +209,6 @@ public class SubscriptionsPreferenceController extends AbstractPreferenceControl
}
/**
*
* @return true if there are at least 2 available subscriptions.
*/
@Override

3
src/com/android/settings/nfc/AndroidBeamPreferenceController.java
View File

@@ -47,8 +47,7 @@ public class AndroidBeamPreferenceController extends BasePreferenceController
return;
}
final RestrictedPreference restrictedPreference =
(RestrictedPreference) screen.findPreference(getPreferenceKey());
final RestrictedPreference restrictedPreference = screen.findPreference(getPreferenceKey());
mAndroidBeamEnabler = new AndroidBeamEnabler(mContext, restrictedPreference);
}

2
src/com/android/settings/nfc/NfcForegroundPreferenceController.java
View File

@@ -81,7 +81,7 @@ public class NfcForegroundPreferenceController extends BasePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (DropDownPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
if (mPreference == null) {
return;
}

2
src/com/android/settings/nfc/NfcPaymentPreferenceController.java
View File

@@ -98,7 +98,7 @@ public class NfcPaymentPreferenceController extends BasePreferenceController imp
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (NfcPaymentPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
if (mPreference != null) {
mPreference.initialize(this);
}

8
src/com/android/settings/nfc/SecureNfcPreferenceController.java
View File

@@ -17,7 +17,6 @@ package com.android.settings.nfc;
import android.content.Context;
import android.nfc.NfcAdapter;
import android.os.SystemProperties;
import androidx.preference.PreferenceScreen;
import androidx.preference.SwitchPreference;
@@ -30,7 +29,6 @@ import com.android.settingslib.core.lifecycle.events.OnResume;
public class SecureNfcPreferenceController extends TogglePreferenceController
implements LifecycleObserver, OnResume, OnPause {
public static final String KEY_TOGGLE_NFC = "nfc_secure_setting";
private final NfcAdapter mNfcAdapter;
private SecureNfcEnabler mSecureNfcEnabler;
@@ -47,8 +45,7 @@ public class SecureNfcPreferenceController extends TogglePreferenceController
return;
}
final SwitchPreference switchPreference =
(SwitchPreference) screen.findPreference(getPreferenceKey());
final SwitchPreference switchPreference = screen.findPreference(getPreferenceKey());
mSecureNfcEnabler = new SecureNfcEnabler(mContext, switchPreference);
}
@@ -69,7 +66,8 @@ public class SecureNfcPreferenceController extends TogglePreferenceController
if (mNfcAdapter == null) {
return UNSUPPORTED_ON_DEVICE;
}
return mNfcAdapter.deviceSupportsNfcSecure() ? AVAILABLE
return mNfcAdapter.deviceSupportsNfcSecure()
? AVAILABLE
: UNSUPPORTED_ON_DEVICE;
}

2
src/com/android/settings/notification/BootSoundPreferenceController.java
View File

@@ -43,7 +43,7 @@ public class BootSoundPreferenceController extends AbstractPreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
SwitchPreference preference = (SwitchPreference) screen.findPreference(KEY_BOOT_SOUNDS);
SwitchPreference preference = screen.findPreference(KEY_BOOT_SOUNDS);
preference.setChecked(SystemProperties.getBoolean(PROPERTY_BOOT_SOUNDS, true));
}
}

4
src/com/android/settings/notification/LockScreenNotificationPreferenceController.java
View File

@@ -92,13 +92,13 @@ public class LockScreenNotificationPreferenceController extends AbstractPreferen
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mLockscreen = (RestrictedListPreference) screen.findPreference(mSettingKey);
mLockscreen = screen.findPreference(mSettingKey);
if (mLockscreen == null) {
Log.i(TAG, "Preference not found: " + mSettingKey);
return;
}
if (mProfileUserId != UserHandle.USER_NULL) {
mLockscreenProfile = (RestrictedListPreference) screen.findPreference(mWorkSettingKey);
mLockscreenProfile = screen.findPreference(mWorkSettingKey);
mLockscreenProfile.setRequiresActiveUnlockedProfile(true);
mLockscreenProfile.setProfileUserId(mProfileUserId);
} else {

2
src/com/android/settings/notification/RecentNotifyingAppsPreferenceController.java
View File

@@ -118,7 +118,7 @@ public class RecentNotifyingAppsPreferenceController extends AbstractPreferenceC
@Override
public void displayPreference(PreferenceScreen screen) {
mCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mCategory = screen.findPreference(getPreferenceKey());
mSeeAllPref = screen.findPreference(KEY_SEE_ALL);
mDivider = screen.findPreference(KEY_DIVIDER);
super.displayPreference(screen);

2
src/com/android/settings/notification/SoundPreferenceController.java
View File

@@ -67,7 +67,7 @@ public class SoundPreferenceController extends NotificationPreferenceController
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (NotificationSoundPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
public void updateState(Preference preference) {

2
src/com/android/settings/notification/VolumeSeekBarPreferenceController.java
View File

@@ -54,7 +54,7 @@ public abstract class VolumeSeekBarPreferenceController extends
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
if (isAvailable()) {
mPreference = (VolumeSeekBarPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setCallback(mVolumePreferenceCallback);
mPreference.setStream(getAudioStream());
mPreference.setMuteIcon(getMuteIcon());

2
src/com/android/settings/notification/WorkSoundPreferenceController.java
View File

@@ -100,7 +100,7 @@ public class WorkSoundPreferenceController extends AbstractPreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mWorkPreferenceCategory = (PreferenceGroup) screen.findPreference(KEY_WORK_CATEGORY);
mWorkPreferenceCategory = screen.findPreference(KEY_WORK_CATEGORY);
}
@Override

2
src/com/android/settings/notification/ZenAutomaticRuleSwitchPreferenceController.java
View File

@@ -56,7 +56,7 @@ public class ZenAutomaticRuleSwitchPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
LayoutPreference pref = (LayoutPreference) screen.findPreference(KEY);
LayoutPreference pref = screen.findPreference(KEY);
mSwitchBar = pref.findViewById(R.id.switch_bar);
if (mSwitchBar != null) {

2
src/com/android/settings/notification/ZenModeAutomaticRulesPreferenceController.java
View File

@@ -56,7 +56,7 @@ public class ZenModeAutomaticRulesPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceCategory = (PreferenceCategory) screen.findPreference(getPreferenceKey());
mPreferenceCategory = screen.findPreference(getPreferenceKey());
mPreferenceCategory.setPersistent(false);
}

2
src/com/android/settings/notification/ZenModePriorityCallsPreferenceController.java
View File

@@ -56,7 +56,7 @@ public class ZenModePriorityCallsPreferenceController extends AbstractZenModePre
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ListPreference) screen.findPreference(KEY);
mPreference = screen.findPreference(KEY);
}
@Override

2
src/com/android/settings/notification/ZenModePriorityMessagesPreferenceController.java
View File

@@ -56,7 +56,7 @@ public class ZenModePriorityMessagesPreferenceController extends AbstractZenMode
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ListPreference) screen.findPreference(KEY);
mPreference = screen.findPreference(KEY);
}
@Override

2
src/com/android/settings/notification/ZenModeVisEffectsAllPreferenceController.java
View File

@@ -49,7 +49,7 @@ public class ZenModeVisEffectsAllPreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnRadioButtonClickListener(this);
}

2
src/com/android/settings/notification/ZenModeVisEffectsCustomPreferenceController.java
View File

@@ -51,7 +51,7 @@ public class ZenModeVisEffectsCustomPreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnGearClickListener(p -> {
launchCustomSettings();

2
src/com/android/settings/notification/ZenModeVisEffectsNonePreferenceController.java
View File

@@ -49,7 +49,7 @@ public class ZenModeVisEffectsNonePreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnRadioButtonClickListener(this);
}

2
src/com/android/settings/notification/ZenRuleCustomPolicyPreferenceController.java
View File

@@ -39,7 +39,7 @@ public class ZenRuleCustomPolicyPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnGearClickListener(p -> {
setCustomPolicy();

2
src/com/android/settings/notification/ZenRuleDefaultPolicyPreferenceController.java
View File

@@ -40,7 +40,7 @@ public class ZenRuleDefaultPolicyPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnRadioButtonClickListener(p -> {
mRule.setZenPolicy(null);

2
src/com/android/settings/notification/ZenRuleVisEffectsAllPreferenceController.java
View File

@@ -41,7 +41,7 @@ public class ZenRuleVisEffectsAllPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnRadioButtonClickListener(p -> {
mMetricsFeatureProvider.action(mContext, SettingsEnums.ACTION_ZEN_SOUND_ONLY,

2
src/com/android/settings/notification/ZenRuleVisEffectsCustomPreferenceController.java
View File

@@ -41,7 +41,7 @@ public class ZenRuleVisEffectsCustomPreferenceController extends
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (ZenCustomRadioButtonPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
mPreference.setOnGearClickListener(p -> {
launchCustomSettings();

2
src/com/android/settings/privacy/PermissionBarChartPreferenceController.java
View File

@@ -73,7 +73,7 @@ public class PermissionBarChartPreferenceController extends BasePreferenceContro
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mBarChartPreference = (BarChartPreference) screen.findPreference(getPreferenceKey());
mBarChartPreference = screen.findPreference(getPreferenceKey());
final BarChartInfo info = new BarChartInfo.Builder()
.setTitle(R.string.permission_bar_chart_title)

2
src/com/android/settings/security/ChangeScreenLockPreferenceController.java
View File

@@ -79,7 +79,7 @@ public class ChangeScreenLockPreferenceController extends AbstractPreferenceCont
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (RestrictedPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/security/LockUnificationPreferenceController.java
View File

@@ -77,7 +77,7 @@ public class LockUnificationPreferenceController extends AbstractPreferenceContr
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mUnifyProfile = (RestrictedSwitchPreference) screen.findPreference(KEY_UNIFICATION);
mUnifyProfile = screen.findPreference(KEY_UNIFICATION);
}
public LockUnificationPreferenceController(Context context, SecuritySettings host) {

2
src/com/android/settings/security/OwnerInfoPreferenceController.java
View File

@@ -61,7 +61,7 @@ public class OwnerInfoPreferenceController extends AbstractPreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
mOwnerInfoPref = (RestrictedPreference) screen.findPreference(KEY_OWNER_INFO);
mOwnerInfoPref = screen.findPreference(KEY_OWNER_INFO);
}
@Override

2
src/com/android/settings/security/ResetCredentialsPreferenceController.java
View File

@@ -52,7 +52,7 @@ public class ResetCredentialsPreferenceController extends RestrictedEncryptionPr
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (RestrictedPreference) screen.findPreference(getPreferenceKey());
mPreference = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/security/trustagent/TrustAgentListPreferenceController.java
View File

@@ -91,7 +91,7 @@ public class TrustAgentListPreferenceController extends AbstractPreferenceContro
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mSecurityCategory = (PreferenceCategory) screen.findPreference(PREF_KEY_SECURITY_CATEGORY);
mSecurityCategory = screen.findPreference(PREF_KEY_SECURITY_CATEGORY);
updateTrustAgents();
}

2
src/com/android/settings/widget/VideoPreferenceController.java
View File

@@ -43,7 +43,7 @@ public class VideoPreferenceController extends BasePreferenceController implemen
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mVideoPreference = (VideoPreference) screen.findPreference(getPreferenceKey());
mVideoPreference = screen.findPreference(getPreferenceKey());
}
@Override

2
src/com/android/settings/wifi/WifiConnectionPreferenceController.java
View File

@@ -99,7 +99,7 @@ public class WifiConnectionPreferenceController extends AbstractPreferenceContro
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(mPreferenceGroupKey);
mPreferenceGroup = screen.findPreference(mPreferenceGroupKey);
mPrefContext = screen.getContext();
update();
}

2
src/com/android/settings/wifi/WifiMasterSwitchPreferenceController.java
View File

@@ -53,7 +53,7 @@ public class WifiMasterSwitchPreferenceController extends AbstractPreferenceCont
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mWifiPreference = (MasterSwitchPreference) screen.findPreference(KEY_TOGGLE_WIFI);
mWifiPreference = screen.findPreference(KEY_TOGGLE_WIFI);
}
@Override

2
src/com/android/settings/wifi/WifiWakeupPreferenceController.java
View File

@@ -62,7 +62,7 @@ public class WifiWakeupPreferenceController extends AbstractPreferenceController
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreference = (SwitchPreference) screen.findPreference(KEY_ENABLE_WIFI_WAKEUP);
mPreference = screen.findPreference(KEY_ENABLE_WIFI_WAKEUP);
updateState(mPreference);
}

4
src/com/android/settings/wifi/details/WifiDetailPreferenceController.java
View File

@@ -305,14 +305,14 @@ public class WifiDetailPreferenceController extends AbstractPreferenceController
mSubnetPref = screen.findPreference(KEY_SUBNET_MASK_PREF);
mDnsPref = screen.findPreference(KEY_DNS_PREF);
mIpv6Category = (PreferenceCategory) screen.findPreference(KEY_IPV6_CATEGORY);
mIpv6Category = screen.findPreference(KEY_IPV6_CATEGORY);
mIpv6AddressPref = screen.findPreference(KEY_IPV6_ADDRESSES_PREF);
mSecurityPref.setSummary(mAccessPoint.getSecurityString(/* concise */ false));
}
private void setupEntityHeader(PreferenceScreen screen) {
LayoutPreference headerPref = (LayoutPreference) screen.findPreference(KEY_HEADER);
LayoutPreference headerPref = screen.findPreference(KEY_HEADER);
mEntityHeaderController =
EntityHeaderController.newInstance(
mFragment.getActivity(), mFragment,

2
src/com/android/settings/wifi/p2p/P2pCategoryPreferenceController.java
View File

@@ -42,7 +42,7 @@ public abstract class P2pCategoryPreferenceController extends AbstractPreference
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mCategory = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mCategory = screen.findPreference(getPreferenceKey());
}
public void removeAllChildren() {

2
src/com/android/settings/wifi/savedaccesspoints/SavedAccessPointsPreferenceController.java
View File

@@ -76,7 +76,7 @@ public class SavedAccessPointsPreferenceController extends BasePreferenceControl
@Override
public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen);
mPreferenceGroup = (PreferenceGroup) screen.findPreference(getPreferenceKey());
mPreferenceGroup = screen.findPreference(getPreferenceKey());
}
@Override