From ba39bd6edd0323ba3a706031a3e147f021f54693 Mon Sep 17 00:00:00 2001 From: Song Chun Fan Date: Thu, 2 May 2024 00:46:22 +0000 Subject: [PATCH] [Install-unknown-apps] not include all the apps that have OP_REQUEST_INSTALL_PACKAGES granted Due to a recent change in AppOpsService, apps that share system_uid have all the appops granted. However, we don't want them to be listed under "Install unknown apps" if they don't explicitly declare the permission usage of REQUEST_INSTALL_PACKAGES in their manifest. This CL fixes that. Change-Id: I025bc17c335093ae5d3b15a3bef67d659c8f790f BUG: 338066634 BUG: 336677341 FIXES: 338066634 Test: manual by checking the Settings page --- .../settings/spa/app/specialaccess/InstallUnknownApps.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/com/android/settings/spa/app/specialaccess/InstallUnknownApps.kt b/src/com/android/settings/spa/app/specialaccess/InstallUnknownApps.kt index 3e9058f25ff..1446bbca5b4 100644 --- a/src/com/android/settings/spa/app/specialaccess/InstallUnknownApps.kt +++ b/src/com/android/settings/spa/app/specialaccess/InstallUnknownApps.kt @@ -94,9 +94,7 @@ class InstallUnknownAppsListModel(private val context: Context) : private fun isChangeable( record: InstallUnknownAppsRecord, potentialPackageNames: Set, - ) = - record.appOpsController.getMode() != MODE_DEFAULT || - record.app.packageName in potentialPackageNames + ) = record.app.packageName in potentialPackageNames private fun getPotentialPackageNames(userId: Int): Set = AppGlobals.getPackageManager()