From 7a083f8f2f6027c4351429dad7a4231c80a01129 Mon Sep 17 00:00:00 2001 From: pastychang Date: Tue, 26 Mar 2019 16:09:34 +0800 Subject: [PATCH] Change to show generic lock screen before setup fingerprint or face Bug: 121235656 Test: atest Change-Id: Ib2a4c7382334433a56225f5338896f70b752071d --- .../settings/password/ChooseLockPassword.java | 2 +- .../settings/password/ChooseLockPattern.java | 2 +- .../password/SetupChooseLockPassword.java | 7 +++++++ .../password/SetupChooseLockPattern.java | 17 +++++++++++++++++ 4 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/password/ChooseLockPassword.java b/src/com/android/settings/password/ChooseLockPassword.java index 16cecc8c013..f44e106dc94 100644 --- a/src/com/android/settings/password/ChooseLockPassword.java +++ b/src/com/android/settings/password/ChooseLockPassword.java @@ -515,7 +515,7 @@ public class ChooseLockPassword extends SettingsActivity { } } - private int getStageType() { + protected int getStageType() { return mForFingerprint ? Stage.TYPE_FINGERPRINT : mForFace ? Stage.TYPE_FACE : Stage.TYPE_NONE; diff --git a/src/com/android/settings/password/ChooseLockPattern.java b/src/com/android/settings/password/ChooseLockPattern.java index e0974fe3466..975ff393cb8 100644 --- a/src/com/android/settings/password/ChooseLockPattern.java +++ b/src/com/android/settings/password/ChooseLockPattern.java @@ -185,7 +185,7 @@ public class ChooseLockPattern extends SettingsActivity { // how long we wait to clear a wrong pattern private static final int WRONG_PATTERN_CLEAR_TIMEOUT_MS = 2000; - private static final int ID_EMPTY_MESSAGE = -1; + protected static final int ID_EMPTY_MESSAGE = -1; private static final String FRAGMENT_TAG_SAVE_AND_FINISH = "save_and_finish_worker"; diff --git a/src/com/android/settings/password/SetupChooseLockPassword.java b/src/com/android/settings/password/SetupChooseLockPassword.java index 213351b6a3b..655cf1f30a3 100644 --- a/src/com/android/settings/password/SetupChooseLockPassword.java +++ b/src/com/android/settings/password/SetupChooseLockPassword.java @@ -131,6 +131,13 @@ public class SetupChooseLockPassword extends ChooseLockPassword { startChooseLockActivity(lock, getActivity()); } + @Override + protected int getStageType() { + // Return TYPE_NONE to make generic lock screen launch in Setup wizard flow before + // fingerprint and face setup. + return Stage.TYPE_NONE; + } + @Override protected void updateUi() { super.updateUi(); diff --git a/src/com/android/settings/password/SetupChooseLockPattern.java b/src/com/android/settings/password/SetupChooseLockPattern.java index 3a69844cb70..5b49f944f06 100644 --- a/src/com/android/settings/password/SetupChooseLockPattern.java +++ b/src/com/android/settings/password/SetupChooseLockPattern.java @@ -54,6 +54,15 @@ public class SetupChooseLockPattern extends ChooseLockPattern { return SetupChooseLockPatternFragment.class; } + @Override + protected void onCreate(Bundle savedInstanceState) { + super.onCreate(savedInstanceState); + + // Show generic pattern title when pattern lock screen launch in Setup wizard flow before + // fingerprint and face setup. + setTitle(R.string.lockpassword_choose_your_screen_lock_header); + } + public static class SetupChooseLockPatternFragment extends ChooseLockPatternFragment implements ChooseLockTypeDialogFragment.OnLockTypeSelectedListener { @@ -116,6 +125,14 @@ public class SetupChooseLockPattern extends ChooseLockPattern { } else { mLeftButtonIsSkip = false; } + + // Show generic pattern message when pattern lock screen launch in Setup wizard flow + // before fingerprint and face setup. + if (stage.message == ID_EMPTY_MESSAGE) { + mMessageText.setText(""); + } else { + mMessageText.setText(stage.message); + } } @Override