From 7d563bd1de0944fe75511359b2dc431da278f79f Mon Sep 17 00:00:00 2001 From: Jack He Date: Thu, 7 Dec 2017 15:09:07 -0800 Subject: [PATCH 1/7] Bluetooth: Use "Disable" in-band ringing instead of "Enable" * Given that in-band ringing is enabled by default on supported devices, the corresponding development settings should be rephrased from "Enable in-band ringing" to "Disable in-band ringing" to hint that it is enabled by default * This also gets rid of special logic to check that option in initialization * Add strings to reflect this change as well Bug: 65383086 Test: make, try toggling the preference and verify whether in-band ringing works or not Change-Id: I29f91c7d12c725b12452ec163b75051ff28f500d Merged-In: I29f91c7d12c725b12452ec163b75051ff28f500d --- res/values/strings.xml | 5 +++ res/xml/development_prefs.xml | 6 +-- .../development/DevelopmentSettings.java | 40 +++++++++---------- 3 files changed, 26 insertions(+), 25 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 788c1ac91bb..a05fbfcddaf 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1601,6 +1601,11 @@ Remember settings + + Disable in-band ringing + + Don’t play custom phone ringtones on Bluetooth headsets + Cast diff --git a/res/xml/development_prefs.xml b/res/xml/development_prefs.xml index ecfa5a8f2c0..bf83a5e90d8 100644 --- a/res/xml/development_prefs.xml +++ b/res/xml/development_prefs.xml @@ -224,9 +224,9 @@ android:summary="@string/bluetooth_disable_absolute_volume_summary"/> + android:key="bluetooth_disable_inband_ringing" + android:title="@string/bluetooth_disable_inband_ringing" + android:summary="@string/bluetooth_disable_inband_ringing_summary"/> Date: Fri, 5 Jan 2018 11:58:46 +0000 Subject: [PATCH 2/7] Revert "Don't use framework strings for formatting file sizes" The previous revert ag/3403198/ is incomplete. I just learned that "git revert" has memory. "git revert" re-applied my previous incorrect merge conflict resolution when I reverted the same change again. Test: adb shell am instrument -w -e class com.android.settings.utils.FileSizeFormatterTest com.android.settings.tests.unit/android.support.test.runner.AndroidJUnitRunner Test: make -j RunSettingsRoboTests Test: manual. GB is shown in Settings > Network > data usage > tap at top Bug: 70050030 Bug: 70005649 Bug: 36994779 Change-Id: Ia56f8aaf9b5048c102b4e480da0e84e90ee51360 --- .../settings/datausage/BillingCycleSettings.java | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/com/android/settings/datausage/BillingCycleSettings.java b/src/com/android/settings/datausage/BillingCycleSettings.java index fb8119c60e4..34d18e920de 100644 --- a/src/com/android/settings/datausage/BillingCycleSettings.java +++ b/src/com/android/settings/datausage/BillingCycleSettings.java @@ -24,8 +24,6 @@ import android.app.Fragment; import android.content.Context; import android.content.DialogInterface; import android.content.res.Resources; -import android.icu.text.MeasureFormat; -import android.icu.util.MeasureUnit; import android.net.NetworkPolicy; import android.net.NetworkTemplate; import android.os.Bundle; @@ -36,7 +34,6 @@ import android.text.format.Time; import android.util.Log; import android.view.LayoutInflater; import android.view.View; -import android.widget.ArrayAdapter; import android.widget.EditText; import android.widget.NumberPicker; import android.widget.Spinner; @@ -256,17 +253,6 @@ public class BillingCycleSettings extends DataUsageBase implements : editor.getPolicyWarningBytes(template); final long limitDisabled = isLimit ? LIMIT_DISABLED : WARNING_DISABLED; - final MeasureFormat formatter = MeasureFormat.getInstance( - getContext().getResources().getConfiguration().locale, - MeasureFormat.FormatWidth.SHORT); - final String[] unitNames = new String[] { - formatter.getUnitDisplayName(MeasureUnit.MEGABYTE), - formatter.getUnitDisplayName(MeasureUnit.GIGABYTE) - }; - final ArrayAdapter adapter = new ArrayAdapter( - getContext(), R.layout.data_usage_spinner_item, unitNames); - type.setAdapter(adapter); - if (bytes > 1.5f * GB_IN_BYTES) { final String bytesText = formatText(bytes / (float) GB_IN_BYTES); bytesPicker.setText(bytesText); From 616397d28c864ca945c45e39ea8419171690d4d4 Mon Sep 17 00:00:00 2001 From: Salvador Martinez Date: Fri, 5 Jan 2018 10:39:49 -0800 Subject: [PATCH 3/7] Remove support v1 Support v1 is no longer used and we want to keep the codebase clean. Test: robotests still pass Bug: 70620533 Change-Id: Ic8af0f34aab510a533bd7a7ec5c059834395baf5 --- AndroidManifest.xml | 7 - res/layout/support_account_spinner_item.xml | 26 - res/layout/support_disclaimer_content.xml | 39 - res/layout/support_escalation_options.xml | 101 --- res/layout/support_fragment.xml | 31 - .../support_offline_escalation_options.xml | 71 -- res/layout/support_phone_dialog_content.xml | 50 -- res/layout/support_sign_in_button.xml | 52 -- res/layout/support_tile.xml | 41 - res/layout/support_tile_spacer.xml | 21 - res/values/dimens.xml | 9 - res/values/strings.xml | 90 -- res/values/styles.xml | 21 - src/com/android/settings/Settings.java | 1 - .../core/gateway/SettingsGateway.java | 2 - .../settings/dashboard/SupportFragment.java | 164 ---- .../dashboard/SupportItemAdapter.java | 823 ------------------ .../overlay/SupportFeatureProvider.java | 95 -- .../support/SupportDashboardActivity.java | 9 +- .../SupportDisclaimerDialogFragment.java | 222 ----- .../support/SupportPhoneDialogFragment.java | 89 -- .../dashboard/DashboardItemAnimatorTest.java | 11 +- .../dashboard/SupportItemAdapterTest.java | 189 ---- .../SupportDisclaimerDialogFragmentTest.java | 119 --- 24 files changed, 13 insertions(+), 2270 deletions(-) delete mode 100644 res/layout/support_account_spinner_item.xml delete mode 100644 res/layout/support_disclaimer_content.xml delete mode 100644 res/layout/support_escalation_options.xml delete mode 100644 res/layout/support_fragment.xml delete mode 100644 res/layout/support_offline_escalation_options.xml delete mode 100644 res/layout/support_phone_dialog_content.xml delete mode 100644 res/layout/support_sign_in_button.xml delete mode 100644 res/layout/support_tile.xml delete mode 100644 res/layout/support_tile_spacer.xml delete mode 100644 src/com/android/settings/dashboard/SupportFragment.java delete mode 100644 src/com/android/settings/dashboard/SupportItemAdapter.java delete mode 100644 src/com/android/settings/support/SupportDisclaimerDialogFragment.java delete mode 100644 src/com/android/settings/support/SupportPhoneDialogFragment.java delete mode 100644 tests/robotests/src/com/android/settings/dashboard/SupportItemAdapterTest.java delete mode 100644 tests/robotests/src/com/android/settings/support/SupportDisclaimerDialogFragmentTest.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index facfeab50c9..bf241d35db4 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -3104,13 +3104,6 @@ - - - - - diff --git a/res/layout/support_account_spinner_item.xml b/res/layout/support_account_spinner_item.xml deleted file mode 100644 index fe37a8589ca..00000000000 --- a/res/layout/support_account_spinner_item.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - diff --git a/res/layout/support_disclaimer_content.xml b/res/layout/support_disclaimer_content.xml deleted file mode 100644 index 1e81f1a98ed..00000000000 --- a/res/layout/support_disclaimer_content.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - - diff --git a/res/layout/support_escalation_options.xml b/res/layout/support_escalation_options.xml deleted file mode 100644 index ae208f19b57..00000000000 --- a/res/layout/support_escalation_options.xml +++ /dev/null @@ -1,101 +0,0 @@ - - - - - - - - - - -