1/n: Clean up BiometricEnrollActivity

Test: fingerprint and face enroll via
      adb shell am start -a android.settings.BIOMETRIC_ENROLL
Test: credential enroll via
      adb shell am start -a android.settings.BIOMETRIC_ENROLL --ei android.provider.extra.BIOMETRIC_AUTHENTICATORS_ALLOWED 32768

Bug: 162341940
Bug: 152242790
Change-Id: Idfdf96891ba9a2394f61eedb0adde2adf9fd85e6

src/com/android/settings/biometrics/BiometricEnrollActivity.java

@@ -16,6 +16,7 @@
 
 package com.android.settings.biometrics;
 
+import android.annotation.NonNull;
 import android.app.admin.DevicePolicyManager;
 import android.app.settings.SettingsEnums;
 import android.content.Intent;
@@ -48,6 +49,8 @@ public class BiometricEnrollActivity extends InstrumentedActivity {
 
     private static final String TAG = "BiometricEnrollActivity";
 
+    // Intent extra. If true, biometric enrollment should skip introductory screens. Currently
+    // this only applies to fingerprint.
     public static final String EXTRA_SKIP_INTRO = "skip_intro";
 
     public static final class InternalActivity extends BiometricEnrollActivity {}
@@ -62,42 +65,59 @@ public class BiometricEnrollActivity extends InstrumentedActivity {
 
         Log.d(TAG, "Authenticators: " + authenticators);
 
-        final BiometricManager bm = getSystemService(BiometricManager.class);
         final PackageManager pm = getApplicationContext().getPackageManager();
-        Intent intent = null;
+        final boolean hasFeatureFingerprint =
+                pm.hasSystemFeature(PackageManager.FEATURE_FINGERPRINT);
+        final boolean hasFeatureFace = pm.hasSystemFeature(PackageManager.FEATURE_FACE);
+        final boolean isSetupWizard = WizardManagerHelper.isAnySetupWizard(getIntent());
 
-        final int result = bm.canAuthenticate(authenticators);
+        if (isSetupWizard) {
-
+            if (hasFeatureFace && hasFeatureFingerprint) {
-        if (!WizardManagerHelper.isAnySetupWizard(getIntent())) {
+                // TODO(b/162341940, b/152242790) this should show a multi-biometric selection
-            if (result == BiometricManager.BIOMETRIC_SUCCESS
+                //  screen
-                    || result == BiometricManager.BIOMETRIC_ERROR_NO_HARDWARE) {
+                launchFingerprintOnlyEnroll();
+            } else if (hasFeatureFace) {
+                launchFaceOnlyEnroll();
+            } else if (hasFeatureFingerprint) {
+                launchFingerprintOnlyEnroll();
+            } else {
+                Log.e(TAG, "No biometrics but started by SUW?");
+                finish();
+            }
+        } else {
+            // If the caller is not setup wizard, and the user has something enrolled, finish.
+            final BiometricManager bm = getSystemService(BiometricManager.class);
+            final @BiometricManager.BiometricError int result = bm.canAuthenticate(authenticators);
+            if (result != BiometricManager.BIOMETRIC_ERROR_NONE_ENROLLED) {
                 Log.e(TAG, "Unexpected result: " + result);
                 finish();
                 return;
             }
-        }
 
+            // This will need to be updated if the device has sensors other than BIOMETRIC_STRONG
             if (authenticators == BiometricManager.Authenticators.DEVICE_CREDENTIAL) {
-            // If only device credential was specified, ask the user to only set that up.
+                launchCredentialOnlyEnroll();
-            intent = new Intent(this, ChooseLockGeneric.class);
+            } else if (hasFeatureFace && hasFeatureFingerprint) {
-            intent.putExtra(ChooseLockGeneric.ChooseLockGenericFragment.MINIMUM_QUALITY_KEY,
+                // TODO(b/162341940, b/152242790) this should show a multi-biometric selection
-                    DevicePolicyManager.PASSWORD_QUALITY_SOMETHING);
+                //  screen
-        } else if (pm.hasSystemFeature(PackageManager.FEATURE_FINGERPRINT)) {
+                launchFingerprintOnlyEnroll();
-            // This logic may have to be modified on devices with multiple biometrics.
+            } else if (hasFeatureFingerprint) {
-            // ChooseLockGeneric can request to start fingerprint enroll bypassing the intro screen.
+                launchFingerprintOnlyEnroll();
-            if (getIntent().getBooleanExtra(EXTRA_SKIP_INTRO, false)
+            } else if (hasFeatureFace) {
-                    && this instanceof InternalActivity) {
+                launchFaceOnlyEnroll();
-                intent = getFingerprintFindSensorIntent();
             } else {
-                intent = getFingerprintIntroIntent();
+                Log.e(TAG, "Unknown state, finishing");
+                finish();
+            }
         }
-        } else if (pm.hasSystemFeature(PackageManager.FEATURE_FACE)) {
-            intent = getFaceIntroIntent();
     }
 
-        if (intent != null) {
+    /**
+     * @param intent Enrollment activity that should be started (e.g. FaceEnrollIntroduction.class,
+     *               etc).
+     */
+    private void launchEnrollActivity(@NonNull Intent intent) {
         intent.setFlags(Intent.FLAG_ACTIVITY_FORWARD_RESULT);
-
         if (this instanceof InternalActivity) {
             // Propagate challenge and user Id from ChooseLockGeneric.
             final byte[] token = getIntent()
@@ -116,10 +136,32 @@ public class BiometricEnrollActivity extends InstrumentedActivity {
 
         startActivity(intent);
         finish();
-        } else {
-            Log.e(TAG, "Intent was null, finishing");
-            finish();
     }
+
+    private void launchCredentialOnlyEnroll() {
+        final Intent intent;
+        // If only device credential was specified, ask the user to only set that up.
+        intent = new Intent(this, ChooseLockGeneric.class);
+        intent.putExtra(ChooseLockGeneric.ChooseLockGenericFragment.MINIMUM_QUALITY_KEY,
+                DevicePolicyManager.PASSWORD_QUALITY_SOMETHING);
+        launchEnrollActivity(intent);
+    }
+
+    private void launchFingerprintOnlyEnroll() {
+        final Intent intent;
+        // ChooseLockGeneric can request to start fingerprint enroll bypassing the intro screen.
+        if (getIntent().getBooleanExtra(EXTRA_SKIP_INTRO, false)
+                && this instanceof InternalActivity) {
+            intent = getFingerprintFindSensorIntent();
+        } else {
+            intent = getFingerprintIntroIntent();
+        }
+        launchEnrollActivity(intent);
+    }
+
+    private void launchFaceOnlyEnroll() {
+        final Intent intent = getFaceIntroIntent();
+        launchEnrollActivity(intent);
     }
 
     private Intent getFingerprintFindSensorIntent() {