PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add the mutability flag to the pendingIntent.

Browse Source 
Starting Android S, PendingIntent should have a explicit mutability flag
to avoid vulnerability.

Fixes: 172207853
Test: 1. Make AdaptiveSleepSlice available on the homepage and click on it.
2. Play with the volume panel.

Change-Id: I9cd428b17f44f5215d8c06331d12a17f997ca557
This commit is contained in:
Yi-Ling Chuang
2020-11-03 17:35:49 +08:00
parent 0254a6c38d
commit ea92f4eb5e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/com/android/settings/homepage/contextualcards/slices/ContextualAdaptiveSleepSlice.java
View File

@@ -43,6 +43,7 @@ import com.google.common.annotations.VisibleForTesting;
import java.util.concurrent.TimeUnit;
// TODO(b/172310863): consider removing this slice.
public class ContextualAdaptiveSleepSlice implements CustomSliceable {
private static final String TAG = "ContextualAdaptiveSleepSlice";
private static final long DEFAULT_SETUP_TIME = 0;
@@ -122,7 +123,8 @@ public class ContextualAdaptiveSleepSlice implements CustomSliceable {
private PendingIntent getPrimaryAction() {
final Intent intent = getIntent();
return PendingIntent.getActivity(mContext, 0 /* requestCode */, intent, 0 /* flags */);
return PendingIntent.getActivity(mContext, 0 /* requestCode */, intent,
PendingIntent.FLAG_IMMUTABLE /* flags */);
}
/**