diff --git a/src/com/android/settings/users/TimeoutToDockUserSettings.java b/src/com/android/settings/users/TimeoutToDockUserSettings.java index bb61b679d2e..60bbdbbce1d 100644 --- a/src/com/android/settings/users/TimeoutToDockUserSettings.java +++ b/src/com/android/settings/users/TimeoutToDockUserSettings.java @@ -37,7 +37,8 @@ import java.util.List; */ public class TimeoutToDockUserSettings extends RadioButtonPickerFragment { // Index of the default key of the timeout setting if it hasn't been changed by the user. - public static final int DEFAULT_TIMEOUT_SETTING_VALUE_INDEX = 0; + // Default to the smallest non-zero option (which is currently 1 minute). + public static final int DEFAULT_TIMEOUT_SETTING_VALUE_INDEX = 1; // Labels of the options, for example, "never", "after 5 minutes". private String[] mEntries; diff --git a/tests/robotests/src/com/android/settings/users/TimeoutToDockUserPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/users/TimeoutToDockUserPreferenceControllerTest.java index 2c93e94aecd..774117f86e0 100644 --- a/tests/robotests/src/com/android/settings/users/TimeoutToDockUserPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/users/TimeoutToDockUserPreferenceControllerTest.java @@ -124,7 +124,8 @@ public class TimeoutToDockUserPreferenceControllerTest { Settings.Secure.putStringForUser(mContext.getContentResolver(), TIMEOUT_TO_DOCK_USER, null, UserHandle.myUserId()); - assertThat(mController.getSummary().toString()).isEqualTo(mEntries[0]); + assertThat(mController.getSummary().toString()).isEqualTo( + mEntries[TimeoutToDockUserSettings.DEFAULT_TIMEOUT_SETTING_VALUE_INDEX]); } @Test diff --git a/tests/robotests/src/com/android/settings/users/TimeoutToDockUserSettingsTest.java b/tests/robotests/src/com/android/settings/users/TimeoutToDockUserSettingsTest.java index 55b630d6b05..6c95fce73f2 100644 --- a/tests/robotests/src/com/android/settings/users/TimeoutToDockUserSettingsTest.java +++ b/tests/robotests/src/com/android/settings/users/TimeoutToDockUserSettingsTest.java @@ -78,8 +78,9 @@ public class TimeoutToDockUserSettingsTest { } @Test - public void defaultKey_settingNotSet_shouldReturnFirstValueAsDefault() { - assertThat(mSettings.getDefaultKey()).isEqualTo(mValues[0]); + public void defaultKey_settingNotSet_shouldReturnSecondValueAsDefault() { + assertThat(mSettings.getDefaultKey()).isEqualTo( + mValues[TimeoutToDockUserSettings.DEFAULT_TIMEOUT_SETTING_VALUE_INDEX]); } @Test @@ -95,4 +96,11 @@ public class TimeoutToDockUserSettingsTest { mSettings.setDefaultKey(expectedKey); assertThat(mSettings.getDefaultKey()).isEqualTo(expectedKey); } + + @Test + public void defaultKey_setToThirdValue_shouldSaveToSettings() { + final String expectedKey = mValues[2]; + mSettings.setDefaultKey(expectedKey); + assertThat(mSettings.getDefaultKey()).isEqualTo(expectedKey); + } }