PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Wi-Fi] Fix a fail WifiEnhancedMacRandomizationPreferenceControllerTest

Browse Source 
Mock objects do not know the relation between setChecked
and isChecked. Should not call mock objects's setter and
assume the getter will return the corresponding value.

Bug: 154564960
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiEnhancedMacRandomizationPreferenceControllerTest
Change-Id: Ib2e06f0fe60f7d6f90f76bd179a7aadccfcff4c4
This commit is contained in:
Arc Wang
2020-04-21 17:54:16 +08:00
parent f11da4c787
commit ea3bfabee6
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/robotests/src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceControllerTest.java
View File

@@ -18,6 +18,7 @@ package com.android.settings.development;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import android.content.Context; import android.content.Context;
@@ -27,7 +28,6 @@ import androidx.preference.PreferenceScreen;
import androidx.preference.SwitchPreference; import androidx.preference.SwitchPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
@@ -75,13 +75,12 @@ public class WifiEnhancedMacRandomizationPreferenceControllerTest {
} }
@Test @Test
@Ignore
public void updateState_preferenceShouldBeChecked() { public void updateState_preferenceShouldBeChecked() {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 1); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 1);
mController.updateState(mPreference); mController.updateState(mPreference);
assertThat(mPreference.isChecked()).isTrue(); verify(mPreference).setChecked(true);
} }
@Test @Test
@@ -90,7 +89,7 @@ public class WifiEnhancedMacRandomizationPreferenceControllerTest {
ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 0); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 0);
mController.updateState(mPreference); mController.updateState(mPreference);
assertThat(mPreference.isChecked()).isFalse(); verify(mPreference).setChecked(false);
} }
@Test @Test