diff --git a/res/values/strings.xml b/res/values/strings.xml index a2d02185efd..f51c0e65ab5 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -4991,9 +4991,13 @@ %1$d apps misbehaving - Battery is in good shape + Apps are running normally - Apps are running normally + Phone has typical background battery usage + + Tablet has typical background battery usage + + Device has typical background battery usage Low battery capacity @@ -5072,9 +5076,11 @@ Cancel - Based on your usage, your battery usually lasts about %1$s when fully charged.\n\nIf you need to extend your battery life, turn on Battery Saver. + Your apps are using a normal amount of battery. If apps use too much battery, your phone will suggest actions you can take.\n\nYou can always turn on Battery Saver if you\u2019re running low on battery. - If you need to extend your battery life, turn on Battery Saver + Your apps are using a normal amount of battery. If apps use too much battery, your tablet will suggest actions you can take.\n\nYou can always turn on Battery Saver if you\u2019re running low on battery. + + Your apps are using a normal amount of battery. If apps use too much battery, your device will suggest actions you can take.\n\nYou can always turn on Battery Saver if you\u2019re running low on battery. Battery Manager diff --git a/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragment.java b/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragment.java index 182ba9c5989..ef903a863eb 100644 --- a/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragment.java +++ b/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragment.java @@ -79,16 +79,8 @@ public class BatteryTipDialogFragment extends InstrumentedDialogFragment impleme switch (mBatteryTip.getType()) { case BatteryTip.TipType.SUMMARY: - final long averageTimeMs = ((SummaryTip) mBatteryTip).getAverageTimeMs(); - final String message = context.getString( - averageTimeMs == Estimate.AVERAGE_TIME_TO_DISCHARGE_UNKNOWN - ? R.string.battery_tip_dialog_summary_message_no_estimation - : R.string.battery_tip_dialog_summary_message, - StringUtil.formatElapsedTime(context, averageTimeMs, - false /* withSeconds */)); - return new AlertDialog.Builder(context) - .setMessage(message) + .setMessage(R.string.battery_tip_dialog_summary_message) .setPositiveButton(android.R.string.ok, null) .create(); case BatteryTip.TipType.HIGH_DEVICE_USAGE: diff --git a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragmentTest.java b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragmentTest.java index 1de1e486c94..7a41921789d 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragmentTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipDialogFragmentTest.java @@ -199,7 +199,7 @@ public class BatteryTipDialogFragmentTest { } @Test - public void testOnCreateDialog_summaryTipWithEstimation_fireDialogWithEstimation() { + public void testOnCreateDialog_summaryTip_fireDialog() { doReturn(AVERAGE_TIME_MS).when(mSummaryTip).getAverageTimeMs(); mDialogFragment = BatteryTipDialogFragment.newInstance(mSummaryTip, METRICS_KEY); @@ -209,20 +209,8 @@ public class BatteryTipDialogFragmentTest { ShadowAlertDialog shadowDialog = shadowOf(dialog); assertThat(shadowDialog.getMessage()).isEqualTo( - "Based on your usage, your battery usually lasts about 1 hr when fully charged" - + ".\n\nIf you need to extend your battery life, turn on Battery Saver."); - } - - @Test - public void testOnCreateDialog_summaryTipWithoutEstimation_fireDialogWithoutEstimation() { - mDialogFragment = BatteryTipDialogFragment.newInstance(mSummaryTip, METRICS_KEY); - - FragmentTestUtil.startFragment(mDialogFragment); - - final AlertDialog dialog = (AlertDialog) ShadowDialog.getLatestDialog(); - ShadowAlertDialog shadowDialog = shadowOf(dialog); - - assertThat(shadowDialog.getMessage()).isEqualTo( - "If you need to extend your battery life, turn on Battery Saver"); + "Your apps are using a normal amount of battery. If apps use too much battery, " + + "your phone will suggest actions you can take.\n\nYou can always turn" + + " on Battery Saver if you’re running low on battery."); } } diff --git a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipPreferenceControllerTest.java index 60699cf5d52..ff52a0843ab 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipPreferenceControllerTest.java @@ -37,6 +37,7 @@ import androidx.preference.PreferenceScreen; import android.text.format.DateUtils; import com.android.internal.logging.nano.MetricsProto; +import com.android.settings.R; import com.android.settings.SettingsActivity; import com.android.settings.core.InstrumentedPreferenceFragment; import com.android.settings.fuelgauge.batterytip.tips.BatteryTip; @@ -181,7 +182,9 @@ public class BatteryTipPreferenceControllerTest { assertThat(preferenceGroup.getPreferenceCount()).isEqualTo(1); final Preference preference = preferenceGroup.getPreference(0); - assertThat(preference.getTitle()).isEqualTo("Battery is in good shape"); - assertThat(preference.getSummary()).isEqualTo("Apps are running normally"); + assertThat(preference.getTitle()).isEqualTo( + mContext.getString(R.string.battery_tip_summary_title)); + assertThat(preference.getSummary()).isEqualTo( + mContext.getString(R.string.battery_tip_summary_summary)); } }