PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Added guard to logging in AsyncTask"

Browse Source
This commit is contained in:
TreeHugger Robot
2016-08-25 00:36:32 +00:00
committed by Android (Google) Code Review
parent 5f288793fa 566b66e27c
commit e96d65deea
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/com/android/settings/dashboard/DashboardSummary.java
View File

@@ -235,17 +235,18 @@ public class DashboardSummary extends InstrumentedFragment
@Override @Override
protected List<Tile> doInBackground(Void... params) { protected List<Tile> doInBackground(Void... params) {
final Context context = getContext();
List<Tile> suggestions = mSuggestionParser.getSuggestions(); List<Tile> suggestions = mSuggestionParser.getSuggestions();
for (int i = 0; i < suggestions.size(); i++) { for (int i = 0; i < suggestions.size(); i++) {
Tile suggestion = suggestions.get(i); Tile suggestion = suggestions.get(i);
if (mSuggestionsChecks.isSuggestionComplete(suggestion)) { if (mSuggestionsChecks.isSuggestionComplete(suggestion)) {
mAdapter.disableSuggestion(suggestion); mAdapter.disableSuggestion(suggestion);
suggestions.remove(i--); suggestions.remove(i--);
} else { } else if (context != null) {
String id = DashboardAdapter.getSuggestionIdentifier(getContext(), suggestion); String id = DashboardAdapter.getSuggestionIdentifier(context, suggestion);
if (!mSuggestionsShownLogged.contains(id)) { if (!mSuggestionsShownLogged.contains(id)) {
mSuggestionsShownLogged.add(id); mSuggestionsShownLogged.add(id);
MetricsLogger.action(getContext(), MetricsLogger.action(context,
MetricsEvent.ACTION_SHOW_SETTINGS_SUGGESTION, id); MetricsEvent.ACTION_SHOW_SETTINGS_SUGGESTION, id);
} }
} }