Merge "HardwareInfoPreferenceControllerTest migrated to JUnit."

This commit is contained in:
Jeremy Goldman
2021-02-23 07:11:25 +00:00
committed by Android (Google) Code Review

View File

@@ -17,41 +17,53 @@ package com.android.settings.deviceinfo.hardwareinfo;
import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.when;
import android.content.Context; import android.content.Context;
import android.content.res.Resources;
import android.os.Build; import android.os.Build;
import android.os.Looper;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.PreferenceManager; import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.deviceinfo.HardwareInfoPreferenceController; import com.android.settings.deviceinfo.HardwareInfoPreferenceController;
import com.android.settings.testutils.ResourcesUtils;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations; import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
@RunWith(RobolectricTestRunner.class) @RunWith(AndroidJUnit4.class)
public class HardwareInfoPreferenceControllerTest { public class HardwareInfoPreferenceControllerTest {
private final String KEY = "device_model"; private static final String KEY = "device_model";
private Preference mPreference; private Preference mPreference;
private PreferenceScreen mPreferenceScreen; private PreferenceScreen mPreferenceScreen;
private Context mContext; private Context mContext;
@Mock
private Resources mResources;
private HardwareInfoPreferenceController mController; private HardwareInfoPreferenceController mController;
@Before @Before
public void setUp() { public void setUp() {
MockitoAnnotations.initMocks(this); MockitoAnnotations.initMocks(this);
mContext = RuntimeEnvironment.application; mContext = spy(ApplicationProvider.getApplicationContext());
when(mContext.getResources()).thenReturn(mResources);
mController = new HardwareInfoPreferenceController(mContext, KEY); mController = new HardwareInfoPreferenceController(mContext, KEY);
mPreference = new Preference(mContext); mPreference = new Preference(mContext);
mPreference.setKey(KEY); mPreference.setKey(KEY);
if (Looper.myLooper() == null) {
Looper.prepare();
}
final PreferenceManager preferenceManager = new PreferenceManager(mContext); final PreferenceManager preferenceManager = new PreferenceManager(mContext);
mPreferenceScreen = preferenceManager.createPreferenceScreen(mContext); mPreferenceScreen = preferenceManager.createPreferenceScreen(mContext);
mPreferenceScreen.addPreference(mPreference); mPreferenceScreen.addPreference(mPreference);
@@ -59,13 +71,20 @@ public class HardwareInfoPreferenceControllerTest {
@Test @Test
public void isAvailable_returnTrueIfVisible() { public void isAvailable_returnTrueIfVisible() {
final int boolId = ResourcesUtils.getResourcesId(
ApplicationProvider.getApplicationContext(), "bool", "config_show_device_model");
when(mResources.getBoolean(boolId)).thenReturn(true);
assertThat(mController.getAvailabilityStatus()).isEqualTo( assertThat(mController.getAvailabilityStatus()).isEqualTo(
BasePreferenceController.AVAILABLE); BasePreferenceController.AVAILABLE);
} }
@Test @Test
@Config(qualifiers = "mcc999")
public void isAvailable_returnFalseIfNotVisible() { public void isAvailable_returnFalseIfNotVisible() {
final int boolId = ResourcesUtils.getResourcesId(
ApplicationProvider.getApplicationContext(), "bool", "config_show_device_model");
when(mResources.getBoolean(boolId)).thenReturn(false);
assertThat(mController.getAvailabilityStatus()).isEqualTo( assertThat(mController.getAvailabilityStatus()).isEqualTo(
BasePreferenceController.UNSUPPORTED_ON_DEVICE); BasePreferenceController.UNSUPPORTED_ON_DEVICE);
} }