From e83d8b22bcf946f51384beb7147f3dee856bc6ce Mon Sep 17 00:00:00 2001 From: songferngwang Date: Thu, 22 Feb 2024 09:38:59 +0000 Subject: [PATCH] [SimOnbarding] correct the sim name at the Primary Sim The user can modify the name at Label sim page. The primary sim page should show the name which is modified by the user. Bug: 318310357 Bug: 298898436 Bug: 298891941 Test: manual test and verify the UI display the correct name. Change-Id: Ica2a26ead4ec7d61a59bb3846ea07f278d7a1144 --- .../android/settings/network/SimOnboardingService.kt | 10 ++++++++++ .../settings/spa/network/SimOnboardingPrimarySim.kt | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/network/SimOnboardingService.kt b/src/com/android/settings/network/SimOnboardingService.kt index f33abf67b64..d31d850f5a9 100644 --- a/src/com/android/settings/network/SimOnboardingService.kt +++ b/src/com/android/settings/network/SimOnboardingService.kt @@ -196,6 +196,16 @@ class SimOnboardingService { return userSelectedSubInfoList.toList() } + fun getSelectedSubscriptionInfoListWithRenaming(): List { + if (userSelectedSubInfoList.isEmpty()){ + Log.d(TAG, "userSelectedSubInfoList is empty") + return activeSubInfoList + } + return userSelectedSubInfoList.map { + SubscriptionInfo.Builder(it).setDisplayName(getSubscriptionInfoDisplayName(it)).build() + }.toList() + } + fun addItemForRenaming(subInfo: SubscriptionInfo, newName: String) { if (subInfo.displayName == newName) { return diff --git a/src/com/android/settings/spa/network/SimOnboardingPrimarySim.kt b/src/com/android/settings/spa/network/SimOnboardingPrimarySim.kt index a5f55d09ff5..b9849666e53 100644 --- a/src/com/android/settings/spa/network/SimOnboardingPrimarySim.kt +++ b/src/com/android/settings/spa/network/SimOnboardingPrimarySim.kt @@ -77,7 +77,8 @@ fun SimOnboardingPrimarySimImpl( SettingsBody(stringResource(id = R.string.sim_onboarding_primary_sim_msg)) } - var selectedSubscriptionInfoList = onboardingService.getSelectedSubscriptionInfoList() + var selectedSubscriptionInfoList = + onboardingService.getSelectedSubscriptionInfoListWithRenaming() callsSelectedId.intValue = onboardingService.targetPrimarySimCalls textsSelectedId.intValue = onboardingService.targetPrimarySimTexts mobileDataSelectedId.intValue = onboardingService.targetPrimarySimMobileData