Merge "Delay adding app settings link until data fetch returns, to avoid reordering/visible misplaced "additional settings in the app" during transition." into oc-dev

This commit is contained in:
TreeHugger Robot
2017-06-02 18:42:24 +00:00
committed by Android (Google) Code Review
2 changed files with 2 additions and 2 deletions

View File

@@ -95,7 +95,6 @@ public class AppNotificationSettings extends NotificationSettingsBase {
getPreferenceScreen().setOrderingAsAdded(true); getPreferenceScreen().setOrderingAsAdded(true);
setupBlock(); setupBlock();
addHeaderPref(); addHeaderPref();
addAppLinkPref();
mShowLegacyChannelConfig = mBackend.onlyHasDefaultChannel(mAppRow.pkg, mAppRow.uid); mShowLegacyChannelConfig = mBackend.onlyHasDefaultChannel(mAppRow.pkg, mAppRow.uid);
if (mShowLegacyChannelConfig) { if (mShowLegacyChannelConfig) {
@@ -120,6 +119,7 @@ public class AppNotificationSettings extends NotificationSettingsBase {
return; return;
} }
populateChannelList(); populateChannelList();
addAppLinkPref();
} }
}.execute(); }.execute();
} }

View File

@@ -263,7 +263,7 @@ abstract public class NotificationSettingsBase extends SettingsPreferenceFragmen
} }
protected void addAppLinkPref() { protected void addAppLinkPref() {
if (mAppRow.settingsIntent != null) { if (mAppRow.settingsIntent != null && mAppLink == null) {
mAppLink = new Preference(getPrefContext()); mAppLink = new Preference(getPrefContext());
mAppLink.setKey(KEY_APP_LINK); mAppLink.setKey(KEY_APP_LINK);
mAppLink.setOrder(500); mAppLink.setOrder(500);