PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Rename Enhanced MAC Randomization to Non-Persistent"

Browse Source 
Revert submission 15050857-RenameEnhancedMac

Reason for revert: Droidfood blocking Bug: 193375403
Reverted Changes:
I5d647a666:Rename Enhanced MAC Randomization to Non-Persisten...
I48a326f98:Update old terminology for Non-persistent Mac Rand...

Change-Id: Ic6ff02dad064f8d8c7dbaab51c658da12a4d8555
This commit is contained in:
Daniel Chapin
2021-07-12 22:54:21 +00:00
parent 340a7fb640
commit e7cb2762f9
3 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java
View File

@@ -505,7 +505,7 @@ public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFra
controllers.add(new WifiDisplayCertificationPreferenceController(context)); controllers.add(new WifiDisplayCertificationPreferenceController(context));
controllers.add(new WifiVerboseLoggingPreferenceController(context)); controllers.add(new WifiVerboseLoggingPreferenceController(context));
controllers.add(new WifiScanThrottlingPreferenceController(context)); controllers.add(new WifiScanThrottlingPreferenceController(context));
controllers.add(new WifiNonPersistentMacRandomizationPreferenceController(context)); controllers.add(new WifiEnhancedMacRandomizationPreferenceController(context));
controllers.add(new MobileDataAlwaysOnPreferenceController(context)); controllers.add(new MobileDataAlwaysOnPreferenceController(context));
controllers.add(new TetheringHardwareAccelPreferenceController(context)); controllers.add(new TetheringHardwareAccelPreferenceController(context));
controllers.add(new BluetoothDeviceNoNamePreferenceController(context)); controllers.add(new BluetoothDeviceNoNamePreferenceController(context));

22
src/com/android/settings/development/WifiNonPersistentMacRandomizationPreferenceController.java → src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceController.java
View File

@@ -26,30 +26,30 @@ import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.development.DeveloperOptionsPreferenceController; import com.android.settingslib.development.DeveloperOptionsPreferenceController;
/** /**
* Developer option controller for non-persistent MAC randomization. * Developer option controller for enhanced MAC randomization.
*/ */
public class WifiNonPersistentMacRandomizationPreferenceController public class WifiEnhancedMacRandomizationPreferenceController
extends DeveloperOptionsPreferenceController extends DeveloperOptionsPreferenceController
implements Preference.OnPreferenceChangeListener, PreferenceControllerMixin { implements Preference.OnPreferenceChangeListener, PreferenceControllerMixin {
private static final String WIFI_NON_PERSISTENT_MAC_RANDOMIZATION_KEY = private static final String WIFI_ENHANCED_MAC_RANDOMIZATION_KEY =
"wifi_non_persistent_mac_randomization"; "wifi_enhanced_mac_randomization";
private static final String NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG = private static final String ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG =
"non_persistent_mac_randomization_force_enabled"; "enhanced_mac_randomization_force_enabled";
public WifiNonPersistentMacRandomizationPreferenceController(Context context) { public WifiEnhancedMacRandomizationPreferenceController(Context context) {
super(context); super(context);
} }
@Override @Override
public String getPreferenceKey() { public String getPreferenceKey() {
return WIFI_NON_PERSISTENT_MAC_RANDOMIZATION_KEY; return WIFI_ENHANCED_MAC_RANDOMIZATION_KEY;
} }
@Override @Override
public boolean onPreferenceChange(Preference preference, Object newValue) { public boolean onPreferenceChange(Preference preference, Object newValue) {
int isEnabledInt = ((Boolean) newValue) ? 1 : 0; int isEnabledInt = ((Boolean) newValue) ? 1 : 0;
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, isEnabledInt); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, isEnabledInt);
return true; return true;
} }
@@ -57,7 +57,7 @@ public class WifiNonPersistentMacRandomizationPreferenceController
public void updateState(Preference preference) { public void updateState(Preference preference) {
boolean enabled = false; boolean enabled = false;
if (Settings.Global.getInt(mContext.getContentResolver(), if (Settings.Global.getInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, 0) == 1) { ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 0) == 1) {
enabled = true; enabled = true;
} }
((SwitchPreference) mPreference).setChecked(enabled); ((SwitchPreference) mPreference).setChecked(enabled);
@@ -67,7 +67,7 @@ public class WifiNonPersistentMacRandomizationPreferenceController
protected void onDeveloperOptionsSwitchDisabled() { protected void onDeveloperOptionsSwitchDisabled() {
super.onDeveloperOptionsSwitchDisabled(); super.onDeveloperOptionsSwitchDisabled();
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, 0); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 0);
((SwitchPreference) mPreference).setChecked(false); ((SwitchPreference) mPreference).setChecked(false);
} }
} }

24
tests/robotests/src/com/android/settings/development/WifiNonPersistentMacRandomizationPreferenceControllerTest.java → tests/robotests/src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceControllerTest.java
View File

@@ -36,48 +36,48 @@ import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment; import org.robolectric.RuntimeEnvironment;
@RunWith(RobolectricTestRunner.class) @RunWith(RobolectricTestRunner.class)
public class WifiNonPersistentMacRandomizationPreferenceControllerTest { public class WifiEnhancedMacRandomizationPreferenceControllerTest {
private static final String NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG = private static final String ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG =
"non_persistent_mac_randomization_force_enabled"; "enhanced_mac_randomization_force_enabled";
@Mock @Mock
private SwitchPreference mPreference; private SwitchPreference mPreference;
@Mock @Mock
private PreferenceScreen mPreferenceScreen; private PreferenceScreen mPreferenceScreen;
private Context mContext; private Context mContext;
private WifiNonPersistentMacRandomizationPreferenceController mController; private WifiEnhancedMacRandomizationPreferenceController mController;
@Before @Before
public void setup() { public void setup() {
MockitoAnnotations.initMocks(this); MockitoAnnotations.initMocks(this);
mContext = RuntimeEnvironment.application; mContext = RuntimeEnvironment.application;
mController = new WifiNonPersistentMacRandomizationPreferenceController(mContext); mController = new WifiEnhancedMacRandomizationPreferenceController(mContext);
when(mPreferenceScreen.findPreference(mController.getPreferenceKey())) when(mPreferenceScreen.findPreference(mController.getPreferenceKey()))
.thenReturn(mPreference); .thenReturn(mPreference);
mController.displayPreference(mPreferenceScreen); mController.displayPreference(mPreferenceScreen);
} }
@Test @Test
public void onPreferenceChanged_enabled_shouldTurnOnNonPersistentRandomization() { public void onPreferenceChanged_enabled_shouldTurnOnEnhancedRandomization() {
mController.onPreferenceChange(mPreference, true /* new value */); mController.onPreferenceChange(mPreference, true /* new value */);
int mode = Settings.Global.getInt(mContext.getContentResolver(), int mode = Settings.Global.getInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, -1); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, -1);
assertThat(mode).isEqualTo(1); assertThat(mode).isEqualTo(1);
} }
@Test @Test
public void onPreferenceChanged_disabled_shouldTurnOffNonPersistentRandomization() { public void onPreferenceChanged_disabled_shouldTurnOffEnhancedRandomization() {
mController.onPreferenceChange(mPreference, false /* new value */); mController.onPreferenceChange(mPreference, false /* new value */);
int mode = Settings.Global.getInt(mContext.getContentResolver(), int mode = Settings.Global.getInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, -1); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, -1);
assertThat(mode).isEqualTo(0); assertThat(mode).isEqualTo(0);
} }
@Test @Test
public void updateState_preferenceShouldBeChecked() { public void updateState_preferenceShouldBeChecked() {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, 1); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 1);
mController.updateState(mPreference); mController.updateState(mPreference);
verify(mPreference).setChecked(true); verify(mPreference).setChecked(true);
@@ -86,7 +86,7 @@ public class WifiNonPersistentMacRandomizationPreferenceControllerTest {
@Test @Test
public void updateState_preferenceShouldNotBeChecked() { public void updateState_preferenceShouldNotBeChecked() {
Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.putInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, 0); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 0);
mController.updateState(mPreference); mController.updateState(mPreference);
verify(mPreference).setChecked(false); verify(mPreference).setChecked(false);
@@ -97,7 +97,7 @@ public class WifiNonPersistentMacRandomizationPreferenceControllerTest {
mController.onDeveloperOptionsSwitchDisabled(); mController.onDeveloperOptionsSwitchDisabled();
int mode = Settings.Global.getInt(mContext.getContentResolver(), int mode = Settings.Global.getInt(mContext.getContentResolver(),
NON_PERSISTENT_MAC_RANDOMIZATION_FEATURE_FLAG, -1); ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, -1);
assertThat(mode).isEqualTo(0); assertThat(mode).isEqualTo(0);
assertThat(mPreference.isChecked()).isFalse(); assertThat(mPreference.isChecked()).isFalse();