diff --git a/res/layout/privatespace_account_login_error.xml b/res/layout/privatespace_account_login_error.xml index a38dd5048c3..beae22f59b6 100644 --- a/res/layout/privatespace_account_login_error.xml +++ b/res/layout/privatespace_account_login_error.xml @@ -22,7 +22,7 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:filterTouchesWhenObscured="true" - app:sucHeaderText="@string/privatespace_retry_signin_title" - app:sudDescriptionText="@string/privatespace_retry_summary" + app:sucHeaderText="@string/private_space_retry_signin_title" + app:sudDescriptionText="@string/private_space_retry_summary" android:icon="@drawable/ic_error_red"> diff --git a/res/layout/privatespace_advancing_screen.xml b/res/layout/privatespace_advancing_screen.xml index 5b695932f0d..3a85b160222 100644 --- a/res/layout/privatespace_advancing_screen.xml +++ b/res/layout/privatespace_advancing_screen.xml @@ -17,7 +17,7 @@ @@ -39,7 +39,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:textSize="14sp" - android:text="@string/privatespace_setting_up_text" + android:text="@string/private_space_setting_up_text" android:layout_marginBottom="24dp"/> diff --git a/res/layout/privatespace_creation_error.xml b/res/layout/privatespace_creation_error.xml index af11f3ad8d7..0ec0cb61c02 100644 --- a/res/layout/privatespace_creation_error.xml +++ b/res/layout/privatespace_creation_error.xml @@ -17,11 +17,10 @@ diff --git a/res/layout/privatespace_education_screen.xml b/res/layout/privatespace_education_screen.xml index adb65c982b6..350e7801256 100644 --- a/res/layout/privatespace_education_screen.xml +++ b/res/layout/privatespace_education_screen.xml @@ -21,8 +21,8 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:filterTouchesWhenObscured="true" - app:sucHeaderText="@string/privatespace_setup_title" - app:sudDescriptionText="@string/privatespace_hide_apps_summary" + app:sucHeaderText="@string/private_space_setup_title" + app:sudDescriptionText="@string/private_space_hide_apps_summary" android:icon="@drawable/ic_privatespace_icon"> + android:text="@string/private_space_how_title"/> + + + + + + + + - - - - - - - - + android:text="@string/private_space_access_bottom_text"/> + android:text="@string/private_space_apps_permission_text"/> diff --git a/res/layout/privatespace_setlock_screen.xml b/res/layout/privatespace_setlock_screen.xml index 5caf4ae8b94..72119484ac3 100644 --- a/res/layout/privatespace_setlock_screen.xml +++ b/res/layout/privatespace_setlock_screen.xml @@ -21,8 +21,8 @@ android:layout_width="match_parent" android:layout_height="match_parent" android:filterTouchesWhenObscured="true" - app:sucHeaderText="@string/privatespace_lockscreen_title" - app:sudDescriptionText="@string/privatespace_lockscreen_summary" + app:sucHeaderText="@string/private_space_lockscreen_title" + app:sudDescriptionText="@string/private_space_lockscreen_summary" android:icon="@drawable/ic_lock"> diff --git a/res/values/strings.xml b/res/values/strings.xml index 5795aeaeffa..650dcfe8938 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1253,63 +1253,61 @@ Set a screen lock - To use Private Space, set a screen lock on this device. + To use your private space, set a screen lock on this device Set screen lock Cancel - - Cancel - - Set up + + Cancel + + Set up - Set up Private Space - - Hide private apps in a secure space that only you can access - - How it works - - You can access Private Space from the bottom of your apps list - - Apps in Private Space are protected by a lock - - Notifications from apps in Private Space are hidden when it\u2019s locked - - Private Space apps won\u2019t appear in permission manager, privacy dashboard, and other settings when Private Space is locked - - Setting up Private Space\u2026 - - Usage info for Private Space apps is hidden when it\u2019s locked - - Access Private Space from your apps list - - Some system apps are already installed in Private Space - - Couldn\u2019t set up Private Space - - Try again now, or come back later + Set up a private space + + Keep private apps in a separate space that you can hide or lock + + How it works + + You can access your private space from the bottom of your apps list + + Apps in your private space are protected by a lock + + Notifications from apps in your private space are hidden when it\u2019s locked + + Apps in your private space won\'t appear in permission manager, privacy dashboard, and other settings when your private space is locked.\n\nYour private space can\'t be moved to a new device. You\'ll need to set up another private space if you want to use it on another device.\n\nAnyone that connects your device to a computer or installs harmful apps on your device may be able to access your private space. + + Setting up private space\u2026 + + Notifications from apps in private space are hidden when it\u2019s locked + + Unlock your space to share photos or files from private space apps + + Some apps are already installed in your private space + + Couldn\u2019t set up private space - Try Again - - Use screen lock to unlock? - - You can unlock Private Space the same way you unlock your device, or choose a different lock - - Use screen lock - - Choose new lock - - All set! - - You can access Private Space from your apps list - - Done + Try Again + + Use screen lock to unlock private space? + + You can unlock your private space the same way you unlock your device, or choose a different lock + + Use screen lock + + Choose new lock + + All set! + + To access your private space, go to your apps list then scroll down + + Done - Scroll down to access Private Space - - Sign in to set up Private Space - - You need to sign in to an account to set up Private Space + Scroll down to find private space + + Sign in to set up a private space + + You need to sign in to an account to set up a private space Choose a lock for your private space diff --git a/res/xml/privatespace_setup_education_entries.xml b/res/xml/privatespace_setup_education_entries.xml deleted file mode 100644 index 18fb19d3f06..00000000000 --- a/res/xml/privatespace_setup_education_entries.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - - - - - - - - diff --git a/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java b/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java index 77d57f71ebf..9e905f215cc 100644 --- a/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java +++ b/src/com/android/settings/privatespace/AutoAdvanceSetupFragment.java @@ -52,16 +52,17 @@ public class AutoAdvanceSetupFragment extends InstrumentedFragment { private static final String TITLE_INDEX = "title_index"; private static final int DELAY_BETWEEN_SCREENS = 5000; // 5 seconds in millis private static final int ANIMATION_DURATION_MILLIS = 500; + private static final int HEADER_TEXT_MAX_LINES = 4; private GlifLayout mRootView; private Handler mHandler; private int mScreenTitleIndex; private static final List> HEADER_IMAGE_PAIRS = ImmutableList.of( - new Pair(R.string.privatespace_apps_hidden_title, + new Pair(R.string.private_space_notifications_hidden_title, R.drawable.privatespace_setup_flow_placeholder), - new Pair(R.string.privatespace_access_from_apps_title, + new Pair(R.string.private_space_share_photos_title, R.drawable.privatespace_setup_flow_placeholder), - new Pair(R.string.privatespace_system_apps_installed_title, + new Pair(R.string.private_space_apps_installed_title, R.drawable.privatespace_setup_flow_placeholder)); private Runnable mUpdateScreenResources = @@ -116,6 +117,7 @@ public class AutoAdvanceSetupFragment extends InstrumentedFragment { mRootView = (GlifLayout) inflater.inflate(R.layout.privatespace_advancing_screen, container, false); + mRootView.getHeaderTextView().setMaxLines(HEADER_TEXT_MAX_LINES); updateHeaderAndImage(); mHandler = new Handler(Looper.getMainLooper()); mHandler.postDelayed(mUpdateScreenResources, DELAY_BETWEEN_SCREENS); diff --git a/src/com/android/settings/privatespace/PrivateProfileCreationError.java b/src/com/android/settings/privatespace/PrivateProfileCreationError.java index 91c35a31b97..74beef4efe8 100644 --- a/src/com/android/settings/privatespace/PrivateProfileCreationError.java +++ b/src/com/android/settings/privatespace/PrivateProfileCreationError.java @@ -47,14 +47,14 @@ public class PrivateProfileCreationError extends InstrumentedFragment { final FooterBarMixin mixin = rootView.getMixin(FooterBarMixin.class); mixin.setPrimaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_tryagain_label) + .setText(R.string.private_space_tryagain_label) .setListener(onTryAgain()) .setButtonType(FooterButton.ButtonType.NEXT) .setTheme(com.google.android.setupdesign.R.style.SudGlifButton_Primary) .build()); mixin.setSecondaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_cancel_label) + .setText(R.string.private_space_cancel_label) .setListener(onCancel()) .setButtonType(FooterButton.ButtonType.CANCEL) .setTheme( diff --git a/src/com/android/settings/privatespace/PrivateSpaceAccountLoginError.java b/src/com/android/settings/privatespace/PrivateSpaceAccountLoginError.java index ac3518ec848..e445a7f54fc 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceAccountLoginError.java +++ b/src/com/android/settings/privatespace/PrivateSpaceAccountLoginError.java @@ -51,7 +51,7 @@ public class PrivateSpaceAccountLoginError extends InstrumentedFragment { final FooterBarMixin mixin = rootView.getMixin(FooterBarMixin.class); mixin.setPrimaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_tryagain_label) + .setText(R.string.private_space_tryagain_label) .setListener(nextScreen()) .setButtonType(FooterButton.ButtonType.NEXT) .setTheme(com.google.android.setupdesign.R.style.SudGlifButton_Primary) diff --git a/src/com/android/settings/privatespace/PrivateSpaceEducation.java b/src/com/android/settings/privatespace/PrivateSpaceEducation.java index 887854b5919..eb562af428c 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceEducation.java +++ b/src/com/android/settings/privatespace/PrivateSpaceEducation.java @@ -50,14 +50,14 @@ public class PrivateSpaceEducation extends InstrumentedFragment { final FooterBarMixin mixin = rootView.getMixin(FooterBarMixin.class); mixin.setPrimaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_setup_button_label) + .setText(R.string.private_space_setup_button_label) .setListener(onSetup()) .setButtonType(FooterButton.ButtonType.NEXT) .setTheme(com.google.android.setupdesign.R.style.SudGlifButton_Primary) .build()); mixin.setSecondaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_cancel_label) + .setText(R.string.private_space_cancel_label) .setListener(onCancel()) .setButtonType(FooterButton.ButtonType.CANCEL) .setTheme( diff --git a/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java b/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java index dd4bc7f2aa4..a256ea6a197 100644 --- a/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java +++ b/src/com/android/settings/privatespace/PrivateSpaceSetLockFragment.java @@ -60,14 +60,14 @@ public class PrivateSpaceSetLockFragment extends InstrumentedFragment { final FooterBarMixin mixin = rootView.getMixin(FooterBarMixin.class); mixin.setPrimaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_use_screenlock_label) + .setText(R.string.private_space_use_screenlock_label) .setListener(onClickUse()) .setButtonType(FooterButton.ButtonType.NEXT) .setTheme(com.google.android.setupdesign.R.style.SudGlifButton_Primary) .build()); mixin.setSecondaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_set_lock_label) + .setText(R.string.private_space_set_lock_label) .setListener(onClickNewLock()) .setButtonType(FooterButton.ButtonType.NEXT) .setTheme( diff --git a/src/com/android/settings/privatespace/SetupSuccessFragment.java b/src/com/android/settings/privatespace/SetupSuccessFragment.java index fc2ce46e73b..0b1b9d97763 100644 --- a/src/com/android/settings/privatespace/SetupSuccessFragment.java +++ b/src/com/android/settings/privatespace/SetupSuccessFragment.java @@ -55,7 +55,7 @@ public class SetupSuccessFragment extends InstrumentedFragment { final FooterBarMixin mixin = rootView.getMixin(FooterBarMixin.class); mixin.setPrimaryButton( new FooterButton.Builder(getContext()) - .setText(R.string.privatespace_done_label) + .setText(R.string.private_space_done_label) .setListener(onClickNext()) .setButtonType(FooterButton.ButtonType.NEXT) .setTheme(com.google.android.setupdesign.R.style.SudGlifButton_Primary) @@ -104,6 +104,7 @@ public class SetupSuccessFragment extends InstrumentedFragment { } private void accessPrivateSpaceToast() { - Toast.makeText(getContext(), R.string.scrolldown_to_access, Toast.LENGTH_SHORT).show(); + Toast.makeText(getContext(), R.string.private_space_scrolldown_to_access, + Toast.LENGTH_SHORT).show(); } } diff --git a/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java b/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java index 04101b2add8..54b0374676f 100644 --- a/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java +++ b/src/com/android/settings/privatespace/onelock/UseOneLockControllerSwitch.java @@ -192,7 +192,7 @@ public class UseOneLockControllerSwitch extends AbstractPreferenceController new AlertDialog.Builder(mContext) .setMessage(R.string.private_space_new_lock_title) .setPositiveButton( - R.string.privatespace_set_lock_label, + R.string.private_space_set_lock_label, (dialog, which) -> { Intent intent = new Intent(mContext, PrivateProfileContextHelperActivity.class); @@ -201,7 +201,7 @@ public class UseOneLockControllerSwitch extends AbstractPreferenceController UNUNIFY_PRIVATE_LOCK_FROM_DEVICE_REQUEST, /*Options*/ null, mUserHandle); }) - .setNegativeButton(R.string.privatespace_cancel_label, + .setNegativeButton(R.string.private_space_cancel_label, (DialogInterface dialog, int which) -> { mUnifyProfile.setChecked(true); dialog.dismiss();