From e55bffaf59d4de908eb2d0806165363f06c7413f Mon Sep 17 00:00:00 2001 From: Daniel Nishi Date: Tue, 27 Jun 2017 15:59:47 -0700 Subject: [PATCH] Put the donut on a diet. Shrinks the donut from 6dp to 4dp to closer match the mocks. Change-Id: Iaf455beb4f54e7673ff6adc6068e0410fac379b5 Fixes: 62548749 Test: Manual --- res/values/dimens.xml | 3 +++ src/com/android/settings/widget/DonutView.java | 6 ++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 76dacb30f24..1af83956be2 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -319,8 +319,11 @@ 14sp 10sp + + 4dp 66dp 100dp + diff --git a/src/com/android/settings/widget/DonutView.java b/src/com/android/settings/widget/DonutView.java index 295cb79bed7..9a14b3bca4a 100644 --- a/src/com/android/settings/widget/DonutView.java +++ b/src/com/android/settings/widget/DonutView.java @@ -39,7 +39,6 @@ public class DonutView extends View { // From manual testing, this is the longest we can go without visual errors. private static final int LINE_CHARACTER_LIMIT = 10; private float mStrokeWidth; - private float mDeviceDensity; private int mPercent; private Paint mBackgroundCircle; private Paint mFilledArc; @@ -54,8 +53,7 @@ public class DonutView extends View { public DonutView(Context context, AttributeSet attrs) { super(context, attrs); - mDeviceDensity = getResources().getDisplayMetrics().density; - mStrokeWidth = 6f * mDeviceDensity; + mStrokeWidth = context.getResources().getDimension(R.dimen.storage_donut_thickness); final ColorFilter mAccentColorFilter = new PorterDuffColorFilter( Utils.getColorAttr(context, android.R.attr.colorAccent), @@ -92,7 +90,7 @@ public class DonutView extends View { resources.getDimension(R.dimen.storage_donut_view_percent_text_size)); mBigNumberPaint.setTextAlign(Paint.Align.CENTER); mBigNumberPaint.setTypeface(Typeface.create( - getContext().getString(com.android.internal.R.string.config_headlineFontFamily), + context.getString(com.android.internal.R.string.config_headlineFontFamily), Typeface.NORMAL)); }