diff --git a/res/layout/bluetooth_pin_confirm.xml b/res/layout/bluetooth_pin_confirm.xml index a768908dc88..2e2cd7ff454 100644 --- a/res/layout/bluetooth_pin_confirm.xml +++ b/res/layout/bluetooth_pin_confirm.xml @@ -29,15 +29,61 @@ android:orientation="vertical"> + android:textAppearance="@android:style/TextAppearance.Material.Body1" + android:textColor="@*android:color/secondary_text_material_light" /> + + + + + + + + diff --git a/res/layout/bluetooth_pin_entry.xml b/res/layout/bluetooth_pin_entry.xml index 44d9dde7167..caca4fb502e 100644 --- a/res/layout/bluetooth_pin_entry.xml +++ b/res/layout/bluetooth_pin_entry.xml @@ -29,22 +29,31 @@ android:orientation="vertical"> + android:textAppearance="@android:style/TextAppearance.Material.Caption" /> + + @@ -53,8 +62,8 @@ android:text="@string/bluetooth_pin_values_hint" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginStart="20dip" - android:layout_marginEnd="20dip" + android:layout_marginStart="@dimen/bluetooth_dialog_padding" + android:layout_marginEnd="@dimen/bluetooth_dialog_padding" android:gravity="center_vertical" android:textAppearance="?android:attr/textAppearanceSmall" /> @@ -63,8 +72,8 @@ android:text="@string/bluetooth_enable_alphanumeric_pin" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginStart="20dip" - android:layout_marginEnd="20dip" + android:layout_marginStart="@dimen/bluetooth_dialog_padding" + android:layout_marginEnd="@dimen/bluetooth_dialog_padding" android:gravity="center" android:textAppearance="?android:attr/textAppearanceSmall" /> @@ -72,8 +81,8 @@ android:id="@+id/message_below_pin" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginStart="20dip" - android:layout_marginEnd="20dip" + android:layout_marginStart="@dimen/bluetooth_dialog_padding" + android:layout_marginEnd="@dimen/bluetooth_dialog_padding" android:gravity="center_vertical" android:textAppearance="?android:attr/textAppearanceMedium" /> diff --git a/res/values/dimens.xml b/res/values/dimens.xml index bbe62a541da..18306ca0ad2 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -219,6 +219,7 @@ 8dip 32 + 20dp 1px diff --git a/res/values/strings.xml b/res/values/strings.xml index 392a43a8a28..205874932db 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1131,10 +1131,12 @@ Bluetooth pairing request - To pair with:<br><b>%1$s</b><br><br>Type the device\'s required PIN: + Device + + Pairing code - To pair with:<br><b>%1$s</b><br><br>Type the device\'s required passkey: + Type the pairing code then press Return or Enter PIN contains letters or symbols diff --git a/src/com/android/settings/bluetooth/BluetoothPairingDialog.java b/src/com/android/settings/bluetooth/BluetoothPairingDialog.java index 99220428edf..02eed9954a2 100755 --- a/src/com/android/settings/bluetooth/BluetoothPairingDialog.java +++ b/src/com/android/settings/bluetooth/BluetoothPairingDialog.java @@ -175,7 +175,8 @@ public final class BluetoothPairingDialog extends AlertActivity implements private View createPinEntryView(String deviceName) { View view = getLayoutInflater().inflate(R.layout.bluetooth_pin_entry, null); - TextView messageView = (TextView) view.findViewById(R.id.message); + TextView messageViewCaption = (TextView) view.findViewById(R.id.message_caption); + TextView messageViewContent = (TextView) view.findViewById(R.id.message_subhead); TextView messageView2 = (TextView) view.findViewById(R.id.message_below_pin); CheckBox alphanumericPin = (CheckBox) view.findViewById(R.id.alphanumeric_pin); mPairingView = (EditText) view.findViewById(R.id.text); @@ -194,7 +195,7 @@ public final class BluetoothPairingDialog extends AlertActivity implements break; case BluetoothDevice.PAIRING_VARIANT_PASSKEY: - messageId1 = R.string.bluetooth_enter_passkey_msg; + messageId1 = R.string.bluetooth_enter_pin_msg; messageId2 = R.string.bluetooth_enter_passkey_other_device; // Maximum of 6 digits for passkey maxLength = BLUETOOTH_PASSKEY_MAX_LENGTH; @@ -206,9 +207,8 @@ public final class BluetoothPairingDialog extends AlertActivity implements return null; } - // HTML escape deviceName, Format the message string, then parse HTML style tags - String messageText = getString(messageId1, Html.escapeHtml(deviceName)); - messageView.setText(Html.fromHtml(messageText)); + messageViewCaption.setText(messageId1); + messageViewContent.setText(deviceName); messageView2.setText(messageId2); mPairingView.setInputType(InputType.TYPE_CLASS_NUMBER); mPairingView.setFilters(new InputFilter[] { @@ -219,33 +219,46 @@ public final class BluetoothPairingDialog extends AlertActivity implements private View createView(CachedBluetoothDeviceManager deviceManager) { View view = getLayoutInflater().inflate(R.layout.bluetooth_pin_confirm, null); - // Escape device name to avoid HTML injection. + // Escape device name to avoid HTML injection. String name = Html.escapeHtml(deviceManager.getName(mDevice)); - TextView messageView = (TextView) view.findViewById(R.id.message); + TextView messageViewCaption = (TextView) view.findViewById(R.id.message_caption); + TextView messageViewContent = (TextView) view.findViewById(R.id.message_subhead); + TextView pairingViewCaption = (TextView) view.findViewById(R.id.pairing_caption); + TextView pairingViewContent = (TextView) view.findViewById(R.id.pairing_subhead); + TextView messagePairing = (TextView) view.findViewById(R.id.pairing_code_message); - String messageText; // formatted string containing HTML style tags + String messageCaption = null; + String pairingContent = null; switch (mType) { + case BluetoothDevice.PAIRING_VARIANT_DISPLAY_PASSKEY: + case BluetoothDevice.PAIRING_VARIANT_DISPLAY_PIN: case BluetoothDevice.PAIRING_VARIANT_PASSKEY_CONFIRMATION: - messageText = getString(R.string.bluetooth_confirm_passkey_msg, - name, mPairingKey); + messageCaption = getString(R.string.bluetooth_enter_pin_msg); + pairingContent = mPairingKey; break; case BluetoothDevice.PAIRING_VARIANT_CONSENT: case BluetoothDevice.PAIRING_VARIANT_OOB_CONSENT: - messageText = getString(R.string.bluetooth_incoming_pairing_msg, name); - break; - - case BluetoothDevice.PAIRING_VARIANT_DISPLAY_PASSKEY: - case BluetoothDevice.PAIRING_VARIANT_DISPLAY_PIN: - messageText = getString(R.string.bluetooth_display_passkey_pin_msg, name, - mPairingKey); + messageCaption = getString(R.string.bluetooth_enter_pin_msg); break; default: Log.e(TAG, "Incorrect pairing type received, not creating view"); return null; } - messageView.setText(Html.fromHtml(messageText)); + + if (messageViewCaption != null) { + messageViewCaption.setText(messageCaption); + messageViewContent.setText(name); + } + + if (pairingContent != null) { + pairingViewCaption.setVisibility(View.VISIBLE); + pairingViewContent.setVisibility(View.VISIBLE); + pairingViewContent.setText(pairingContent); + messagePairing.setVisibility(View.VISIBLE); + } + return view; }